From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103800 invoked by alias); 3 Nov 2017 01:31:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103788 invoked by uid 89); 3 Nov 2017 01:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1896 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 01:31:47 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vA31VfbE018204 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 2 Nov 2017 21:31:45 -0400 Received: by simark.ca (Postfix, from userid 112) id EF93B1E526; Thu, 2 Nov 2017 21:31:40 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A433A1E4C4; Thu, 2 Nov 2017 21:31:30 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Nov 2017 01:31:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 09/13] Use gdb::def_vector in ppc-linux-tdep.c In-Reply-To: <20171102223612.3642-10-tom@tromey.com> References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-10-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Nov 2017 01:31:41 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00060.txt.bz2 On 2017-11-02 18:36, Tom Tromey wrote: > This removes a cleanup from ppc-linux-tdep.c, replacing it with > gdb::def_vector. > > gdb/ChangeLog > 2017-11-02 Tom Tromey > > * ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use > gdb::def_vector. > --- > gdb/ChangeLog | 5 +++++ > gdb/ppc-linux-tdep.c | 13 ++++--------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c > index 847908a6da..4d10a24ca9 100644 > --- a/gdb/ppc-linux-tdep.c > +++ b/gdb/ppc-linux-tdep.c > @@ -725,26 +725,21 @@ ppc_linux_get_syscall_number (struct gdbarch > *gdbarch, > struct regcache *regcache = get_thread_regcache (ptid); > struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); > - struct cleanup *cleanbuf; > - /* The content of a register */ > - gdb_byte *buf; > /* The result */ > LONGEST ret; > > /* Make sure we're in a 32- or 64-bit machine */ > gdb_assert (tdep->wordsize == 4 || tdep->wordsize == 8); > > - buf = (gdb_byte *) xmalloc (tdep->wordsize * sizeof (gdb_byte)); > - > - cleanbuf = make_cleanup (xfree, buf); > + /* The content of a register */ > + gdb::def_vector buf (tdep->wordsize); I would prefer if you used gdb::byte_vector, so it's consistent across the codebase. > > /* Getting the system call number from the register. > When dealing with PowerPC architecture, this information > is stored at 0th register. */ > - regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf); > + regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf.data ()); > > - ret = extract_signed_integer (buf, tdep->wordsize, byte_order); > - do_cleanups (cleanbuf); > + ret = extract_signed_integer (buf.data (), tdep->wordsize, > byte_order); > > return ret; > } You can skip the ret variable. Simon