From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62384 invoked by alias); 9 Aug 2017 19:34:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62360 invoked by uid 89); 9 Aug 2017 19:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=18601 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 19:34:24 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACAF9138510 for ; Wed, 9 Aug 2017 19:34:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ACAF9138510 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 349DF5D6A5; Wed, 9 Aug 2017 19:34:23 +0000 (UTC) Subject: Re: [PATCH 39/40] Breakpoints in symbols with ABI tags (PR c++/19436) To: Pedro Alves , gdb-patches@sourceware.org References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-40-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: Date: Wed, 09 Aug 2017 19:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1496406158-12663-40-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00206.txt.bz2 On 06/02/2017 05:22 AM, Pedro Alves wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * completer.h (completion_match_for_lcd) mark_ignored_range>: New methods. > : Consider ignored ranges. > : Clear ignored ranges. > : New fields. > * cp-support.c (cp_search_name_hash): Ignore ABI tags. > (cp_symbol_name_matches_1, cp_fq_symbol_name_matches): Pass the > completion_match_for_lcd pointer to strncmp_iw_with_mode. > (test_cp_symbol_name_cmp): Add [abi:...] tags unit tests. > * language.c (default_symbol_name_matcher): Pass the > completion_match_for_lcd pointer to strncmp_iw_with_mode. > * linespec.c (linespec_lexer_lex_string): Don't tokenize ABI tags. > * utils.c (skip_abi_tag): New function. > (strncmp_iw_with_mode): Add completion_match_for_lcd parameter. > Handle ABI tags. > * utils.h (strncmp_iw_with_mode): Add completion_match_for_lcd > parameter. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.linespec/cpls-abi-tag.cc: New file. > * gdb.linespec/cpls-abi-tag.exp: New file. Just one little thing: the PR# isn't mentioned in the ChangeLogs. [This is also c++/18601, but I've marked that as a dup of this bug which is discussed more.] Keith