From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yKBLJb9WlGFxSgAAWB0awg (envelope-from ) for ; Tue, 16 Nov 2021 20:11:27 -0500 Received: by simark.ca (Postfix, from userid 112) id 8732F1F0C1; Tue, 16 Nov 2021 20:11:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 02C901E940 for ; Tue, 16 Nov 2021 20:11:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A1FC385AC2B for ; Wed, 17 Nov 2021 01:11:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A1FC385AC2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637111486; bh=tITxEvjK/UMrK1MwHNuIo/rmYnwtq+0oG2nv2HA7KFA=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uULnIvFuwk/dOBrJZxto4pInaqA7Xu/v+LtPH2pPFBjqD4Y1sPMWo2gXSJw/OdNUI Ec0DtRpYYQnBq3pBDIgYjjoDc0klYDrqYFs9i24QD+3JNcv2Xn/dPnVg+JzSeMJSlf T+QVELEheiZZplgXe7nsckwklqAT5Du0DNczmh/k= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7BC723858410; Wed, 17 Nov 2021 01:10:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BC723858410 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1AH19wND027170 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Nov 2021 20:10:03 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1AH19wND027170 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0E8961E940; Tue, 16 Nov 2021 20:09:58 -0500 (EST) Message-ID: Date: Tue, 16 Nov 2021 20:09:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2] gdb/nat/linux-osdata.c: fix build on gcc-12 (string overfow) Content-Language: en-US To: Sergei Trofimovich , binutils@sourceware.org References: <20211116235521.223574-1-slyich@gmail.com> In-Reply-To: <20211116235521.223574-1-slyich@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 17 Nov 2021 01:09:58 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Sergei Trofimovich , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-16 18:55, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > On gcc-12 build fails as: > > ../../gdbserver/../gdb/nat/linux-osdata.c: In function 'void linux_xfer_osdata_processes(buffer*)': > ../../gdbserver/../gdb/nat/linux-osdata.c:330:39: error: > '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=] > 330 | sprintf (core_str, "%d", i); > | ^ > > It's an off-by-one case in an infeasible scenario for negative > huge core count. The change switches to std::string for memory > handling. > > Tested by running 'info os processes' and checking CPU cores column. Thanks, this is ok. Do you have push access, or do you want me to push it on your behalf? Simon