From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uW81Jdzx/2i2dgwAWB0awg (envelope-from ) for ; Mon, 27 Oct 2025 18:27:40 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=k0hsEVng; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 93A781E0BC; Mon, 27 Oct 2025 18:27:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A8161E057 for ; Mon, 27 Oct 2025 18:27:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C06CB3858C54 for ; Mon, 27 Oct 2025 22:27:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C06CB3858C54 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=k0hsEVng Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 9F3463858D20 for ; Mon, 27 Oct 2025 22:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F3463858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F3463858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761604022; cv=none; b=BJeS5ScZPk5dykZ4U9ShGBKfm6O1gbv1q13Zd+wEsD961qmxfiRzvA1MEps+7AHEGvn5nEDZvuN1a2uCqImpZWsnUQ4MUthLCk4KeHEPZes7nJoggMCjd0LBnu55y9wvP/ujgkaRmglA52LRXxurMPFFYMLvZJD06kvFqrHPsTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761604022; c=relaxed/simple; bh=dX4B4jVNxC/Ql3z0ma7TPMBDHpTJES1vkMZjs2XGOiM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aRM2net3xy+uC3KJ2pxpu0GWMu4uQpJROeKcI+t9+jbPbTYq5VTIrSdO4u9DY437U1wid3DqOqtJvOf3GAI9YLFwyNxVWQNlhvnrz0PUqH4zVZeFw3QHZIH5z+MSp9QYGRYkh3bVZ41BBpCzsnOiDL/2yU2dJRLDEttYQ0a7HQg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F3463858D20 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47103b6058fso38173265e9.1 for ; Mon, 27 Oct 2025 15:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761604021; x=1762208821; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uDdea4b6fKRgqGv/wqq3PVvNt+XWKtnKEcaXt5KlZ/4=; b=k0hsEVngO+mKB2GiBuTueNynX5KPYlrC3hWfK62hHU3cCnBEm9kXf+Fu7URFdtCDJR yxhVcjdWyJhUhZcFaNdoazqCPLDevovud+gjsNak1PvWtzcvk8RDbLX3weEtNj/Bubl9 kHIoNnNwekV0y+FZZwcjgQ/ztMYTcj0YCKwqhiK88Ael/DEBKtHH+sa67R56ut8S9Vk9 bDUYRq+y1iiMNOJNULbkwmlsvXKBjW9pLc/C2JgzWvLL7k3aiYWcA59iZlrOlOEX1tau J6/sprVYjDev84viH0b1xTCVnp8ErdRlz6FSH3W+Bv6Xr4F/dcfUFVgP0Sirlh7/8dkI yEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761604021; x=1762208821; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uDdea4b6fKRgqGv/wqq3PVvNt+XWKtnKEcaXt5KlZ/4=; b=YVUhpnk5yFMwcDPxJY7JezHbML9iy7xEZstDLWeIZr+CYOIihF7i2+rFgBg/V8Is9v 0Orgkud/KQAEe5D+fieWfm9LyUsAFYEp4fpk43tQUc0XDN1uNZj2S9hxQBwPP1oQM1TZ fH2/enpJIgaxF7vlvJSCipsVgKHNZxknFNWWSSlZHKcGU436Goa4xEduvFVlAKMGQilz 9ssQuHUajx5VcZiCgde1/itQ4j8L2Nbm7l5dBTELDy3H+H9oyenRUY2TSX3DrETttFB0 s1qd0myxr3+Sfnf8LzUKSTT/wydeHnmsd9S5u4W9EzTnLy5WYIdG2BH0HBHeXEJCQ8vf zQ8Q== X-Forwarded-Encrypted: i=1; AJvYcCXv1JY7+WzmEHlUDKAnzi7sjwObbTbnucFV2nQhdXGW/nqVzo91H+fRHUumUuUfZpZRgKekwYeXxhCI1A==@sourceware.org X-Gm-Message-State: AOJu0YxI6vWztbw4SVqIgPPhE0pGn+qASB8A6pqX+ZXDbyl5xSVhHmX0 UM9vJmamgGSL/i+VZXodwWuwZ1YzLg2HRtrd8xdQxN6GwTpciRyix0xVVqYkkA== X-Gm-Gg: ASbGncs8N5EBhTQK3i82cRHW3UC28xDY2GEb5qkPj+iek4uIE20szGxhmTPIhpkas3q 6RxMxkcBYDKHkwleNyp5nTkt+vGE+8+mkSIWQ8gBYAh08W8uoIIuCrc7V272GgudYZ3KiLMM7qO i5CVDqO4QkeRLiKb+JrZgBpLov6YLbKx20pJbYKtKK8s5p8dAxjOgbdK/Cf8KV1gAKM79VH135j eL2FGQMmFp9zCcHPo5ML4SmphvoMnyk2vi+eI6cW7fkYUE6suJqfwzHt+HmIkHQIWWxRutB9mEJ ymt15rFgTLK+d7+VCHiNmnrUm3+HVkMDqliCisZJkBYWmpsYAmSS0v2VzBVSFpZ2dhnwiGLqOJS /UMTcUaBKAvRZOLoOA4h6/UwsRQQqocFqYRqCT0ZuUhA3hg3BeC76OcishmpllomYPLoi2a98gg gWU7a6idsiXj9BL3qiEDPLP4U= X-Google-Smtp-Source: AGHT+IFfZzNMobvUHMMQmq+CJniNHZ9wrH0Q4cu3qTvmx9fBOg8qxvsGjH9Qr2lbdA5aQ1q8AjCqdA== X-Received: by 2002:a05:600c:5cc:b0:475:dc5f:134c with SMTP id 5b1f17b1804b1-477181a8586mr5017385e9.18.1761604021277; Mon, 27 Oct 2025 15:27:01 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd4783b8sm159720285e9.15.2025.10.27.15.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 15:27:00 -0700 (PDT) Message-ID: Date: Mon, 27 Oct 2025 22:26:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251021150300.59860-1-Ezra.Sitorus@arm.com> <20251021150300.59860-3-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251021150300.59860-3-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 21/10/2025 16:02, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add support for FPMR in gdbserver. > --- > Changes from v1->v2: > * Addressed comments/whitespace/formatting issues. > * gdb/arch/aarch64.h: operator() takes fpmr into account now. > * Defined HWCAP2_FPMR in gdb/arch/aarch64.h > > Changes from v2-v3: > * Formatting fixes. > * Moved initialisation of fpmr variables closer to where they are used. > > Ezra > > gdbserver/linux-aarch64-low.cc | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc > index 9d3ac803e7b..d63f3e2ad2c 100644 > --- a/gdbserver/linux-aarch64-low.cc > +++ b/gdbserver/linux-aarch64-low.cc > @@ -248,6 +248,26 @@ aarch64_store_fpregset (struct regcache *regcache, const void *buf) > supply_register (regcache, AARCH64_FPCR_REGNUM, ®set->fpcr); > } > > +/* Fill BUF with the FPMR register set from the regcache. */ > + > +static void > +aarch64_fill_fpmr_regset (struct regcache *regcache, void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + collect_register (regcache, fpmr_regnum, fpmr); > +} > + > +/* Store the FPMR register set to regcache. */ > + > +static void > +aarch64_store_fpmr_regset (struct regcache *regcache, const void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + supply_register (regcache, fpmr_regnum, fpmr); > +} > + > /* Store the pauth registers to regcache. */ > > static void > @@ -879,6 +899,10 @@ static struct regset_info aarch64_regsets[] = > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TAGGED_ADDR_CTRL, > 0, OPTIONAL_REGS, > aarch64_fill_mteregset, aarch64_store_mteregset }, > + /* Floating Point Mode Register (FPMR). */ > + { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_FPMR, > + 0, OPTIONAL_REGS, > + aarch64_fill_fpmr_regset, aarch64_store_fpmr_regset }, > /* TLS register. */ > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TLS, > 0, OPTIONAL_REGS, > @@ -954,6 +978,10 @@ aarch64_adjust_register_sets (const struct aarch64_features &features) > if (features.gcs_linux) > regset->size = sizeof (user_gcs); > break; > + case NT_ARM_FPMR: > + if (features.fpmr) > + regset->size = sizeof (uint64_t); > + break; > default: > gdb_assert_not_reached ("Unknown register set found."); > } > @@ -986,6 +1014,7 @@ aarch64_target::low_arch_setup () > features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; > features.tls = aarch64_tls_register_count (tid); > features.gcs = features.gcs_linux = linux_get_hwcap (pid, 8) & HWCAP_GCS; > + features.fpmr = linux_get_hwcap2 (pid, 8) & HWCAP2_FPMR; > > /* Scalable Matrix Extension feature and size check. */ > if (linux_get_hwcap2 (pid, 8) & HWCAP2_SME) This is OK. Thanks! Approved-By: Luis Machado