From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12712 invoked by alias); 28 Apr 2017 14:55:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12694 invoked by uid 89); 28 Apr 2017 14:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Cc, Hx-languages-length:802, ugh X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 14:55:20 +0000 Received: by mail-wm0-f47.google.com with SMTP id m123so49251725wma.0 for ; Fri, 28 Apr 2017 07:55:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=smBoevy1koWKVNSV5c3tR5ZMnyS3g61rpbbE9jjGaFo=; b=KUF2Osyv8Oh7tLyWQ1O4B0R9kzfX2j3nUEGfsBvLBWDpwoccv1eFUmFz/PEeA71Yt+ aLcv8Vk9IZBfN4gQOtoWtKSJoC61//H4XNmM81Fv5ALpiVCdIaiT1iY3fKou94VkOAvS y8j73UgmtKvLP/BJb8kZvdQ0wNkK+A2mZZo7Zr6P3fLgfE5+tqqCXQdz8a6XRgT2QRvl EgBG767Ko77evfHH4HR1wzIZHHg03eIDk4nJeN5qksHSXq5hD1txSWnW11Drpnz56eMF qCgngIsHB9Ojy+i60mdEl7KLBzSSVLjJPAkhjzlEZNzlolhR1hfCYAnt+90Cuvak5EGm gSTg== X-Gm-Message-State: AN3rC/5muC8SRo0nDBmSGz+oaUFlNoT3xBN4+pSGeAt6VWhqCVnsF1qP vmV6n5ZdjNAj9Pfzf5o6Eg== X-Received: by 10.28.24.8 with SMTP id 8mr6406520wmy.133.1493391319995; Fri, 28 Apr 2017 07:55:19 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id p22sm2433916wmi.18.2017.04.28.07.55.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 07:55:19 -0700 (PDT) Subject: Re: [RFA 06/10] Allow C-c to work in backtrace in more cases To: gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-7-tom@tromey.com> From: Phil Muldoon Message-ID: Date: Fri, 28 Apr 2017 14:55:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-7-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00786.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > PR cli/17716 notes that it is difficult to C-c (or "q" at a pagination > prompt) while backtracing using a frame filter. One reason for this > is that many places in py-framefilter.c use RETURN_MASK_ALL in a > try/catch. > > This patch changes these spots to use RETURN_MASK_ERROR instead. This > is safe to do because this entire file is exception safe now. > > ChangeLog > 2017-04-25 Tom Tromey > > PR cli/17716: > * python/py-framefilter.c (py_print_type, py_print_value) > (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use > RETURN_MASK_ERROR. Ugh that was a simple mistake from when I submitted the patch and thanks for cleaning that up. Patch LGTM Cheers, Phil