From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0aehALLLsWjxZA8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 11:48:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=m4VtllUa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D71F11E04C; Fri, 29 Aug 2025 11:48:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E0D31E043 for ; Fri, 29 Aug 2025 11:48:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A3521385841C for ; Fri, 29 Aug 2025 15:47:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3521385841C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=m4VtllUa Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2096.outbound.protection.outlook.com [40.107.115.96]) by sourceware.org (Postfix) with ESMTPS id 63DAF3858C74 for ; Fri, 29 Aug 2025 15:47:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63DAF3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 63DAF3858C74 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.96 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756482442; cv=pass; b=pYQfiKBi4uDi32JWxRlexIX3BdEyPfRoEnrdVpFMNpOazTuaNK2NwMg6jGxugUlcmNLyTMzA1zOCqtpwofws2HhtdCYnz39p2dx+VEF/64YeCkEtiU11DNLneb0qWJDBtmGEt8nCB84rWAqY4nG0r+Yo3VzVW8X3fAxiFhIubCE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756482442; c=relaxed/simple; bh=Z+gkZHMhAROhYYj9B6lEJ8OJ6WPzMDKoXDgAe0Q7/mM=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Cs3+PaXCjrn8j4R9HTkM4ZhljlwgVhpHEgv/ntEq2ZbM4uzXe57PrWB7Ts+C90qGZWHC5U+soVn0OaXnY6C0/WMrMO0QYI+1lLpSNZmVXm70mpcsINiekVEiNpG9IVePzW72JnkG/LVsZXOQxYbQCeRn8BcWV8mceCj+XvgwC3c= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63DAF3858C74 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VruWCB8HJ/RACGIBkHlkAVk4vJKuqikDIdKY0abqosYsgyOdH4b0ZxkT8+q6KbrC4iOUgHYMOOG8xN9wm/7oULXZaGBMaO/nUeO4zXjf95Nu6s20vuxCaINlRtdm52gweelsYUVq/bWAl8aAv5dyJLvBpVadR5xxR6zxZXjc0kvZnLjW1p3dDzDzHsFdJqoqVtYgaVIIHFUYfeVGdq01VLf5DOJqNU7e1+VbcTl0j7SSBHV+jUQKjBd6yCz7KRaHPM6GBAS3ZoFWxsim6Zwg0HoPsL0KSJv+AAaB6UCAqArPlksccAxD/q53gwN7tt5BjzOBQAMLxn1VqrtFVY5dvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2QdxarKfVEY8ocGmsxxNTguDGxQHGolqmCZNpgylmSg=; b=cG6xtNbRhzLTeUZPNAihiNa5uadV73jpTfOEUEHaTqWZgrD2knNPho891G6C5IUu10vTkWXCADUAanLWkO0qkNeXmbEVxrMkzdWEwHclviA6gm7tYeo+fP++X8H3gY/U1yNfb/p+WnIsg36iucu1a5og4Yf2Lxgo2WvqpZPTMhvIvrjB8NOoQUMadQlJfP31zl2Cmq2IPO855syAQ3FT3BAFYH2qp6Azpu4Qz885f4ZWtomlQNhwQqHYByD20Ay+wo0akOBUzaaVlxHNrGFj0OLs7sHDcLacFoAD/fb08x+p74WrpZNs0g47Y2KdSRQfAQP6XDT+x0Ic1D126soROQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QdxarKfVEY8ocGmsxxNTguDGxQHGolqmCZNpgylmSg=; b=m4VtllUareFibYIjCbOmAsE/6X2IP0YISp54Se3wwxLclihLKPkPayeUb2jKZSCbIgQXUveMtkN6RjgLCIf8VqYeSW9ls3AHRmkFnLTYorTQUqAPuzxoukM4XGnXlxRAm375UTGT4aHO+/QbnPWltorz0KSK7Lo36Q+Jyv+Y8Pz9G03FzFYfne8JFqX+igZNKlm6ByRHo4OBs1xn4oIyI5/QvjEiVrKq9CHRNFEwt4j1OlLV1IIlJT8SHpYA06Cn0ibOGWOZQwSbT+noYh8Dma/izkif6nJ1rLhzEaRdDmQwbS693rvmWH+YhsMmdAjdX7PVF3lj2Xu0NPrLtwseSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by QB1PPF5BF03A7F1.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c08::245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.18; Fri, 29 Aug 2025 15:47:12 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86%2]) with mapi id 15.20.9073.021; Fri, 29 Aug 2025 15:47:12 +0000 Message-ID: Date: Fri, 29 Aug 2025 11:47:11 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/objfiles: make objfile::sections yield references To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250828151100.84594-1-simon.marchi@efficios.com> <87a53iuu9d.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87a53iuu9d.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0328.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6c::20) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|QB1PPF5BF03A7F1:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f7cda4-56ed-4fa5-3a56-08dde71351cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WjRtaU5PU1RzMEE4bGRrM1gvTXVRaHlmTUZramtwb3ZEVGNDVWlqTXlKdWJn?= =?utf-8?B?NEJWTWo3YmJvbFNWQ1JLcFFwcGMwVkJtU0IrWUJBcnlUTENJU3lzTlM1bWpV?= =?utf-8?B?TEUwSFRkTzhKRm9hOG1CMHlrMWRTOGsrUzA3Z1lEWDZKaXF4YnJ4R2o3RWhU?= =?utf-8?B?MGJDOC9nK0tJODdqSzMzZVplL3ltSEk5RHR0blVWT0JCWlptYkNGMWppY0Fw?= =?utf-8?B?aUZkU1VzekFSKzlBaG5wZWJVeGhMZjdYblpCSFdLL2RHc0o5V2JSSFdQVTYz?= =?utf-8?B?R25uNjJJSkVLcTBLb3g2SzlmSnhPNmVNZ09sNENWSXFWQUQ3MncxVnZHemJt?= =?utf-8?B?VXJYYTVwYTZXRkxjLzE0M3RUVzRGYm1pMEpzeU5NQnUzNjdBbEIvY1ZJcVhj?= =?utf-8?B?Y2prOGVDdmhMV1F3dnY2S29EWGJudW9nNXlzdXFVOTJ2U1QyM242cUFZeDJ0?= =?utf-8?B?MzRldXh6ZE5PZ0h5K0V3cE5RWnFOOVdlQmtsTlhHR3FIc250dU1OY2FhcGJI?= =?utf-8?B?bldRanF5NWdabUZDMUJyelowNlZ0VkFKVnl3OXpXYmFja0FxZGZDbUg1UGxs?= =?utf-8?B?UXM5cE8zTktJM2pCdzNZalRudmRtbDgzb1A3ejFOVk1DSG01UUovam9tV2Nh?= =?utf-8?B?T25Za1RSNTVGaVl6UVBIdE9BSlhkaXlYSDZrYm9JZ01OMDk1ZjdvRlJHSmls?= =?utf-8?B?aHNmL0pteFpPRW1nblMxcHdMS3pKZ1A0K0hSa05FUXpyczlJamJXNVlyZnoz?= =?utf-8?B?a1RuWnZzcjcvaWxLZzQxRjZteTI2RDZ3cllGeHRiOGpVZ3R3ekwzM1FreS9Q?= =?utf-8?B?TWY5NDk3YjRaV1ZwU0h3RzhDQkM0cW1xa1laSkd5ajlYZmdYTWttRllKdEVC?= =?utf-8?B?OTRBSmFpd3JBaDNxQVNyRDU0TVdWKzk2SnY4YXlEWm82TTk2SUFUa0U1WnJ6?= =?utf-8?B?dG1HdTZ5R2VyR2puMHFERnZWWExpUjVkcCtuMUExUnVveUhjTldPUHNKaDUr?= =?utf-8?B?Vmh6VWV0OFdPRVBpZEIvbzltNlFLaGZJaVBBYVVyQmcxZWhVdGkyWlVYdjdV?= =?utf-8?B?M0VFbnlNNndwNXZxWlJGUUhEV0hwbjRaZHdpeHRCZVB6QzhQOHFVWlNKSWl3?= =?utf-8?B?L2Q2TFdxL0VELzhSSVlSQnMzdCtJOWhJTnNQbStIYUtWSnljbC82b2xSbjd0?= =?utf-8?B?K0lJNlFLazdEUDVtSEdOVmh0Tm13V0ZRU0VoeHAzc05lbCtOTmFMSXl6UUE1?= =?utf-8?B?WkxnNXU3eStacTJqUHlxNE9CQkc3b0NlSFoyUWtPelNDNkdmWmEyWm1kakor?= =?utf-8?B?Yi9xbXErYVhIYmhPOU40S21pZnV3VmN1OUdhay8vd0Q5b0pLbExidjBTVzBj?= =?utf-8?B?UmVYalk3Z2RDbDAzeUxBNzU0TWVHTXdBbVVxVkRua3JzVDdUWlN4VFNoNUhn?= =?utf-8?B?WDNGaGJ5akFZNlI2SDczYkw4Q29MYVNwblYyZGNYUnpKY0JnbHdhUFF5RTdY?= =?utf-8?B?S1NIcnRad1prL1Zka3hhWFpSelRSdngzY1ZFUEtmZDU4MXJNRmxPOWdkSTlR?= =?utf-8?B?NC9wVEVrcmh4QURSTnRyZUVORkk1a1FYUEpiUEVoTFVnWEtsc3BJakRpVWJ2?= =?utf-8?B?RHZkRDRIdDN5VFluK1pnL3VCeXV4cmdCaW5Edzl2bm5sd0RwV083a096ZXRP?= =?utf-8?B?ZzZhOHlwUlhPcXlVWmNHaDNQenFMYjNPdjVMb2J3ZWdYcVBQb1pwM1Jvbkh6?= =?utf-8?B?RVBhdExram5FdGd1Vit4NENTTlI3V0I1TGVFREdBd0NjOGdobVkvcDNkM0tB?= =?utf-8?Q?6m5fxE60nqIg1c9WHd7xueL0GAFTNRG3sI0Y8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3JsK2R0ZCtWVHhIZk9SZyttRzV2eGlPTFl4ejZKKzcxbEJiWHpYMWR1aEFT?= =?utf-8?B?YSt5cXM0eVpaTXZCWnN4bEw1VnZTcjJDRWxHWTRNcklGRmZRRXlQOGVuVUlZ?= =?utf-8?B?SDdEN3hHcG1ob3FZbGw4SDE1bzJGcTVkZDRYZjBlcjNZMHNVaWJKckxzZFhy?= =?utf-8?B?b1p6OUZHY1lqOGxDYyszSjA3U3dXRVd6clNISThCbWJFUWdKYm9lL3l3aHJp?= =?utf-8?B?WDZXa1loWUtPbmlaRzIxWnJHUnlXanovbTk5R1JmeU03SmpPQURpaVFYak90?= =?utf-8?B?UHpZVzRYcG4xcGlRbUI5bUxFUWZQRGROSm4vL0pob2RsTDI1eEVWRHpxMUtt?= =?utf-8?B?Y1gwYk5Cb2U5RGFraVJxMGw1TEhVZ1drcW5IWG9uMGw1RDgzT295bStDeEhW?= =?utf-8?B?Z1FwaVJ3RDRQWVViMDVWNDB5L0NkeGkvQ2V0UjhOSDlWcncxZGg2LzdBa050?= =?utf-8?B?Y0NZV3ZRT05idGF5VnhackxHNW1zTWZjYkMvNnlRcWZjRVVsQTFMcklXcjN6?= =?utf-8?B?QXB2aWVEZXdKTHB5UVhOM1YrYkoyMlFrOEl1Q3NtVUl5ZzRMaXFNaEF5S0xa?= =?utf-8?B?L0tzKzRJb0hSSFlLTVRTdndTNUIzaHJEdkpUVDJFRWpkdHI4RjgwaTlwV1Vq?= =?utf-8?B?M3ZlazF5cTZSSWIvSDZ1Y3VhLzgrdStpTHBJOTQwUjNkZEtDUFU5SXRFWWJL?= =?utf-8?B?Tmc4QXI1VnRVeWhBcWhKUFRPeEswTSt5N1c3cXNzK294THp4eGdaejZReEpJ?= =?utf-8?B?M1BhUGFMcmQxMkk1d0J6azlZU0hUQ1FyaXpGaWJlbXRaSzV5ZWdDQ041N0Fv?= =?utf-8?B?a0ZValovclJDai9WWGJrZGpHbUdVYitLdVh5ZGVpSEdSQVJmK2htZWgxTXFX?= =?utf-8?B?MGhQMktVUGZyWkZVdENhN21HSzRtTGxwY2x1d0plVzA2clEybTloOEFVUDlP?= =?utf-8?B?MW5NM2hCaGpLSittaTVwY2pnNkRZOG93Q3dVbkY2OGxxbkRHMzB0enA0WXhP?= =?utf-8?B?cmdETWVUMkNvVDBKSEo2RjJGa1Y2TU5WWDR3UXlBMW9GR2g5RnBibHJPb0Ja?= =?utf-8?B?T0EyZDF2UmUyaVJudTBwbExrYUZMTEtIMFp0dzBPQXg5aERsTFVnbE96ZXlE?= =?utf-8?B?L0VDMW9XcUtHU0V4c0JDMG1YWUtrRTRMRm5KWWdaZ1Q2Z2FIU29TcEl0VUZ6?= =?utf-8?B?bGdtVHhTZjVNQi8zNW5DM3IwdUlTMS9ZUm11VkJiemkydWtVU2RMNkN1TTJ5?= =?utf-8?B?TDBVVHlsZmI0SXFNeklMeWhOSFRHc1JLQVZuSEJhdEVXYkM2b0lSOHR1bGlJ?= =?utf-8?B?UmFJVG53RzBnMWowWjYycjZ3bUptSHFoblFBaW96ZHRyM2ZoZG44SWtQMnBi?= =?utf-8?B?ZmtCUFR3QmxlbnJxMGNUb0NaS1pYV3dPdEFRMjRsVGhMemNuWXFGVlRxc3lN?= =?utf-8?B?TDk4QWlYd2lubzNpc1MwdThmVmFaYnZOcVEvZnZBdUJJa3hjRHNHOGZiK0dy?= =?utf-8?B?ZVpxaWhZaGFVWHRNaEZBTllCMG4rVC9kZ0VsN2pkc0hpZXZMYS8zTmhpbWhL?= =?utf-8?B?SERYL3ppSjcvUjdqL1E3Y1BpNnM1V3ZxL3dYVFQrSkErb2RSamxKSnFnQ2Z2?= =?utf-8?B?dTFtVkFWL1B1a0pXYjdPVnJvOGZVa05YVjNIcnVhUE5DTWNlYkpVRlMxbURo?= =?utf-8?B?TEJtYU1xZTVSczFkKzBmcm1Da3lubWhFUGZ2SkZKd3Q3VzV6d2crOW9vRWpT?= =?utf-8?B?bmdlWFRHMmpPQXVZN0M4WWhsbVdURld6NlNZOElXYTB6NmpONXpIaGVKTk8z?= =?utf-8?B?ajJ5UnhvMXE1TnpJSGMrRURURlJ2Vk9Dd29jOFdSLzYrNk1zRHJtRDRsTlNF?= =?utf-8?B?MGUzWHdNZCt1dGNzREg4blN5bG5NemhWSnY2VFZPbTZLME9LZ3J0OUhIZXFm?= =?utf-8?B?TkFhbG5INko3SnpUV1A5Y0ZlaVpmY29sOHVyTER4eWtPUlhBV0s1OEhkb2dC?= =?utf-8?B?b3k4bEx6VXhReWlqeDh2VzlXV3V3Zm5VS3dmZk0yU2liWERkVzlraEc2b2c5?= =?utf-8?B?d0FpMHE3L2lNbC81VS9FTVdFOURzWitScXVBZkg2TDJENGdqZGk3NXQ0bS8z?= =?utf-8?Q?aClf0tK61oknh+7JVJ55ZroLl?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f7cda4-56ed-4fa5-3a56-08dde71351cc X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 15:47:12.1430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YrmRRMhnfX6FWpknJvSxf7wtKQH+mMKx6PipFd/reG8yEDfWSAnyiqYythGmlxXX9ierUV8kSjOWrLfseyhIpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: QB1PPF5BF03A7F1 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-08-29 09:34, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> A patch later in this series would change objfile::section_iterator to > Simon> yield `obj_section &` instead of `obj_section *`. Do it as a > Simon> preparatory patch to avoid polluting that subsequent patch. I think it > Simon> would make sense on its own anyway. > > Seems ok. > > Simon> - typedef section_iterator self_type; > Simon> - typedef obj_section *value_type; > Simon> + using self_type = section_iterator; > Simon> + using reference = obj_section &; > > I never remember when value_type or reference need to be declared. > Is it really correct to remove value_type? I don't know for sure, but cppreference's iterator_traits page [1] says this for C++17: Nested type Definition ----------- ---------- difference_type Iter::difference_type value_type Iter::value_type pointer Iter::pointer reference Iter::reference iterator_category Iter::iterator_category If Iter does not have any of the five nested types above, then this template has no members by any of those names (std::iterator_traits is SFINAE-friendly). (valid for C++17, until C++20) So I guess if you tried to use iterator_traits with a type missing any of those typedefs, it wouldn't work. But the original section_iterator already missing reference and som others, so it's already in that state. If that ever becomes a problem, I think we'll get a build failure, so we'll know. I think I had some cases of that in an earlier iteration of this series, where I had to add the missing member types for the compiler to be happy. And anyway, this particular code disappears in the last patch of the series, so I'm not too worried about that particular instance. [1] https://en.cppreference.com/w/cpp/iterator/iterator_traits.html > > Approved-By: Tom Tromey Thanks, I will push this one right away. Simon