From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136364-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 33240 invoked by alias); 20 Jan 2017 15:43:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 33137 invoked by uid 89); 20 Jan 2017 15:43:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jan 2017 15:43:15 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1cUbLO-0000o3-6j from Luis_Gustavo@mentor.com ; Fri, 20 Jan 2017 07:43:14 -0800
Received: from [172.30.9.36] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 20 Jan 2017 07:43:10 -0800
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp
References: <1484923045-16703-1-git-send-email-lgustavo@codesourcery.com> <d1b2f240-5d39-ed03-1628-2996f1da531d@redhat.com> <1ea54e93-2d77-e90c-5129-3a0a82301ab1@codesourcery.com> <70e0a255-c215-2617-2714-229bfddf594c@redhat.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <c1976385-0d7f-5389-f01b-d17ffd45480c@codesourcery.com>
Date: Fri, 20 Jan 2017 15:43:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <70e0a255-c215-2617-2714-229bfddf594c@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2017-01/txt/msg00420.txt.bz2

On 01/20/2017 09:34 AM, Pedro Alves wrote:
> On 01/20/2017 03:30 PM, Luis Machado wrote:
>
>>
>> How about the following?
>
>
>>  # Skip all tests if Python scripting is not enabled.
>> -if { [skip_python_tests] } { continue }
>> +if { [skip_python_tests] } {
>> +    untested "skipping Python tests"
>> +    return
>> +}
>>
>
> There's an "unsupported" call inside skip_python_tests.

Hmm, i was working under the assumption this was a flag. In this case it 
would make sense to handle all of these checks in the same way and not 
add untested calls, making everything standard.

I can work on that, but should we drop adding any untested calls in this 
particular patch and only return (until a follow on patch)?