Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
Date: Mon, 09 Jul 2018 19:01:00 -0000	[thread overview]
Message-ID: <c1780523-591d-40d3-9d95-8d526ce9f0c5@redhat.com> (raw)
In-Reply-To: <1530304703.1512.17.camel@skynet.be>

On 06/29/2018 09:38 PM, Philippe Waroquiers wrote:
> On Fri, 2018-06-29 at 22:15 +0200, Philippe Waroquiers wrote:
>> Whatever we take, we have to ensure that gdb.texinfo systematically use 
>> it to identify a frame as shown by backtrace (#integer).
> Note that in the online help, we have already some usages of level
> speaking about frames.
> 
> So, all that taken into account, my preference would be to remove
> the frame number wording,
> and use frame level everywhere in the doc and online help : 
> LEVEL seems more clear/intuitive than NUMBER or ID
> 
> But whatever choice is ok for me.

Ahah, I did warn about having to decide this at
<https://sourceware.org/ml/gdb-patches/2018-06/msg00410.html>.

Thanks Andrew for bringing this up.

I agree, "level" seems like the best option to me.  I should have
suggested that one more strongly instead of "id" when I wrote
the above, but I was distracted thinking that we'd end up
with "count" instead.  :-)

Thanks,
Pedro Alves


      reply	other threads:[~2018-07-09 19:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 18:37 Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 2/8] Implement frame apply [all | COUNT | -COUNT | id ID... ] [FLAG]... COMMAND Philippe Waroquiers
2018-07-09 19:16   ` Pedro Alves
2018-07-10 21:50     ` Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 7/8] Modify gdb.threads/pthreads.exp to test FLAG qcs arguments for thread apply Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 4/8] Documents the new commands 'frame apply', faas, taas, tfaas Philippe Waroquiers
2018-07-09 19:16   ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 3/8] Add [FLAG]... arguments to 'thread apply' Philippe Waroquiers
2018-07-09 19:18   ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 8/8] Add a self-test for cli-utils.c Philippe Waroquiers
2018-07-09 19:27   ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 5/8] Announce the user visible changes for frame/thread apply in NEWS Philippe Waroquiers
2018-06-24 18:37 ` [RFA_v3 1/8] Add helper functions parse_flags and parse_flags_qcs Philippe Waroquiers
2018-07-09 19:14   ` Pedro Alves
2018-06-24 18:37 ` [RFA_v3 6/8] Add a test for 'frame apply' Philippe Waroquiers
2018-07-09 19:19   ` Pedro Alves
2018-06-29 12:22 ` [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Andrew Burgess
2018-06-29 20:16   ` Philippe Waroquiers
2018-06-29 20:38     ` Philippe Waroquiers
2018-07-09 19:01       ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1780523-591d-40d3-9d95-8d526ce9f0c5@redhat.com \
    --to=palves@redhat.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox