From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eSR+ITCFqGgrqAkAWB0awg (envelope-from ) for ; Fri, 22 Aug 2025 10:56:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=F/so62DR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9G/eTwQH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=F/so62DR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9G/eTwQH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8394A1E048; Fri, 22 Aug 2025 10:56:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 897801E023 for ; Fri, 22 Aug 2025 10:56:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FA013851C2B for ; Fri, 22 Aug 2025 14:56:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FA013851C2B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=F/so62DR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9G/eTwQH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=F/so62DR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9G/eTwQH Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 565F43858D32 for ; Fri, 22 Aug 2025 14:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 565F43858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 565F43858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874576; cv=none; b=fTv3z7YSmPZG+3LlxGQMUon2rY9Npm02i7MRmv3dz1eP9OZ2TzB2p4vkOB+Nelsu7k4qsHFBbkZOcoBLfk4/UQB52L72Y3YcZU4v2LNYa2DvmB+qXB4kVhWFbW/b1foSd/OTqBcDDaViCLioOzYZqBqifvDoBApDbkaLwYA5Kp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874576; c=relaxed/simple; bh=BvkyWlu73GX+8X/RMMlBA7YJ67rpV/uZHgT0KB1mJPQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=UfAjcL0I6IDRbG4FBF3N+sJ+Xr4VLJaPyD0DM+0jJ39f09B3CDbVxq2czZPM5PLGVa26JtyC8usCkN1/LuxMdrkRHXuYzAt0+Y9LrdyLSTsgtXFcuvcUpMkTCypR0X0LW/z1Z6dvYPcgGVITN0aoKCNc6Hc0H6w0jpWEmygTRNQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 565F43858D32 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3BEBB1F394 for ; Fri, 22 Aug 2025 14:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755874575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQEq39Vgge2AqTgHcPHsn30MVnu7nIhqi5d40lI2ntc=; b=F/so62DRdeLyIsRXucaQ8PR2MqyHNamV00Y9Fxr2ozsEPH7WoTY0ezpyuRVJJl37B/1FqN emmdxYEGtA8dFcESoS/Wr+AtAhWlstMfllmYv3v7sWKGXemaNRefERx5oPht7TPwkQQYvR xUsHfq+CYUYoXZcEx9Eh8orVmoznV/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755874575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQEq39Vgge2AqTgHcPHsn30MVnu7nIhqi5d40lI2ntc=; b=9G/eTwQHUsTz4zklwlKuj6Ly4jcc674bfeFWbnqelT3fzX/ZtBi0kpIihD9ZvDfJm8+mYa +qmOGty+Prh1Z8Cw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="F/so62DR"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="9G/eTwQH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755874575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQEq39Vgge2AqTgHcPHsn30MVnu7nIhqi5d40lI2ntc=; b=F/so62DRdeLyIsRXucaQ8PR2MqyHNamV00Y9Fxr2ozsEPH7WoTY0ezpyuRVJJl37B/1FqN emmdxYEGtA8dFcESoS/Wr+AtAhWlstMfllmYv3v7sWKGXemaNRefERx5oPht7TPwkQQYvR xUsHfq+CYUYoXZcEx9Eh8orVmoznV/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755874575; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQEq39Vgge2AqTgHcPHsn30MVnu7nIhqi5d40lI2ntc=; b=9G/eTwQHUsTz4zklwlKuj6Ly4jcc674bfeFWbnqelT3fzX/ZtBi0kpIihD9ZvDfJm8+mYa +qmOGty+Prh1Z8Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 286A113931 for ; Fri, 22 Aug 2025 14:56:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eKEuCA+FqGgBEwAAD6G6ig (envelope-from ) for ; Fri, 22 Aug 2025 14:56:15 +0000 Message-ID: Date: Fri, 22 Aug 2025 16:56:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] [gdb/symtab] Improve invalid range check in create_addrmap_from_gdb_index From: Tom de Vries To: gdb-patches@sourceware.org References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-5-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20250821133114.24091-5-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3BEBB1F394 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/21/25 15:31, Tom de Vries wrote: > + if (valid_range_p) > + { > + CORE_ADDR relocated_lo > + = per_objfile->relocate (unrelocated_addr (lo)); > + CORE_ADDR relocated_hi_m1 > + = per_objfile->relocate (unrelocated_addr (hi_m1)); > + struct obj_section *lo_sect = find_pc_section (relocated_lo); > + struct obj_section *hi_sect = find_pc_section (relocated_hi_m1); > + valid_range_p = lo_sect != nullptr && hi_sect != nullptr; > + } It turns out that this doesn't always work. I ran the test-case gdb.base/code_elim.exp (which uses add-symbol-file) with target board cc-with-gdb-index, and ran into the following problem. Function addr_info_make_relative gets called, which puts the section table into some relative address state. Consequently, the relocated address are also relative, and aren't found using find_pc_section. I'll submit a v3 once I've fixed this. Thanks, - Tom