From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65549 invoked by alias); 7 Feb 2020 20:54:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65541 invoked by uid 89); 7 Feb 2020 20:54:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 20:54:32 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0798D1E05A; Fri, 7 Feb 2020 15:54:30 -0500 (EST) Subject: Re: [PATCH v3] Add debuginfod support to GDB To: Aaron Merey , gdb-patches@sourceware.org Cc: Tom Tromey , Christian Biesinger References: From: Simon Marchi Message-ID: Date: Fri, 07 Feb 2020 20:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00187.txt.bz2 On 2020-02-07 2:27 p.m., Aaron Merey wrote: > The previous revision of this patch had pkg.m4 included in > gdb/aclocal.m4. In order to avoid any concerns regarding the copyright > of pkg.m4 I've removed it and slightly modified the configure-time > handling of debuginfod support. > > Aaron > Oh well I just reviewed v2 here: https://sourceware.org/ml/gdb-patches/2020-02/msg00185.html I presume that the code I reviewed did not change, and that my comments are still valid. Simon