From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ObMOGi0zl2rdzhsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 16:18:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1788293933; bh=tk201IGPqw/e+8qkB5G75EvWr6O4RoswiD0V8BTFIIs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eb6hQptEEA5C45j5HOYpnLdoVDDfPH44L1JwUJwlamVpJ+/AV5lJo1OHkAZSBB6Oq obYytKEsbB/2G0RoP7bVOiwELF/O1tW4n7enx0zhsgiUaf8gTQFOfU21i3+8xLyAtw Uxstk8TBGfDPV54Yx59vefytESZsICaCPvayy5IA= Received: by simark.ca (Postfix, from userid 112) id 61EE71E166; Tue, 01 Sep 2026 16:18:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=naC+vK8U; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 497441E033 for ; Tue, 01 Sep 2026 16:18:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D19A34BA79A9 for ; Tue, 1 Sep 2026 20:18:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D19A34BA79A9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=naC+vK8U Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0B88D4BA799E for ; Tue, 1 Sep 2026 20:18:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B88D4BA799E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B88D4BA799E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788293906; cv=none; b=Juas5bSic4SgkSg/fG60Qj1SFcMHDpTnciyyuGLdiztGJSoJvHxJFBEm4v/lV93uW1aPTo1LIi9g2/v8waA+pXbGMot4UiZ19s3wxTee3DpO5H9plT6xv9Ri+m5pKE7Bi5986fm+NuTkWHPLFERbSPOpb/YRnDOuvyJHttUaDRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788293906; c=relaxed/simple; bh=tk201IGPqw/e+8qkB5G75EvWr6O4RoswiD0V8BTFIIs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cjd2fIoypPgRgfiL0GAH87Nyumc7gmfVOD0WeA66I5r79PDdpoaUPVcS1cGyhSx3KhE7tz3+mn40ycH/ij6vdCwD07ul/2fSBSbllfVhs9wZGRK+2NCKYOGNCh/bgZmEwxtsSFcJO3D2Rx+OzAvDNHN/g1PvSQL8oKcszILASaQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=naC+vK8U DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B88D4BA799E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1788293905; bh=tk201IGPqw/e+8qkB5G75EvWr6O4RoswiD0V8BTFIIs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=naC+vK8UFr8oDGlC39/5gVMnvJsJpDYeuFKwjIVs65TxkWgOHXtqiQSnEpO1PO3Dg 69uqsAfYeoNSXOayN4wBvyLeKxa2dCR4Q2RIz3iPNe750V/3EvXrDBHXv1baYOc7ni Pbq5A2rnbGCskhwu8ZFHZHAF1EMiAYecmR7rCw00= Received: by simark.ca (Postfix) id 27A521E033; Tue, 01 Sep 2026 16:18:25 -0400 (EDT) Message-ID: Date: Tue, 1 Sep 2026 16:18:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] gdb, gdbserver: create the dependency directories from the Makefiles To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260831185300.572297-1-simon.marchi@efficios.com> <20260831185300.572297-8-simon.marchi@efficios.com> <87mru07wb2.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87mru07wb2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-01 12:47, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Note that this changes the command to create directories from "$(SHELL) > Simon> $(srcdir)/../install-sh -d" to "mkdir -p". If there is a reason to use > Simon> install-sh to create directories in the build directory, I think it > Simon> should be documented, otherwise it just looks strange. > > In the old days, 'mkdir -p' wasn't portable. That's why mkinstalldirs > existed. Not sure why this code used install-sh. > > I don't know if 'mkdir -p' can be used today, though I tend to assume it > can; and anyway it's easy to switch to mkinstalldirs if need be. > > Simon> @@ -2413,11 +2408,8 @@ clean mostlyclean: $(CONFIG_CLEAN) > Simon> rm -f gdb$(EXEEXT) core make.log > Simon> rm -f gdb[0-9]$(EXEEXT) > Simon> rm -f xml-builtin.c stamp-xml > Simon> - rm -f $(DEPDIR)/* > Simon> - for i in $(CONFIG_SRC_SUBDIR); do \ > Simon> - rm -f $$i/*.o; \ > Simon> - rm -f $$i/$(DEPDIR)/*; \ > Simon> - done > Simon> + rm -f $(addsuffix /*,$(ALL_DEPDIRS)) > Simon> + rm -f $(addsuffix /*.o,$(CONFIG_SRC_SUBDIR)) > > Simon> # This used to depend on c-exp.c m2-exp.c TAGS > Simon> # I believe this is wrong; the makefile standards for distclean just > Simon> @@ -2431,10 +2423,7 @@ distclean: clean > Simon> rm -f config.log config.cache > Simon> rm -f config.lt libtool > Simon> rm -f Makefile > Simon> - rm -rf $(DEPDIR) > Simon> - for i in $(CONFIG_SRC_SUBDIR); do \ > Simon> - if test -d $$i/$(DEPDIR); then rmdir $$i/$(DEPDIR); fi \ > Simon> - done > Simon> + rm -rf $(ALL_DEPDIRS) > > I don't think it should be necessary to update both 'clean' and > 'distclean'. The latter should depend on the former. > > The old rule was "if configure made it, distclean removes it; if make > made it, clean removes it". So I think the distclean change should be > dropped. > > I'm unsure if this rule was ever really was discussed outside the > Automake list back in ancient times, I think François Pinard came up > with it. It makes sense for distclean to be a superset of clean, in which case it doesn't need to repeat the same commands. I'll send an updated version of just this patch. Simon