From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23047 invoked by alias); 2 Feb 2017 01:24:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23024 invoked by uid 89); 2 Feb 2017 01:24:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=pray, Hx-languages-length:567 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Feb 2017 01:24:17 +0000 Received: by simark.ca (Postfix, from userid 33) id 79F441E166; Wed, 1 Feb 2017 20:24:10 -0500 (EST) To: Keith Seitz Subject: Re: [PATCH] Make language setting tests more robust X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 02 Feb 2017 01:24:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <58925832.8050306@redhat.com> References: <1485962220-31071-1-git-send-email-lgustavo@codesourcery.com> <331062ebcc7352d7731347260b56dee7@polymtl.ca> <58925832.8050306@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00062.txt.bz2 On 2017-02-01 16:50, Keith Seitz wrote: > Regarding gdb_test_no_output et al, this grokking of args needs to be > banished from the test suite. It adds unnecessary complexity. I would > encourage maintainers to request revision when such a thing is proposed > for the test suite. Ok, good to know I'm not the only one :). When I encounter procs that use this pattern, I have to either: A. Pray that the documentation is still up to date B. Read the code to decode what's being used where Both are not very fun.