From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112117 invoked by alias); 4 Oct 2016 18:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112035 invoked by uid 89); 4 Oct 2016 18:49:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 18:48:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25A3380083; Tue, 4 Oct 2016 18:48:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94ImuBm020303; Tue, 4 Oct 2016 14:48:57 -0400 Subject: Re: [PATCH] Skip float complex types if gdb_skip_float_test To: Yao Qi , gdb-patches@sourceware.org References: <1475591646-9783-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Tue, 04 Oct 2016 18:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475591646-9783-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00064.txt.bz2 On 10/04/2016 03:34 PM, Yao Qi wrote: > If the target doesn't support float, we don't run float complex types > tests. Shouldn't this be checked within support_complex_tests itself? AFAIK, _Complex is always about floating point: http://en.cppreference.com/w/c/language/arithmetic_types#Complex_floating_types http://en.cppreference.com/w/cpp/numeric/complex Thanks, Pedro Alves