From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH, GDB/ARM] Expect prompt after no FPU warning
Date: Wed, 17 May 2017 09:13:00 -0000 [thread overview]
Message-ID: <c0d2b898-4fdb-8d28-e0a5-44aae541fe74@foss.arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Hi,
The expected output for info float when the ARM target has no FPU does
not include the GDB prompt. This occasionally cause a test failure in
the following "finish" test when the prompt happens after the test has been
marked as PASSed, since it does not match the expected output.
This patch adds the GDB prompt to the expected output of the no FPU
regular expression.
ChangeLog entry is as follows:
*** gdb/testsuite/ChangeLog ***
2017-04-27 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.base/float.exp (info float): Expect GDB prompt for ARM
targets without FPU.
Testing: test PASSes with that patch.
Is this ok for master branch?
Best regards,
Thomas
[-- Attachment #2: nofloat_gdb_tests_expect_prompt.patch --]
[-- Type: text/x-patch, Size: 577 bytes --]
diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index a4762c9742682391074f0707e56a6eae4cd70c6e..4f928c19491f55b235aaf68a4c9351531440aa4e 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
# if we have NEON.
pass "info float (VFP)"
}
- -re "No floating.point info available for this processor.*" {
+ -re "No floating.point info available for this processor.*$gdb_prompt $" {
pass "info float (without FPU)"
}
}
next reply other threads:[~2017-05-17 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 9:13 Thomas Preudhomme [this message]
2017-05-17 12:10 ` Yao Qi
2017-05-17 12:20 ` Thomas Preudhomme
2017-05-17 12:53 ` [PATCH, GDB] " Thomas Preudhomme
2017-05-17 13:34 ` Yao Qi
2017-05-17 14:49 ` Thomas Preudhomme
2017-05-18 15:46 ` Thomas Preudhomme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d2b898-4fdb-8d28-e0a5-44aae541fe74@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox