From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id B280A388A83E for ; Mon, 18 May 2020 13:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B280A388A83E Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-eoAlOAZHO4qRRuuhOYWXqg-1; Mon, 18 May 2020 09:52:23 -0400 X-MC-Unique: eoAlOAZHO4qRRuuhOYWXqg-1 Received: by mail-wr1-f69.google.com with SMTP id p8so5690756wrj.5 for ; Mon, 18 May 2020 06:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZIdjU9JVceFI78DTNTj3WcTTDQusXA30Z6MKC4tBOJg=; b=fnrAxR3fx+3Gj4y7zAklgZ2IUio7YbAqxICjioLixYqnpvi/KKeVo04rpNqKhcsPw4 O4rWpPVr6aiT4ayhEPp/jlp5V+XWg7hQ3GdbF79+UqlFuNro8zITdHV30C+cYDqQJVEc QDRVJ9dlS9yYvgE/nLZ3oZvo+qCYrsbBmUbrtgWRYGsdswmQ7PssDGqkkbYB9N2zA5k2 S8CWiaSYSBl+OuGn1pdkYmUy4YJMmdxYljA+3OJKa/cfOaJ73dXlRrPfh3IKTc+sNPlK oIpFc1QgiHLx4TbuitkUkpSaLAwlYYy/ETg1feOYx7CU96YT2YNNrChqX9SEkaf6w33u OUoA== X-Gm-Message-State: AOAM531tQcLMcNVtldYfWkUnxWvPPyofZd1JLOSSX98KcsO20ttYFeU3 QExIDww1Q94tntrI12nMlZWz6kTD/nMgjvkSczax5+J7jDp66jZfFobUeTkic3nfxnmVYMeR6jN VNlw//DRbTC2DnKpLIGCmrg== X-Received: by 2002:a1c:a3c5:: with SMTP id m188mr19826452wme.160.1589809942529; Mon, 18 May 2020 06:52:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycCLApurp0p2DDLMr74Z/Pt/BBGPgSWasBGUq7mNnqqQ8XZEGp/xdbTv7Fp9LyyIsUmbVhiw== X-Received: by 2002:a1c:a3c5:: with SMTP id m188mr19826431wme.160.1589809942275; Mon, 18 May 2020 06:52:22 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c140sm11834213wmd.18.2020.05.18.06.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 06:52:21 -0700 (PDT) Subject: Re: [PATCH 3/3] Make exec-file-mismatch compare build IDs To: Eli Zaretskii References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <834ksebeqz.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 18 May 2020 14:52:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <834ksebeqz.fsf@gnu.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 13:52:28 -0000 On 5/17/20 7:25 PM, Eli Zaretskii wrote: >> From: Pedro Alves via Gdb-patches >> >> +If the debugger can determine that the executable file running in the >> +process it is attaching to does not match the current exec-file loaded >> +by @value{GDBN}, the option @code{exec-file-mismatch} specifies how to >> +handle the mismatch. @value{GDBN} tries to compare the files by >> +comparing their build IDs (@pxref{build ID}). If build IDs are not >> +present in either file, @value{GDBN} compares the file names. The >> +@code{exec-file-mismatch} option specifies how to handle a mismatch. > > The last sentence is a repetition of what was already said a few > sentences back. > > The documentation parts are okay with this nit fixed. Thanks. Thanks, I've removed that sentence. Thanks, Pedro Alves