From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix 8.2 regression in gdb.python/py-evthreads.exp w/ gdbserver (PR gdb/23379)
Date: Fri, 24 Aug 2018 20:06:00 -0000 [thread overview]
Message-ID: <c0b953dc5c682f691ddc5093046f5de7@polymtl.ca> (raw)
In-Reply-To: <f2402304-91d8-77af-7f72-f0d86bd12bbc@redhat.com>
On 2018-08-24 15:47, Pedro Alves wrote:
> On 08/24/2018 08:44 PM, Pedro Alves wrote:
>
>>
>> Yeah, I definitely prefer copy-init when possible. In this
>> case I'd prefer doing that as a separate patch though, because
>> that's not something that the regression fix is adding, and
>> also grepping around I see there's a lot of similar instances
>> that can all get the same treatment. I'll post a patch
>> for that as follow up.
> Here's what I mean.
Indeed, in the previous patch I just meant you could change the line you
were touching (and indeed quoted the wrong hunk), but this more
far-reaching cleanup is great too. I wouldn't put this one in the 8.2
branch though, since it doesn't actually fix anything.
Simon
next prev parent reply other threads:[~2018-08-24 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 17:46 [PATCH] " Pedro Alves
2018-08-24 18:53 ` Simon Marchi
2018-08-24 19:44 ` [PATCH v2] " Pedro Alves
2018-08-24 19:47 ` Pedro Alves
2018-08-24 20:06 ` Simon Marchi [this message]
2018-08-24 22:13 ` [pushed] gdb/python: Use copy-initialization more when possible Pedro Alves
2018-08-24 20:02 ` [PATCH v2] Fix 8.2 regression in gdb.python/py-evthreads.exp w/ gdbserver (PR gdb/23379) Simon Marchi
2018-08-25 14:52 ` Tom Tromey
2018-08-25 15:56 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b953dc5c682f691ddc5093046f5de7@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox