From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id //4YH/ITbF8mbwAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 23:35:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 621CA1EE05; Wed, 23 Sep 2020 23:35:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CDCFD1EDF4 for ; Wed, 23 Sep 2020 23:35:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 758193857C63; Thu, 24 Sep 2020 03:35:13 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6B4533857C63 for ; Thu, 24 Sep 2020 03:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B4533857C63 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E42DC1E509; Wed, 23 Sep 2020 23:35:10 -0400 (EDT) Subject: Re: [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent To: Hannes Domani , gdb-patches@sourceware.org, Eli Zaretskii References: <20200923172122.2089-1-ssbssa@yahoo.de> <20200923172122.2089-3-ssbssa@yahoo.de> From: Simon Marchi Message-ID: Date: Wed, 23 Sep 2020 23:35:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200923172122.2089-3-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-09-23 1:21 p.m., Hannes Domani via Gdb-patches wrote: > GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created > in the target process (like if the target doesn't have a console). > > Since this prevents DebugBreakProcess from being called (which should > always work), this removes it. Eli, does that make sense to you? Just judging from the explanation above, it sounds fine to me. Simon