From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pjw0BOuzHGBYEgAAWB0awg (envelope-from ) for ; Thu, 04 Feb 2021 21:56:43 -0500 Received: by simark.ca (Postfix, from userid 112) id 001001EFCB; Thu, 4 Feb 2021 21:56:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A222E1E945 for ; Thu, 4 Feb 2021 21:56:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E9F2385E001; Fri, 5 Feb 2021 02:56:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E9F2385E001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612493802; bh=u4Rr4kh9pjjNX3wouMO5ZEwaXz8V0piK7OzwF+V1Ajg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mM/fjBDUtwvrAlvxLof9kc4rDmKZ6XNE4kzV8UYfROJx7QLtHp0gD6+IgCdoQVrwh 8b9owIfekWkYIAyVTcEbZHSagdkSbgtv9SB72Ock3cS4qau4Vc7/eCEMxPt3I10BnG TwI8ZTdNHuVnx6lPaZLlI69+mF6FnTUhJkjRmfyI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4C3A1385E001 for ; Fri, 5 Feb 2021 02:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4C3A1385E001 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1152uYvB006554 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 4 Feb 2021 21:56:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1152uYvB006554 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3732D1E945; Thu, 4 Feb 2021 21:56:34 -0500 (EST) Subject: Re: [PATCH v5 05/25] GDBserver remote packet support for memory tagging To: Luis Machado , gdb-patches@sourceware.org References: <20210127202112.2485702-1-luis.machado@linaro.org> <20210127202112.2485702-6-luis.machado@linaro.org> Message-ID: Date: Thu, 4 Feb 2021 21:56:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210127202112.2485702-6-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 5 Feb 2021 02:56:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc > index cfdf1c1883..4e76f08ac5 100644 > --- a/gdbserver/remote-utils.cc > +++ b/gdbserver/remote-utils.cc > @@ -1304,10 +1304,14 @@ prepare_resume_reply (char *buf, ptid_t ptid, > } > } > > -void > -decode_m_packet (char *from, CORE_ADDR *mem_addr_ptr, unsigned int *len_ptr) > +/* Decode ADDR and LEN from a parameter of the form "addr,len", with > + being an end marker character. */ > + > +const char * > +decode_m_packet_params (const char *from, CORE_ADDR *mem_addr_ptr, > + unsigned int *len_ptr, const char end_marker) For new code, IWBN to follow the convention of putting the doc in the header, and putting /* See remote-utils.h. */ here. Otherwise, LGTM. Simon