From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FutIGfWS5WcCqhwAWB0awg (envelope-from ) for ; Thu, 27 Mar 2025 14:03:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RB06Vyqk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5868E1E0C3; Thu, 27 Mar 2025 14:03:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,TRACKER_ID autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 310EF1E0C0 for ; Thu, 27 Mar 2025 14:03:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7F86385AC3A for ; Thu, 27 Mar 2025 18:03:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7F86385AC3A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RB06Vyqk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 200A0385B500 for ; Thu, 27 Mar 2025 18:02:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 200A0385B500 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 200A0385B500 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743098553; cv=none; b=Kbmz4qN8D4yT4nrWJJK0zQwg9koPwkyvwOKeuGetKmfrU6OlQclfU8RaZDtx31js8VEYqwY8dXFn/xRC/dcp4+vjJprYh/zUwhQJ2OYEmWiBdQ+uVz7hfTp2Akvbd6BRp/jqW38YSu0rMNkPaCNXCSXRR8YiA5JD0VOUNWYUG2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743098553; c=relaxed/simple; bh=dCjDriFS46cZcQG/LqXRwJ4Qmj/CTUHPvAwxtlMzAAY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AXaeJ4mN90l5xqCDle+DjR3GqRubMczX8dAqDnY+BlbzcZBANmioRkovSRS9UUSWABH3uq/JJXsP7mHprse1zw8RUMdVSDVlfDJFovp9zE+qfqY2gQKIMqtq648XzBD3dRu2feYGn8GlQ+GOvC4haf3aLktIKb6BqZ/kVswuTm4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 200A0385B500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743098552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LuVsKIr8TdlMeHu5wxYBg1T124xWcIusFK7uez0GhAo=; b=RB06VyqkOA1xqyJ3qim1q49jFQVFYmJ7HOfGxCSVIAHZfwtceVuTJJE0SqraveN+wpnaCE BxoEn5+Yc+vMqVqwq08qWSLxnLspfyeBkWIvcVqr+fFYqf6IgwVtYswCG/8RKCCdimH4gG lu7CXceX9pnp/YE0eN8h28BNQA73bMk= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-BsL9skQMMVeuXFfldHltfw-1; Thu, 27 Mar 2025 14:02:30 -0400 X-MC-Unique: BsL9skQMMVeuXFfldHltfw-1 X-Mimecast-MFC-AGG-ID: BsL9skQMMVeuXFfldHltfw_1743098550 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c5b9333642so159121285a.3 for ; Thu, 27 Mar 2025 11:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743098550; x=1743703350; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LuVsKIr8TdlMeHu5wxYBg1T124xWcIusFK7uez0GhAo=; b=IdNjMgNkbQ0p6GvQUk0TPaILtpb/vZkucrFaqAnHK+xfLZPYSFQ5ZnCrSAv6+DWyJY SX3JIpmsX9jP2OADIAwRmm1Ez+l7PNNmsRMJsA/Qm2GqOa6J45GFgHUqwYSDOXMVdNst hsizFCKYAl+jf97OXg+YfqZGcx7XcP1FBL/RH6LajiZMGbdIDbiY0o4kvK7ECSNnls9v EmTAmnp3NXcs7QLoSkH2oL1ERuD1j88uqJSXMLiU/vxrm9OEZS1DeM9z5mO24zaicFxN +lk82SYjfg1DXXTf3nw+XY4mPp0SyVTI1aQr5HRi07K+HftAvVieSDfBD/Qe1CcjRmnG zGDg== X-Forwarded-Encrypted: i=1; AJvYcCXD7R4UoAdZCtFTRi67AmswAfYIAmE2VDWAVHDAvObQ4HinzfeBoUUNu1ePzCSXJ/jZF5W89VF2NKSswg==@sourceware.org X-Gm-Message-State: AOJu0YxPVJjhAQf15Ira7semwSNnnitGJIxAWCVPqOyYT8RYD3Wl7/EN FJSRMybCbyvxFANn6BcHfuBHbwosvE/4RGDe0Li80e4/d+sYEIMNJO60MEhEhLsZRBiJNFjYTeu OdQdTLh/oTN8Z3MuRF4uvrwF2AfPQdUY4ZoPKDRxi532rYSoCWTgY6Z5eF/5IijtnXDo= X-Gm-Gg: ASbGncsf2QvBJl135p9PHlWXDdCa1nD3bb1GX/QTa7G5kFPk9bVj8zd+CzuPLAuVAJN lRG57xfXt3gFDKT1rvvKn6CLse0fNNsZ7pHfrG2ACUUPaDL56JNXBbQFfPGNtJCbydP2/osavWI peXgotg0MUQYcMt5QmYygdYYxBritVbdSZnBhqxEzT99iXVf/kfXM9eJYVsTZ53M83GfSA12OAe KoFvMiLURhQDi9wzIYGnySs/E6ncuFd03ghYZ8/M6gsq4hotuJXNhNccsLzxqDADwKflgGkWX0O O2scr8/puhOT40YSGDvoxpmgMTI= X-Received: by 2002:a05:620a:444c:b0:7c5:3e22:616e with SMTP id af79cd13be357-7c5eda8492bmr876421085a.56.1743098549472; Thu, 27 Mar 2025 11:02:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfwFVtVgKyJgXQPr5Lppeu+fzxqHE2jhm6JO6mihEmP4lZrGl/tbzbOB/ufwPlywLWmfz1Fw== X-Received: by 2002:a05:620a:444c:b0:7c5:3e22:616e with SMTP id af79cd13be357-7c5eda8492bmr876415785a.56.1743098549006; Thu, 27 Mar 2025 11:02:29 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5f7683a14sm18641085a.42.2025.03.27.11.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Mar 2025 11:02:28 -0700 (PDT) Message-ID: Date: Thu, 27 Mar 2025 15:02:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix gstack issues To: Keith Seitz , gdb-patches@sourceware.org References: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> From: Guinevere Larsen In-Reply-To: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4YQp5aR2QtnvoAmc6Oj0n42HLFu8D64lqdoZ3qrHeJM_1743098550 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/27/25 12:54 PM, Keith Seitz wrote: > With commit fb2ded33c1e519659743047ed7817166545b6d91, I added > Fedora's gstack script to gdb. Some issues have arisen since > then, and this patch addresses those issues: > > . As Sam James recently noted[1], PKGVERSION and VERSION > need to be quoted. > . A Fedora user reported the misuse of --readnever, which > causes gstack to omit filename and line number information in the > backtrace[Red Hat BZ 2354997]. > > [1] https://inbox.sourceware.org/gdb-patches/d19d6bc17e0a160ce27fc572079f11a587c0e168.1742424869.git.sam@gentoo.org/ > Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2354997 > --- Thanks for the quick turnaround in this! I tested this and it works now, thanks! Tested-By: Guinevere Larsen > gdb/gstack-1.in | 8 ++++---- > gdb/testsuite/gdb.base/gstack.exp | 6 ++++-- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/gdb/gstack-1.in b/gdb/gstack-1.in > index 5e413290c9a..25339d9877d 100755 > --- a/gdb/gstack-1.in > +++ b/gdb/gstack-1.in > @@ -1,6 +1,6 @@ > #!/usr/bin/env bash > > -# Copyright (C) 2024 Free Software Foundation, Inc. > +# Copyright (C) 2024-2025 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > @@ -22,8 +22,8 @@ > GDB=${GDB:-$(command -v gdb)} > GDBARGS=${GDBARGS:-} > AWK=${AWK:-} > -PKGVERSION=@PKGVERSION@ > -VERSION=@VERSION@ > +PKGVERSION="@PKGVERSION@" > +VERSION="@VERSION@" > > # Find an appropriate awk interpreter if one was not specified > # via the environment. > @@ -132,7 +132,7 @@ EOF > ) > > # Run GDB and remove some unwanted noise. > -"$GDB" --quiet -nx --readnever $GDBARGS < +"$GDB" --quiet -nx $GDBARGS < set width 0 > set height 0 > set pagination no > diff --git a/gdb/testsuite/gdb.base/gstack.exp b/gdb/testsuite/gdb.base/gstack.exp > index 8df36b1b3bc..89be67619bc 100644 > --- a/gdb/testsuite/gdb.base/gstack.exp > +++ b/gdb/testsuite/gdb.base/gstack.exp > @@ -1,4 +1,4 @@ > -# Copyright (C) 2024 Free Software Foundation, Inc. > +# Copyright (C) 2024-2025 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > @@ -62,8 +62,10 @@ if { ![gdb_assert { ![expr {$res < 0 || $res == ""}] } $test] } { > set test "got backtrace" > set saw_backtrace false > set no_awk false > +set location_re ${srcfile}:${decimal} > + > gdb_expect { > - -i "$res" -re "#0 +(0x\[0-9a-f\]+ in )?main \(\).*\r\nGSTACK-END\r\n\$" { > + -i "$res" -re "#0 +(0x\[0-9a-f\]+ in )?main \(\).*$location_re.*\r\nGSTACK-END\r\n\$" { > set saw_backtrace true > pass $test > exp_continue > > base-commit: 08ed5584d871a1d3fee92917805bda86ce45fac9 -- Cheers, Guinevere Larsen She/Her/Hers