From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35699 invoked by alias); 9 Mar 2018 03:58:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35681 invoked by uid 89); 9 Mar 2018 03:58:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=among X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 03:58:09 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 117441E03D; Thu, 8 Mar 2018 22:58:08 -0500 (EST) Subject: Re: [RFA] Change enable_thread_stack_temporaries to an RAII class To: Tom Tromey , gdb-patches@sourceware.org References: <20180308053543.18516-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Fri, 09 Mar 2018 03:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308053543.18516-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00186.txt.bz2 Oops, forgot this one: On 2018-03-08 12:35 AM, Tom Tromey wrote: > @@ -810,29 +771,26 @@ push_thread_stack_temporary (ptid_t ptid, struct value *v) > struct thread_info *tp = find_thread_ptid (ptid); > > gdb_assert (tp != NULL && tp->stack_temporaries_enabled); > - VEC_safe_push (value_ptr, tp->stack_temporaries, v); > + tp->stack_temporaries.push_back (v); > } > > -/* Return 1 if VAL is among the stack temporaries of the thread > - with id PTID. Return 0 otherwise. */ > +/* Return true if VAL is among the stack temporaries of the thread > + with id PTID. Return false otherwise. */ > > -int > +bool > value_in_thread_stack_temporaries (struct value *val, ptid_t ptid) > { > struct thread_info *tp = find_thread_ptid (ptid); > > gdb_assert (tp != NULL && tp->stack_temporaries_enabled); > - if (!VEC_empty (value_ptr, tp->stack_temporaries)) > + if (!tp->stack_temporaries.empty ()) > { > - struct value *v; > - int i; > - > - for (i = 0; VEC_iterate (value_ptr, tp->stack_temporaries, i, v); i++) > + for (struct value *v : tp->stack_temporaries) > if (v == val) > - return 1; > + return true; The "if (!tp->stack_temporaries.empty ())" here is now unnecessary. Simon