Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue

[SiZiOUS <sizious@gmail.com>]

Le 29/08/2018 à 18:24, Tom Tromey a écrit :
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>>> And I know, the MinGW/MSYS original project is maintained but almost
>>> deprecated in favour of MinGW-w64/MSYS2 project. But I really need XP
>>> support for my needs.
>>> I proposed this patch because it's really simple and not intrusive,
>>> but you're right, how many people uses that old MinGW/MSYS project?
> Simon> If the missing definition is indeed a mingw bug, but there is really
> Simon> no way of getting a new mingw release with that fixed because the
> Simon> project is unmaintained (but still useful to some people), I would not
> Simon> be against a patch like what you proposed.  I would however add a
> Simon> clear comment for why this is needed, so that if some day we
> Simon> officially decide not to support this mingw, we can remove it.
>
> Also, is there any downside to the original patch?
> If not then I think we might as well accept it, subject to Simon's
> request here.
Nope, as it only includes the winerror.h header file just in case that 
the ERROR_IO_PENDING is undefined.
So if ERROR_IO_PENDING is defined (as it would be normally), my patch 
does nothing.
>
> Tom