From: Klee Dienes <klee@apple.com>
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] add 'save-breakpoints' command
Date: Tue, 04 Dec 2001 21:11:00 -0000 [thread overview]
Message-ID: <bzpu5ub6cv.fsf@salmon.localnet> (raw)
In-Reply-To: <3C0D520C.E9016E83@cygnus.com>
> Could you elaborate a little bit on how this change works with
> shlib breakpoints, what the original_type field is for, the
> bp_tbreakpoint type, etc.? In what circumstances is the
> current breakpoint type different from the original breakpoint type?
The original_type field is for cases like 'tbreak' or 'thbreak' where
the bp_type gets set simply to 'breakpoint', but we nonethless want
the proper command to be written to the generated file. In these
cases we just set the original_type field to the appropriate value,
and use that when writing out the command to the file. It's also used
for non-used specified breakpoints --- in these cases the value is set
to 'bp_none', to indicate that it should not be written to the file.
> There are several mentions of future breaks; you should probably
> clean those up until you're ready to submit that feature.
Actually, upon further reflection, I should probably combine the two
diffs and submit them as one patch. Let me look into how well that
works out and post a new diff tomorrow.
> get_breakpoint_count is defined but never used.
Whoops. That's just a function needed by another of our patches that
somehow managed to sneak in. I'll remove it for now.
next prev parent reply other threads:[~2001-12-05 5:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-04 10:21 Klee Dienes
2001-12-04 10:26 ` Daniel Jacobowitz
2001-12-04 10:44 ` Klee Dienes
2001-12-05 14:06 ` Tom Tromey
2001-12-04 11:22 ` Eli Zaretskii
2001-12-04 13:35 ` Klee Dienes
2001-12-05 0:25 ` Eli Zaretskii
2001-12-04 14:48 ` Michael Snyder
2001-12-04 21:11 ` Klee Dienes [this message]
2001-12-11 0:28 ` Klee Dienes
2001-12-11 3:55 ` Eli Zaretskii
2001-12-11 8:35 ` Klee Dienes
2001-12-11 9:09 ` Eli Zaretskii
2001-12-11 13:23 ` Klee Dienes
2001-12-12 0:32 ` Eli Zaretskii
2001-12-14 12:45 ` Klee Dienes
2001-12-14 12:50 ` Daniel Jacobowitz
2001-12-18 1:42 ` Klee Dienes
[not found] <1007594419.30359.ezmlm@sources.redhat.com>
2001-12-05 17:39 ` Jim Ingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bzpu5ub6cv.fsf@salmon.localnet \
--to=klee@apple.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox