From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4551 invoked by alias); 27 Jun 2017 16:29:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4542 invoked by uid 89); 27 Jun 2017 16:29:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 16:29:38 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC45EC04B946; Tue, 27 Jun 2017 16:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC45EC04B946 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EC45EC04B946 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5227517DDB; Tue, 27 Jun 2017 16:29:36 +0000 (UTC) Subject: Re: [RFA 02/10] Change backtrace_command_1 calling to use flags To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-3-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 27 Jun 2017 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-3-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00735.txt.bz2 On 04/25/2017 08:41 PM, Tom Tromey wrote: > @@ -1891,7 +1889,7 @@ backtrace_command (char *arg, int from_tty) > if (subset_compare (this_arg, "no-filters")) > filters = false; > else if (subset_compare (this_arg, "full")) > - fulltrace = true; > + flags |= PRINT_LOCALS; > else > { > /* Not a recognized argument, so stop. */ > @@ -1906,8 +1904,7 @@ backtrace_command (char *arg, int from_tty) > arg = NULL; > } > > - backtrace_command_1 (arg, fulltrace /* show_locals */, > - !filters /* no frame-filters */, from_tty); > + backtrace_command_1 (arg, flags, !filters /* no frame-filters */, from_tty); > } > Looks fine. (We should really make enum frame_filter_flags be an enum-flags.) Thanks, Pedro Alves