From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ivM7GAMevmrvyCIAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 04:46:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oCVM1vbo; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fkS0yB08; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gfXC0gju; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+83gA5sd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 522391E033; Thu, 01 Oct 2026 04:46:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 416791E033 for ; Thu, 01 Oct 2026 04:46:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA5514BB24F5 for ; Thu, 1 Oct 2026 08:46:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA5514BB24F5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oCVM1vbo; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fkS0yB08; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gfXC0gju; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+83gA5sd Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 639F14BA7993 for ; Thu, 1 Oct 2026 08:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 639F14BA7993 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 639F14BA7993 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790844387; cv=none; b=UEhc7KsWh2qrOJ9MvKAXUJkxEaj0dsURQH1V5DnnQUr4G6HM4aVXOlY8iDhFxRjkDX3gcoOMDLbWl4NzYh46AsBW3fNq7uQ61IZWnGCjBaTZ8aHNO79o+UfCdhWjUDfyZSyU5XyHvZRTmM4lootoPMQ7LkGuQ+o/mHovq4XfnVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790844387; c=relaxed/simple; bh=k4kmvdoFQj0UBlPLVr3DJZRpvugaBdpQzvCmCO4V1SE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=csIn7P6yzDhorbxcb58ZHgHRA8e6iRBAMQGyCIOXGARjCLE38b6FmjERvfESGyhJGl/mu/pXTl6FYfSU2mxdvvtW4R7fb4QZvvioG8qUiGEQja1y0wFT9a66dxRooQVG1GUQ3nvrCKo93v4tQ6XDjV+NJSrDH/5ijotVW8jC0Rs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oCVM1vbo; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fkS0yB08; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gfXC0gju; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+83gA5sd DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 639F14BA7993 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48AFF21E5E; Thu, 1 Oct 2026 08:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790844382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zWVJnSue1ZvYYoGwMqta2YaVxRpgwpsvPnm1Mzxzh4Y=; b=oCVM1vboP5I2Az4JnEx2N1m7WGOFYQrXQn/boxZ7i2og1pmpoNQsWjj1mdhsHQVT8i4+zY fi3lcC64NCMIi4kfmqS0W7JuBqxf0vylDRJD1hZkUTVKP+oht8hBXBvidHpjNHJTqPYfWQ aaOxD7USbgD2XIO2E5zORhbdY+Y6d5A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790844382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zWVJnSue1ZvYYoGwMqta2YaVxRpgwpsvPnm1Mzxzh4Y=; b=fkS0yB08ORUnd9TrXC62ZiAx07MqFkWcI/+89CoNDzysebqegMSRXY2OanUt87yobikP9B p76cAT4CHSaiaLAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790844378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zWVJnSue1ZvYYoGwMqta2YaVxRpgwpsvPnm1Mzxzh4Y=; b=gfXC0gjuWL6MLUrr7QpBMK/k58L0o73mMQ1UsfGyLQCLlbPJggPszYu547/4YWi9IYkiem j6ZW8fVvPG7yVzoFq9qeqGqh0lrB2UmjpwZ4fePGgIMikYruypEvwfZJXghTmXqEZN38dT Dplny611G9dBj2uVW12iP7D1lZbKaw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790844378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zWVJnSue1ZvYYoGwMqta2YaVxRpgwpsvPnm1Mzxzh4Y=; b=+83gA5sdv+pmUlyZ1jowZ/k1yLkUaNtKRV7R0iDmWVGqx0r2JxkiPa6zrAGiEKZ5rqhsGJ Bglv/cnM5pgqkTBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 20334134B3; Thu, 1 Oct 2026 08:46:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vQn7NtkdvmqKdgAAD6G6ig (envelope-from ); Thu, 01 Oct 2026 08:46:18 +0000 Message-ID: Date: Thu, 1 Oct 2026 10:46:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Fix formatted print of functions To: Tom Tromey , gdb-patches@sourceware.org References: <20260930120313.3096634-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260930120313.3096634-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.994]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid,sourceware.org:url]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/30/26 2:03 PM, Tom Tromey wrote: > A user noticed that formatted printing of functions is strange. That > is, printing a function normally does what you'd expect, but "print/d" > or "print/x" will, bizarrely, instead print the value of the first > byte of the function's body: > > (gdb) print main > $1 = {} 0x393c20
> (gdb) print/x main > $2 = 0x41 > > This doesn't seem useful or intuitive to me. > Agreed. While reviewing this patch, I stumbled on some inconsistency on handling ptype *main vs p *main, which I filed here ( https://sourceware.org/bugzilla/show_bug.cgi?id=34700 ). > This patch changes gdb to instead simply print the function pointer > using the specified format. > Reviewed-By: Tom de Vries Thanks, - Tom > Regression tested on x86-64 Fedora 43. > > v2: Fixed all the mistakes in the tests. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34685 > --- > gdb/testsuite/gdb.base/printcmds.exp | 13 +++++++++++++ > gdb/testsuite/gdb.cp/printmethod.exp | 11 ++++++++++- > gdb/valprint.c | 8 ++++++++ > 3 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp > index 9de1bcdd1a3..2ae19e9e440 100644 > --- a/gdb/testsuite/gdb.base/printcmds.exp > +++ b/gdb/testsuite/gdb.base/printcmds.exp > @@ -1176,6 +1176,18 @@ proc test_printf_convenience_var {prefix} { > } > } > > +# Test formatted print with a function. See PR gdb/34685. > +proc test_function_print {} { > + with_test_prefix function { > + gdb_test_no_output "set print address on" > + set out [get_valueof "" main ""] > + gdb_test_no_output "set print address off" > + } > + regexp -- [subst_vars {^.* ($::hex) .*$}] $out ignore value > + gdb_test "print/x main" " = $value" > + gdb_test "print/d main" " = [expr {$value}]" > +} > + > clean_restart > > gdb_test "print \$pc" "No registers\\." > @@ -1267,3 +1279,4 @@ test_print_symbol > test_repeat_bytes > test_radices > test_repeat_bytes_limit > +test_function_print > diff --git a/gdb/testsuite/gdb.cp/printmethod.exp b/gdb/testsuite/gdb.cp/printmethod.exp > index fdc1c91bf23..0da08b1f7ee 100644 > --- a/gdb/testsuite/gdb.cp/printmethod.exp > +++ b/gdb/testsuite/gdb.cp/printmethod.exp > @@ -49,4 +49,13 @@ gdb_test "print theA->nonvirt" \ > "${::valnum_re} = {void \\(A \\* const\\)} $hex " \ > "print nonvirtual method." > > -gdb_exit > +proc test_formatted {exp} { > + set out [get_valueof "" $exp ""] > + regexp -- [subst_vars {^.* ($::hex) .*$}] $out ignore value > + gdb_test "print/x $exp" " = $value" > + gdb_test "print/d $exp" " = [expr {$value}]" > +} > + > +# Test for PR gdb/34685. > +test_formatted A::nonvirt > +test_formatted theA->virt > diff --git a/gdb/valprint.c b/gdb/valprint.c > index 83a442dcef5..211bdca04f1 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -1300,6 +1300,14 @@ value_print_scalar_formatted (struct value *val, > > gdb_assert (val != NULL); > > + /* Treat a function or a method as if it were a pointer. */ > + if (type->code () == TYPE_CODE_FUNC > + || type->code () == TYPE_CODE_METHOD) > + { > + val = value_addr (val); > + type = check_typedef (val->type ()); > + } > + > /* If we get here with a string format, try again without it. Go > all the way back to the language printers, which may call us > again. */ > > base-commit: 9decc44bc67d9fb4248c2afe4fde77174e8abf80