From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id K+RFAEScGmqr5SgAWB0awg (envelope-from ) for ; Sat, 30 May 2026 04:13:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DEBDD1E0A3; Sat, 30 May 2026 04:13:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F29C71E062 for ; Sat, 30 May 2026 04:13:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D06B4BA7985 for ; Sat, 30 May 2026 08:13:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D06B4BA7985 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 575944BA23E0 for ; Sat, 30 May 2026 08:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 575944BA23E0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 575944BA23E0 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780128807; cv=none; b=hb/UBh64XG5JTTPXQAhHB1ehpj7O7kJoCeH3o4fhaQJKTGY0ow/zHIR9OJWiwWu/QeD2yfrMfSrR6aTatNIaay1wj0G3wc3RQTeYCvBIFuTb/1GD/zkJx7rIr+Aok7Ije24r9+EmMUtAsAr1XSwPBACSrV59SJC5xQJWE/akmXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780128807; c=relaxed/simple; bh=1FJcairVIWFbqgYiR/rYOAg3k+NmjqtrHyicPGXwFvM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=CUJnoS3hvy55NZZWdsdlLMUsiBVgKRrR4OXJTlTgjlo/bXN8NbddbmUwE7pk6VoTi4SPL3sApua2ODtpAv1WGd0JpYY4lu3CmnUjK5AVOqq8yv928o/2moxx8FlgVf71DJfXSdn8X7O6D/7fBPTAP7TADJDkI36HZ4LJlOb5BsY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=K3YYlmip; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CSSs16pL DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 575944BA23E0 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 51122678C3; Sat, 30 May 2026 08:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780128806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnxELOhRxXmiQCG/3JKjUe+o/0wbtQSKLwsBUzavBtA=; b=K3YYlmipbk5R3XnxTELXcwgMd0sP2Mmg7NnodT+kFvk8UeZXs+gMBB+e4vOcSSFQWJ2rYV sPeYfD6p94eEOe6zYpkTLHMVnC3TkxeXijDuEIlpmZbiRGcC9jnw87ap9Bi6zutTpAWnBC R3jeQ49Bt4fJuaRWNf1aMClzr3MwrBI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780128806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnxELOhRxXmiQCG/3JKjUe+o/0wbtQSKLwsBUzavBtA=; b=CSSs16pLSyQrd/w2j7uLBe6l+ayA25LJf6MW2+FZ2Vbgi7tMUGjN9nyJ/wqR8f1QIVpVot N+Pa2S4HIUmq0VBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780128806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnxELOhRxXmiQCG/3JKjUe+o/0wbtQSKLwsBUzavBtA=; b=K3YYlmipbk5R3XnxTELXcwgMd0sP2Mmg7NnodT+kFvk8UeZXs+gMBB+e4vOcSSFQWJ2rYV sPeYfD6p94eEOe6zYpkTLHMVnC3TkxeXijDuEIlpmZbiRGcC9jnw87ap9Bi6zutTpAWnBC R3jeQ49Bt4fJuaRWNf1aMClzr3MwrBI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780128806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnxELOhRxXmiQCG/3JKjUe+o/0wbtQSKLwsBUzavBtA=; b=CSSs16pLSyQrd/w2j7uLBe6l+ayA25LJf6MW2+FZ2Vbgi7tMUGjN9nyJ/wqR8f1QIVpVot N+Pa2S4HIUmq0VBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 36A8B779A7; Sat, 30 May 2026 08:13:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id N/mICyacGmrpdwAAD6G6ig (envelope-from ); Sat, 30 May 2026 08:13:26 +0000 Message-ID: Date: Sat, 30 May 2026 10:13:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Convert dw2-const.exp to use the DWARF assembler To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260522155505.3363510-1-tromey@adacore.com> <1a2adcac-e470-43ae-8e32-58d6addb6775@suse.de> <87zf1i45zn.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87zf1i45zn.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/29/26 4:58 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Then I ran it with target board unix/-m32, and ran into: > Tom> ... > Tom> (gdb) print/x val8^M > Tom> $2 = 0x0^M > Tom> (gdb) FAIL: gdb.dwarf2/dw2-const.exp: print/x val8 > Tom> ... > > Yeah, me too. > > I wonder if there's some gas oddity here. The DWARF doesn't seem to be > notably weird or word-size-dependent. I see in the old .S: > >>> -#if 0 /* gas encodes it explicitly. */ >>> - .slab128 0xffffffff00000000 >>> -#endif >>> -#if 0 /* gas encoded it correctly - formed GDB FAILed. */ >>> - .sleb128 -4294967296 >>> -#endif >>> -#if 1 /* Rather encode sleb128 by hand. */ >>> - .byte 0x80, 0x80, 0x80, 0x80, 0x70 >>> -#endif > > So hmm. > > But maybe this is some kind of extension we would want to support in the > DWARF assembler. > > Anyway still looking into this. I found the reason for the discrepancy. Before the patch, with unix/m32, the adress size is 8: ... Compilation Unit @ offset 0x2df: Length: 0x6f (32-bit) Version: 2 Abbrev Offset: 0x1bb Pointer Size: 8 <0><2ea>: Abbrev Number: 1 (DW_TAG_compile_unit) <2eb> DW_AT_stmt_list : 0x200 <2ef> DW_AT_name : file1.txt <2f9> DW_AT_producer : GNU C 3.3.3 <305> DW_AT_language : 1 (ANSI C) ... After the patch, it's 4. In dwarf_expr_context::execute_stack_op, we do: ... case DW_OP_consts: op_ptr = safe_read_sleb128 (op_ptr, op_end, &offset); result = offset; result_val = value_from_ulongest (address_type, result); break; ... and if address_type has size 4, result_val is 0. Thanks, - Tom