From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91940 invoked by alias); 13 Mar 2017 18:51:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91916 invoked by uid 89); 13 Mar 2017 18:51:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=prep, Hx-languages-length:1716, contacted, his X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Mar 2017 18:51:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E43F2EB648 for ; Mon, 13 Mar 2017 18:51:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2DIpFCN012811; Mon, 13 Mar 2017 14:51:15 -0400 Subject: Re: [PATCH v6 00/11] c++/14441: Rvalue reference support To: Keith Seitz , gdb-patches@sourceware.org References: <1489176286-27973-1-git-send-email-keiths@redhat.com> From: Pedro Alves Message-ID: Date: Mon, 13 Mar 2017 18:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1489176286-27973-1-git-send-email-keiths@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00193.txt.bz2 On 03/10/2017 08:04 PM, Keith Seitz wrote: > This patch series was submitted in June, 2016, and the original author does > not have the time to see this through. Given that we would like this in the > 8.0 release, I have contacted the orginal author, who is allowing me to > champion his patch on his behalf. > > When this series was last reviewed, revisions were requested in patches 8 > and 11. I have highlighted in those patches what I have changed over the last > submitted patch version (v5). Thanks so much for this Keith. I'll point out a few nits to patch #11, but otherwise the series is OK. Before committing, please address a couple procedural issues. > +2017-MM-DD Keith Seitz > + > + PR gdb/14441 > + From Artemiy Volkov As explained in: https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs Since the patch is unchanged, this should be written as: 2017-MM-DD Artemiy Volkov PR gdb/14441 Likewise in the other patches, of course. Likewise, the git commit "Author" should be preserved when it makes sense. For the patches that are largely unchanged from Artemiy's original versions, we should make sure that our git history preserves his authorship. When changes were done to the patches to fix things, to apply modernization, etc., add your name as another author for the patch, like: YYYY-MM-DD Hacker 1 Hacker 2 For example, in patch #8, the ChangeLog entry for the manual should be "squashed", and then both names should appear as above, instead of keeping the "who did what" parts separated. Thanks, Pedro Alves