Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Simon Marchi <simark@simark.ca>,
	Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix gdb.base/endianity.exp with gcc-4.8
Date: Sat, 19 Dec 2020 16:41:46 +0100	[thread overview]
Message-ID: <bf9b4b29-3c23-561a-f1c8-248c0020a522@suse.de> (raw)
In-Reply-To: <848e1176-c774-f6c4-defb-1ee20a4918c6@polymtl.ca>

On 12/19/20 2:42 PM, Simon Marchi wrote:
>> +    set result [remote_exec host $obj]
> 
> I think this should be "remote_exec target"?
> 

Ah yes, thanks for spotting that.

> Can you remind me why you need to check for __GNUC__ support, and
> not simply for SSO support?
> 

Because of the usage of the macros __BYTE_ORDER__ and
__ORDER_LITTLE_ENDIAN__ , these are gnu c extensions (
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html ).

I'll commit with the remote_exec fixed.

Thanks,
- Tom

> Otherwise, that LGTM.
> 
> Simon
> 

      reply	other threads:[~2020-12-19 15:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 15:29 Tom de Vries
2020-12-13 13:56 ` Joel Brobecker
2020-12-13 16:23   ` Tom de Vries
2020-12-14 16:55     ` Simon Marchi
2020-12-19  8:48       ` Tom de Vries
2020-12-19 13:42         ` Simon Marchi via Gdb-patches
2020-12-19 15:41           ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf9b4b29-3c23-561a-f1c8-248c0020a522@suse.de \
    --to=tdevries@suse.de \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox