From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53491 invoked by alias); 11 Jan 2018 22:04:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53448 invoked by uid 89); 11 Jan 2018 22:04:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jan 2018 22:04:15 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 51.A7.14322.C5FD75A5; Thu, 11 Jan 2018 23:04:12 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 11 Jan 2018 23:04:12 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.62.3] (192.75.88.130) by DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.1; Thu, 11 Jan 2018 22:04:10 +0000 Subject: Re: [PATCH] gdb/testsuite: Don't attempt tests if they fail to compile To: Andrew Burgess , References: <20180111190055.4875-1-andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: Date: Thu, 11 Jan 2018 22:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180111190055.4875-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR08CA0065.namprd08.prod.outlook.com (2603:10b6:404:b9::27) To DBXPR07MB318.eurprd07.prod.outlook.com (2a01:111:e400:941d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ec53a44-fa3a-4613-686c-08d5593f3eaa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:DBXPR07MB318; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;3:gVWBYnKja7yvIvi65ISkjeFvIfVqxkItj2wSc0hp1fdHEdJXOQsu3UBho+y8+qQw4SOtxKhfOBvKFM+ZxDAKz6GeSB55ddtA9IbjT+k/+ieUa4wuZTTSEeZjIVaYIsAtbGN46WAibdRhUwQBxDnDDDXD2EeKtnl6bhErsrS9gdDH9O9UpJwUNOAuHji8vRx38g8XCkaSeLH8n/Ox2iumuKsDM5DSw0D23IykbBTBTiOReCk3o6MArp3PPuz8BxRk;25:GQhvQjPahrt3RLdWjyw2ZiLI7kSGAfPiYR7iv2o6At/pBNRN1957s8WMXtOkpu2pN+VdLgypRBO9rUzTMv56nFym/CrTUwf6MKJPHrdhD/cWhbkROGL+U8sgedAhg26SNWkv8pFwFboK6pmamdFC9g2lDpLtFvpA++vOVttYRT2HIDAng9YfLPV0LjcuxdhMMa0jpAhNp5EFHGtAmY4DVlo4wTPRLXBSV7A/rqMw13WUI4PPkQZPB8y3SEyIRem2qoGy00ERs3rPEGoj9kLVEqSwkn6OyZgHTt2KS2orfxQ9wDxRJdPRxYFeQI9OakxvGwTQEn0SVHrSJyI+bXvOGUaLIDuLYOM5Gfol4+D7tvA=;31:9q9hTjPYIrwEDRy6asgi90ou3ZKnNChWbWfbZIG4mYoBtp0EoG1kL9kQlKXMDcjFhYKgl6a5vGQctIO/D6V4r6w9cNAxYsuZ5itKvKwmhtuyqDFRmMXLDauoUwl41/Qhb6taRJk/QHKPECFHvLtHO2k8r/OFQlmsaVOFFzt5zvHsSj6e6q62NjOPGcOJHxpRqCg2PnWtfxW9LddsEtnykQc0sqUuZmHEAu8dI2kX8JQ= X-MS-TrafficTypeDiagnostic: DBXPR07MB318: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;20:HUPocvlTSCyV+v5cl+iOGCESObQ+zcw66728ztY8z0jMGwqL9wLlIUPO12EMIshnRBmffp/3Mx7nOugtejiom3MSm4o72syUqL1y+PqqUxThvekyK/7ZASiMoAN/95/9CW4KcabWBTjbsc4s/CHOwjQBDi75gRWrXVpJ6QVzrlMsOnvXfKW7THepWsM1bZd49IzN1A2Md7Zr6i6OhvDClDKZ3vo77XY8TIaWkAWCnRsCQFecSWqHhVTaKKKnT9W9ZNXCxw/eOV+P44+oRipkvek+ZVpb8tmE2RGKmr5pE2JOPu9SJP3JgPLdTd3k0kth1h3xWrdlDNc9fK+NpYTJ9HYaQyrdds7HdIA2CkmQo502AkHD/lHGKooYNdB9Zf85YAkrmhj5Q54PUewSLwxOv8PBaziqIQRKzA2b5/6cx/Afddw4QiYUMD8B9HMuE6OfWxq77kBVna8RJVREeNCqUy/HFaRuCBPBxAM43jjOwulnQ18M6nnvWz41RzKCuWoW;4:wc9/hy4gGhKbipI1f4Wy23wHhPbW0P8RKrVo0eStBbegCdGCTkei84+RtQdFzkrXCzKoEVFs+5cP6LiIuxG9L0r+PPupbdrc6J9zOV/R9D9gsg0dfvv/vAPiOjdrm7mxOY59WpuhtvX5vfA6PEnovfX12hifT6Tby8DbpqPr86khrxhcFxFDThFLyCIkVRXSxqPMHmzYQoQ63Q6apd40E32HnanwPTqKSRkYGgtHq5/DO7JFFG+chFJW7pnGjNAvWWk5For5YC4qFW3GIp4lXw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501075)(6041268)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DBXPR07MB318;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DBXPR07MB318; X-Forefront-PRVS: 0549E6FD50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(346002)(39860400002)(39380400002)(396003)(376002)(24454002)(199004)(377424004)(189003)(65826007)(23676004)(49976009)(81156014)(16576012)(230700001)(16526018)(6116002)(3846002)(47776003)(66066001)(2906002)(8676002)(65956001)(65806001)(52146003)(2486003)(229853002)(83506002)(52116002)(478600001)(59450400001)(386003)(316002)(25786009)(58126008)(97736004)(6486002)(76176011)(53546011)(6666003)(64126003)(53936002)(2950100002)(106356001)(105586002)(31696002)(86362001)(6246003)(31686004)(305945005)(36756003)(7736002)(5660300001)(50466002)(68736007)(81166006)(8936002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB318;H:[142.133.62.3];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTg7MjM6WlJERmpuL0t5N3JwWXRWYW8yWmlwNlhHWGNT?= =?utf-8?B?MHBGQ1NPTHlkSjVQazNROXVqR25SVlVZbGlVOTJsR1JtR2o0RjF2R1lWUVJV?= =?utf-8?B?eUZjUFg2Vm5sampLQkdIYjl2Rlc3d3M3NXZhNE9mV3BqOUZub0ZWMUVkUDkz?= =?utf-8?B?d25GTC9wYmU1R2pJWEJ6aUo4Sjcycmw2b2cvOW9ZeWVpc2hxQXMzVElIcTVp?= =?utf-8?B?bHJmTGpLT3JWMFhENWxZSW8yb3cxS3Jna1gxaFlCN29lNjlrQnhGd1ZldTdo?= =?utf-8?B?QXh0SzZJOUpXMTZwZ0JJMGh0dGJ3bU5WUElER0llaHVBWVYyRS9Xc1hzWXVv?= =?utf-8?B?eW40dzFMdXdybmdTYlBPOW9vRXNuYUNPSEwvU25uc0dvSWxDc0hHNVJjTThP?= =?utf-8?B?STFMS3MzdkFCTlpkaGhKalZQRmhKd2NIWHZPWjNBWXRzRDFobnNNMzJXUWNG?= =?utf-8?B?NGNlZkhiVDE2Sll5L1VnN3RsSEp0YjRnbnJ3Z2tXRzk0N0wyOVp0MlZRSXZn?= =?utf-8?B?bnlnT0xZVFhzZFJnd2xWVGpxR2lITTNKK0JFdVV1Yzdsa0YvS3pPMnJONjVq?= =?utf-8?B?cXBmRXBJdmlaTWRZZjd1cXd3d0tUcTNFU04weDFUcC8vT1NJcVQ5b0twcEp4?= =?utf-8?B?cTVwdHhOa0k5R0ZVTG9qcnJxYzhGRXFXeEs2cjd5TEpRS2NNRU1MbUlwTXNZ?= =?utf-8?B?NGhEY0t2ZlVxbzdWQU1Wd2R3T29wL3hvc2lqSUFPZWRWRlIyMzBNOXQwTFJB?= =?utf-8?B?a2ljQ3dNdjNvbm54TWZFVHhoN0E4cSs0OFl3Y1Q1Uis3QlZYakRMZXNUSHQw?= =?utf-8?B?ekxiZ2xsS3dQSTBONVR5T2p6ODIxWkNudTYxSkEyUHcyRlh3MzJMMmZRYUtk?= =?utf-8?B?WFhJRWhSL0F5YkpUK3R0WGEvZkpFSVd0WVhzbm90aVZ4RDVONUNvZlFHVkFV?= =?utf-8?B?MGNrL3B1cVRzR3J1Q2h0QXN5N1FzSTBSMSthWVYvd1NVaVc2dm9BK0hkZEJk?= =?utf-8?B?eUtCQTdkTkg1TjEza205b1FFU0Q5TjJHekErUnlxVTNOZ0pHY1p2SVBpMmll?= =?utf-8?B?OHR1bjgwZHRUSk5DTDRjQVF1Z1RaeHRnOTdCWVVvNG5ZOXoyU1d0MjBJRWlG?= =?utf-8?B?dURJblBWMjNnODZma1JPdU45MFFkeWl0QjRleG5RSWo5OFk1N0ZIMHh2Wi9R?= =?utf-8?B?QWlRVUZSSHF6YzQ4Q0tQa2tXdW91RmY1c2JjR1lsSmw5cm95Umw1UDlOQUxi?= =?utf-8?B?UVNjcTNQSnRhT1VTWStHUjI3NWh3N0o2MTZFUng5bmhGV1dsOTIvcVZWT2I1?= =?utf-8?B?aS9RdUhxN3JDdmVTTEE4TnFVQnhWRG5kRFZlM3VkdkMyVHFhQjYySTRuU214?= =?utf-8?B?U1cveFBvaCt2anFRd0RFOHNIV1FaNVQyNUhTK09ld09zVVpXZGl2QXY1dzRs?= =?utf-8?B?aGdObGNkMkN1ZExqMFBHVzNKY0FZRmRLUEtDNC9ub2pCY0tBd1d4bkhsNnYy?= =?utf-8?B?TGFWcmphSjM3NStxb1Q5eXhXQ1pLVEFpV0dSWHZrZncvY2ZLUmpzS2RUTHo2?= =?utf-8?B?UXV4cDVQcVZHRWJaN1JCdUh4ZEllYitiQ1lBQkxkVlNIeXY1cS84WFp0ZnVE?= =?utf-8?B?bE8vWEI5dnI3b3JNMWk2ZC9uU1FVZXViUnlVNHJkZmlrV2l5bXU4RVM2N3Bj?= =?utf-8?B?NHk2US9BVWhHOXFjNXQwMTB6S2t2OG85VmdkVmdHZ2NLRVVvb3ptV0NBYTVo?= =?utf-8?B?QUk4VDhCVGtFdTdoNFRHVk0wQVZjTGlJdzZsbi8xNnRVbHVzcnpCcVdoZXhx?= =?utf-8?B?SHprbVZrNnB3a1pqOFUyeStDTUxvZjVPMFZ4aXhQMDZVZTkrdmhCVjV3RFNL?= =?utf-8?Q?6i9RV00Xl4=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB318;6:1nfvdRCDCzRTy16ZAbX+XH/eYTAm/TuFhCOCG7Vlrpeo8RIbOJaqF57d8R3OT2anrg9hgre/tkg8nK41OrywkvLEWq1ii66r5pIZgEqinrNkJO0lT+aH2dk4wsoSRa9KpTSxmWfWoHiiueNJ7ThuvjSNGGHsuwO5P8wm4Wv2bgOoCIcFnNmTGQNMG9btTVMT/JmeXDQDIC2GQtCYjnBp5RNZDmUGrJrjiO/JBCzT0vr78nwcBEJAiqL0umyJxUhE2GBYlpsCzCNv7e4bfXtMgso+06B/pJBJmTzjS8ANoeutFC8o81kwoe/DhZkWPmt3Iro5M2vTRhXatQvYa1kW0bc9BYu1O3gAThV6AvQPwWk=;5:pR2ArIww2UYe7jtMhPkiBVqRqCOArSK0wbh32+THHgq5eTbdMPI0tEbzRToSVsF+8xsZsXRzXvr8fvQnxyc6AgSNz8bLUVu++iB1fVl7RYc2zHHWjU0w9qrgH1CpVRyrKWDNYPzXiAY5eHFG1d76Dd0RC3Ng7Hbyh/Hj9UdahmI=;24:NMNQrgrdLWpwMtzgAeFMaYFDOfczDoYbZ0DOAaIZmCDDB7WXeXeuiAN9fepOqgXBCzM6hOEVc2ojNB8syGCZ7do3Ca09Jtcu2k8h1C24e0U=;7:GdCdQO+/qSRas0uUSTdkMwmhrIDVKWZOV2yZf6lcqQqOl67Ks2C0ffrPENM3A1fH4s3FFJjsaWs5r3MRnRyIVHhgFj/I3A9DTozSSaEaouBJj4klIEHVhEPTaRrfRHito1t92uxjnhdpkmmrfNjd0WlHwIW4Dd/N8bTdgoZFJmHBK1ya3vR4J1EdjYAI5odH3j6K8RtXoCj51Lkb9YplgTLn4sevJ8nras3nPbg9BgijLSVR8B7pX/F2wA6KweVG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2018 22:04:10.7272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec53a44-fa3a-4613-686c-08d5593f3eaa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB318 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00220.txt.bz2 On 2018-01-11 02:00 PM, Andrew Burgess wrote: > In the gdb.base/whatis-ptype-typedefs.exp test, if the test program > fails to compile, don't run the tests. Hi Andrew, That would make the test similar to other test, in that if we fail to build the test program it's not a failure (it shows as UNTESTED, doesn't make the test run fail). I find it's a strange behavior though. If a test program starts not building for some reason, I'd certainly like to know (e.g. it could be UNRESOLVED), instead of it silently failing. Any other opinion? Simon