From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48891 invoked by alias); 2 Nov 2017 13:22:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48853 invoked by uid 89); 2 Nov 2017 13:22:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 13:22:41 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id C1.25.09869.E1C1BF95; Thu, 2 Nov 2017 14:22:38 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 2 Nov 2017 14:22:35 +0100 Received: from [142.133.48.133] (192.75.88.130) by AM3PR07MB306.eurprd07.prod.outlook.com (2a01:111:e400:881b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Thu, 2 Nov 2017 13:22:33 +0000 Subject: Re: [PATCH 05/10] Make tdesc_feature::registers an std::vector To: Yao Qi CC: References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-6-git-send-email-simon.marchi@ericsson.com> <864lqdxbzg.fsf@gmail.com> From: Simon Marchi Message-ID: Date: Thu, 02 Nov 2017 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <864lqdxbzg.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY4PR18CA0053.namprd18.prod.outlook.com (2603:10b6:903:13f::15) To AM3PR07MB306.eurprd07.prod.outlook.com (2a01:111:e400:881b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c693ad0-9146-4e61-fbda-08d521f4c7ab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603238);SRVR:AM3PR07MB306; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB306;3:FldwOjavLaLa9fba+idcFhX7fsWZ9P1A8TSnkJpv9B0PxU3GhOv0ezLMbTHNAUMm7n9Dmo2QjhLn5QbpVZpdvnZAgkBJqIvYKONwICvXDZzITgLaf1uj1bDdq0Y5AE3CBjSavXJKqVnPig9plcy1BS74GOVigGrMEyH3YI68V+KCOUe3EB9QMRiiaP46tV8Z4HTc3txZ0dhh99aL4f7TKeVTqoUf3+bS+HfbVF14lSy30tl5OQSkG8o6vZISUKjM;25:8eu8UUszvS7C5QDSItV3c6gkZZLxDY31mJdYctTDhYXwV2T3T1dZKvFBbzO1fhIoyVkSAuenTf/4NRxTNIEEk0YN78bdK6KUAWXZSXC1uea9g62g7ViMC+Gmia8PMDYeL4zEq1fHmjhhc37ovB44cf9vGtJqLlVdSil9jnll3jns5VBiw+sEa02sNaQuoE2dflUtvByXbQtmtHB2PtAia/MvIhqVFuvAvv2Zte0+zTcLiAU4PbDk23GnIit7C/4pIDVxzS1TPd4T6YgEzM13fTh1gXGk1w6nfZGY7AqCowp2sGdHPbHhxfwJdPtO76M5qlNx7rfulvNa7M3zeriYnw==;31:UnFYvSjgUSoGFUUICV6anc35RaqIVJJWPYZoFTos+/4dh2pqV3OVWx2g/ZCoQWgqilL/zPSvqhBiGIIMR+xRCZfAhfiEZvn4UjTXg/eVIx+8S3WcbddgzrC/kr3dbT85+brisgqnsuZ95RogC4F1+5FmbFTEMY9aSiysodtTj89LAUwu6YAciwzpY413xpgi9RhfcEQSbLDq+GYb+/OTHhODFvIpdL3VswNbNBc9pOE= X-MS-TrafficTypeDiagnostic: AM3PR07MB306: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB306;20:QuPeLDspj3jyK9xFPm1xhkNYbfCNCRoiUfRBF0NxqpbyQr61kbyN2o7rDi736zkVlnumSdqN5c0W2jwSIzZGYhg97YAlFz7+VhsVGq2X34680VZxQxBxPIBY4fWIZEINu9eM9N3eBMkY3HvgjAmT2jaREVHrudDJu8GwVaRAP06STiRaVCNKGPjO5qZ0vnFL0ONlneRRtlc7mzm/zIubhJXRoPL+vunFOhNBygHMBsNim4OuXx02M0pFDRi+zhTUqrOz9ewj5EIFpP4/zIotpe35F7quST74CALugscie/ncUJdnxS3Ptd0f779JPg9T9bXk0lEtQOdpIbB6G4BweNxlHVZkzbYRQxOtG41FK3mVDgg6AgUi8OGsEZBQqRcJKKwBQEIJYbJ6egDq3lTLpiBwEsSifMz2X7XxZsThj0xBs3gVTdeHHLf3Wi2/yjMOc09msarWJ3Xm9LInyt5aLB1x5UEtQNlhDLiWtuDWruRTYMzZvUdHrHr429IdeFKZ;4:xik181lJvCFR3+xHw4E/l+/RHf1w/RHvxufUR998URKAkhK9FxhfByZRYMDeBn53X7YD33yX4cS8uUwFw8CnY7sYlTuWqEo3kBGCkiEeXlryFL2suvEvEgP57s6eQVCMF2iDHt1LWiKngIKGKptoj/kbr1mUJP+nHzpgujltYj6eUN01Oo8Yjy8TuBjOn7pFJC5+LIA8m4RWia97WQKG1DHnBA7mc6axhzc2TkvYe5vsSDRa/JAODo6CsW24qtx3R4R0yM/WlSfX0dFIW1bsKvMm2oEgDGCWFNIEZsnSfJdJGU6J7sPKnInUMoeqxudC X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(3231020)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR07MB306;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR07MB306; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(24454002)(199003)(189002)(377424004)(4326008)(2906002)(7736002)(68736007)(86362001)(97736004)(101416001)(316002)(16576012)(16526018)(189998001)(39060400002)(23676003)(305945005)(47776003)(83506002)(58126008)(8936002)(230700001)(6246003)(1411001)(31696002)(65956001)(3846002)(105586002)(106356001)(65806001)(31686004)(33646002)(64126003)(50466002)(36756003)(25786009)(6116002)(65826007)(76176999)(8676002)(81156014)(478600001)(81166006)(49976008)(66066001)(53936002)(50986999)(229853002)(54356999)(53546010)(5660300001)(6666003)(6916009)(2950100002)(6486002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB306;H:[142.133.48.133];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA3TUIzMDY7MjM6T1M0TUlaNlM2aTE4Rm10K0dianZ1NjZHaEQy?= =?utf-8?B?WUk3WFFvNXpnVTdaWis5bnk0VFNqM05MNHFWNnJYYktDWnFIUTlBaFdLMEZy?= =?utf-8?B?LzZuZ0FuQ3FmMkdLSnFxMTZpNyt6U1hMaU1ncDNGQ0hHV0gzZGk2OE5rMHdi?= =?utf-8?B?b3FtajlWeEZsam41NmdIaUpaV1dWeGpmMmhCcXhzblZ0NitmK2dVcXRDeEJs?= =?utf-8?B?dkZMNVRxSC8vVGVtWVk3UFBuY3JmZ1hudXhjRXR4aGE5Wmsra3Npc2FvUSty?= =?utf-8?B?Yk1HQTdaUzJEZEo0blB0VmxYYkdkcTUxcXhnaVY5Y3dkNE5UZGZET05vU1Vu?= =?utf-8?B?RUxkMHREN0JtTldnamUwMTVtbjh2dGZJSGZxUmZpTXR1YmVhdlBGV1RtaW9O?= =?utf-8?B?R1ZibDZWQkZMamtmRFlkOXdDOGVmWFRaSjltbW9kUEZzSWxlWUU5SnlGcm12?= =?utf-8?B?bUhXRW41OHpTSk5jaEYxbUc5ZUNldmg3OXlWVFo4ZzdTT2lHQis3RHZvUERI?= =?utf-8?B?N2lGK1FvcDFKdXZqMWRTOTBWV09mWlRXNndGckZqMlZZQ1dKeFV5ckFUbWg1?= =?utf-8?B?MmJvV05BRTVYcEcwcnpJOEtHYm8yV1J0eCtDV2w2cXVFSFZtODkrdHJmQTU1?= =?utf-8?B?QWl5S3FxY056OG9NVWVrWWI4YUU5VUJiZmZ6bW9zMlNmOHZzRlo3eWVqY0JU?= =?utf-8?B?T3F3WHNKTEFzT2NHQnJ0MTdmdjdFU2F1S2I5SGVJY3MzNDhza0FKNCtxYm0v?= =?utf-8?B?QmJMWWY3Vi9XNDduMnlxMHd6bWdxRWJocStBbHNNUjdSR25HblRaVVYwQW0w?= =?utf-8?B?Vit3NVdQZE5zV1hpc3lqYTEvY2tUbUpxUjI0SGt4SEQrcDEzcjBheWpFNnRI?= =?utf-8?B?aFF2M3VBejFGY0o1VnlEY1Y1M3M4TTBOOUs0b2Rpek9BN3FTUWdmcVZseHp3?= =?utf-8?B?NkVSSHBtaHhhUjRwUFEweURaVDBnZlVzUnJHRHRJS2VHOHoyVkVsTG9xbmhw?= =?utf-8?B?VlBqREkrenZwNFRicWtCVTJEN05ONG5WRE5jd1pCOEppb1k4bnNHZGJ4OHBz?= =?utf-8?B?cEVkMkdBZ0FJVjlTRkg5SnQybHAyVjRLOU5ibVRuS3NSeVRiQ0VhS0JEdndm?= =?utf-8?B?SUdDd2Q1Y2IzWkRrQ1A2U21MMDB6Y1ljT1RaVUpXemhLNFlLWHVCczhIUjNC?= =?utf-8?B?cjhUYUxpUitnU21SNFQxcEdPTUhYc2cwcTFLV0xmRmVZZWdLY0VNSm1MUTN6?= =?utf-8?B?MUFYdkxUYmwzQlg3OENuS29MakxxemVzamxOQWFqYWpDanhIZHVzU1NjODVm?= =?utf-8?B?aTdqM3BWb25BMG9yaEYvbnBjV1oxRGF1bXdUbjJBR0RucTdXMnhZeWpaWG5I?= =?utf-8?B?TlNBd0xmSERiNGZHN1JlNnNqZEo0NmRROXQwVGlGaVRzeTZtNlliZm9HOXdX?= =?utf-8?B?OURGeG0zNGFJU1R4SlFCTWJlWU1haEdoN2tHY2NMTXZ0dHd2cUx2N1gxQk1x?= =?utf-8?B?emM3M2ZDNk84SzhGK01INTZuL0NLYnZFYlJWVkVMa3YrMUFLRGt5ZUd6ZEtl?= =?utf-8?B?MnRVOVpXUmQxSkZLdGRSYmg4U2ZpNTZndUdSanVYenVOUVRNVjVTL3BuRnBj?= =?utf-8?B?V1gzcWlaM09DQ1J6V2FETGJQNWhwSkRlZW51SGdiUmJMbnFEUTZ5SnZKMXBH?= =?utf-8?B?d3o2andpcWp1MjhxanptY1AxVjFYL2ZBV0pRQ29iUkVVM1ZpWldNOTRVUjNE?= =?utf-8?B?SFpnZnErcHB5bEdOejR5c2JsVThaQjUyUFNBbEJxUGRnWGFPVVdCZGFSN0dE?= =?utf-8?B?V0F0RUJ1TTkxckRneHRvVG9SQ1h6WnZOY213ZW1wNC9UaDI5MlBxdVNaS3Vy?= =?utf-8?Q?+pt5MYdErzhMPFvGqAUiXWhawO8UBc7?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB306;6:H2DDwNOg25la4MU9NrWqCJrjVcudDuby0QulWoglFAVuGzJX8OYfHcvomqWR0ORh1qNf2fUiWjzXzzKsMtk48fwOK7Dw6mjx6s2TS+bJGx3qAmg/ulnTY6xlLeVdNTSXNGjjEaR5WeTMmhSgn6DGEJBAbZLW4ViWEe4MneMuCVQ3kkk2xCeNmEdhOv8TFWVGIF0L6Ty640cOwisZz0aPEY7fpiyaR/hgKVacKvINIgfdH5mXUgKX+p4B8NXmCa0d0DksshEd0z3dXxegwmS5WqSlEzM2KSzknWcCb1RDbXesBtfF6B38i+HKhoHz17qXbqwySxHbyUxuKcvYdeps9T5x0yXCnvwzq55sDnP+3bk=;5:151D4WchLufo29JfC/Iz1f5pG+Ruc4IHrL+8Z4WrJGzM+R1mF8LjquSdiaGxoIOHPKaH2wKzI/Vhk/E2ybnVvFo9iFLwH4U76gzn9e0Lvr2C/hgrTMOQRHy58g5F9gqXjFXD9BUFOzgEq+oZq7iMZXOaf94uHzI2gbL2DkST2vA=;24:XiMUpuDlm/2dg3ivn+iRK3RAd0LJkXhmfwdTj6LxxpGdAxj+sueuE0YXwhHxvqTlLzt09MgnnZyzUa0FMlaVEdp0R5zO8MbfiexEyFmka1E=;7:tYiJOLQyUQPad0Y3JOAjnd7xVaQTLPgn2wGOoDOJEQ0wIbk+87hDGbiNEqjNnlKtoxtr+kzo1KzdD9BViMhkzX1cObsqNEJzUvYmU3iILV0/zTCP/KgcU7tz32ZUjThqSD4mRCcJQ0YWaovOVG4Q6Ghlj7gg4yZU+gjR6opyTA/tQi+S94WD2HuOcWIhluCMLQFNH+1Ss4njFmX2/2iBf6+4LjhyN6PRrLf+obUiXC0Zp3IQarccTGWXmVa/GPgj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 13:22:33.8467 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c693ad0-9146-4e61-fbda-08d521f4c7ab X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB306 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00027.txt.bz2 On 2017-11-02 05:32 AM, Yao Qi wrote: > Simon Marchi writes: > >> /* The registers associated with this feature. */ >> - VEC(tdesc_reg_p) *registers = NULL; >> + std::vector> registers; > > Use tdesc_reg_up. > > Patch is good to me. Thanks, fixed. Simon