On 9/23/21 4:32 PM, Simon Marchi wrote:
> 
> 
> On 2021-09-21 4:01 a.m., Tom de Vries via Gdb-patches wrote:
>> Hi,
>>
>> When interpreting the testsuite results, it's often relevant what kind of
>> machine the testsuite ran on.  On a local machine one can just do
>> /proc/cpuinfo, but in case of running tests using a remote system
>> that distributes test runs to other remote systems that are not directly
>> accessible, that's not possible.
>>
>> Fix this by dumping /proc/cpuinfo into the gdb.log.
>>
>> We could do this at the start of each test run, by putting it into unix.exp
>> or some such.  However, this might be too verbose, so we choose to put it into
>> its own test-case, such that it get triggered in a full testrun, but not when
>> running one or a subset of tests.
>>
>> We put the test-case into the gdb.testsuite directory, which is currently the
>> only place in the testsuite where we do not test gdb.   Though perhaps this
>> should be put into a new gdb.info directory, since the test-case doesn't
>> actually test the testsuite.
> 
> I think in the gdb.testsuite directory is fine.
> 

Ack (still leaving the comment in the log message though).

> I like the idea.  I even think it would be useful to dump more things
> about the system, like:
> 
>  - "--version" output of compilers used for testing
>  - "lsb_release -a" output (if lsb_release is available)
>  - "uname -a" output (if uname is available)

I've added the latter two (and renamed the test-case to
dump-system-info.exp).

I'm not sure about compiler version, ISTM we already have that
information in the log (though you may have to grep for it).

> Can you think of more?
> 

Atm not, no.  I guess we can add if and when we think of something else.
 At least this gives us a place to add it to.

I'll commit tomorrow unless there are further comments.

Thanks,
- Tom

> Simon
>