From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27080 invoked by alias); 10 May 2017 13:59:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26303 invoked by uid 89); 10 May 2017 13:59:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=worries X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 13:59:29 +0000 Received: by simark.ca (Postfix, from userid 33) id 774B71E561; Wed, 10 May 2017 09:59:30 -0400 (EDT) To: "Wiederhake, Tim" Subject: Re: [PATCH v3 09/12] btrace: Remove struct btrace_thread_info::flow. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 May 2017 13:59:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, "Metzger, Markus T" In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF3C14CFD8@irsmsx105.ger.corp.intel.com> References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-10-git-send-email-tim.wiederhake@intel.com> <1b056a5b6923e4357b0795d513b1d8cc@polymtl.ca> <9676A094AF46E14E8265E7A3F4CCE9AF3C14CFD8@irsmsx105.ger.corp.intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00276.txt.bz2 On 2017-05-10 07:46, Wiederhake, Tim wrote: >> The patch LGTM, but I have one question. Did you consider adding a >> backlink in btrace_function to its btrace_thread_info owner? It would >> possible to implement gap->next () and gap->prev (), which could be >> used >> in many places, and would probably be more readable than >> >> ftrace_find_call_by_number (btinfo, gap->number - 1) >> ftrace_find_call_by_number (btinfo, gap->number + 1) >> >> And it could possibly bring more simplifications, I didn't look in >> details. > > I believe, a C++-ificiation patch series could get rid of > call_iterator and insn_iterator altogether. Sorry if I sound like a > broken record :). No worries, I see no problem in addressing that in a later series. Simon