From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zk48IeM7RWVk7j0AWB0awg (envelope-from ) for ; Fri, 03 Nov 2023 14:28:51 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Fs6xWKFY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7FFD91E1A7; Fri, 3 Nov 2023 14:28:51 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6F8631E0D2 for ; Fri, 3 Nov 2023 14:28:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 134923858CD1 for ; Fri, 3 Nov 2023 18:28:49 +0000 (GMT) Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2051.outbound.protection.outlook.com [40.107.116.51]) by sourceware.org (Postfix) with ESMTPS id 7AE9B3858D28 for ; Fri, 3 Nov 2023 18:28:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AE9B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AE9B3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.51 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699036118; cv=pass; b=f/P6vphUPhITA7NR85j0r7ogWw46Asm1eN57sAYQUblYOWTZnraSmuaRY5TtNS+pHRAPpRghZa4wQE8l4LH05XyAMZ0eRiFZplVM5MG1G7oezsHi8mIND2HsZdQEX6h6T2JYIQrv7Z12kC47vpmNEsYQecxwfs5vJK7qj+4gVYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699036118; c=relaxed/simple; bh=DV3sJjinSgGuPOHvZR2yMxR7Ew9B2zA4hOzVcbc3ZWk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=n4el9aR5boKfeX94B98ic9GEUAMKcHPNqIDzby9S9MQCNo5kpkSyicLcYpSu7b49cCY5jnNQREKuT7J+sVpJbgr9x0p46Yz+1T9oxIcxhooZVpmFTRJ0GsJieglHqN9EieK+P1/e0X/Eizl7pzOiO996im7wVkw52DJPaCpioss= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCa0/Vcf/1X3klUAJ1QO0f1P1SoO6JadIipyvqAkjfGnksTuvHVwDR3CyjC/Jk3mzGaOYVwvsQFSkutrRJmevaGUM0W5cOorp2/Feg8LB1liyU2P/qlgDfN635l1MqOlgDe2BkmumW4M+oATilFNaTixBCzLPygH64jKNKQ7mCCq1dpMsJa+cjRm+ahDigE7JBhbdvJaK5L2UIc0qAh7gu8riT2RwtEcXrHm/i1mzkelE/5tyHiJUmEqOBtEUHaQaA85Nk5o7rNYhziRLw8kgp0Vy3AYwTSpmeAEwm5lltESxkbXyFgc+3RbGUOf7y6jH81N+wosnGldZVvQ0wYPFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0CWDTKXbXnN+Ib5FQcGHdwj7xEk+bETxkdP5fjbmWV0=; b=UTuaYzyLhmEln5bJBBFl39xG6OJRnyyavlNHl0P438YSzruzXHiY2/AMi4acQLG/TNLmQVVTHFMk99s4yl6VMZivFSzcGQfqYt7yt6hZxL4Utbu1dMPLrN/hGRwIobbmdTzEuGdMwP1CVOfDsYz2DnXVaB+3ImoYZkxE8+G1p+U6j5wCEnrGEzHRFo9ezT7ALqfjFCPfKDf8aCyvfV1snsWacoKXDD+rgSvMLZynS1nzlcBRZkdjy4EIRo79PkNa5NiZfOEg+dbK18tdjzYSkkO+vBnrLBeL7kbkwyTfl6WZxitZRCuA4H6x8T4Seih2MJmZyWAI+y+EH4TLeSsiyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0CWDTKXbXnN+Ib5FQcGHdwj7xEk+bETxkdP5fjbmWV0=; b=Fs6xWKFY22IalMT4rhDiHQOFOj/+jrhM02u1q+vdrdTd8mQUE56FG+/DcS3/Fs05LPzp79YkicgT2B+8gqMWzuvUj/7299uU35oumjkz3g9dmuRbQ94HBnwVDK/lIFY8NnTkfRaEgWqLrzxAP8wbl6Uy5wqvSdqmLi/GRgoMz9q1QNqfXXms72C5bMzFGjLolfMhfQMcHsErNoiU8Wll7PvMNd4bdyBby5cCMoKqrV4nGiTXz/rx31SQ9xdEYoG6nOnvCy2XZZR2HKKbk1Xz3z1xRejsr4jQnXFbVjoHdxCvRAP29YBqhEnGeJnhdGW+dttXg1tGWIgZpFbbYBygnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT2PR01MB8293.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 18:28:26 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::1db5:8518:3589:61aa]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::1db5:8518:3589:61aa%4]) with mapi id 15.20.6954.021; Fri, 3 Nov 2023 18:28:26 +0000 Message-ID: Date: Fri, 3 Nov 2023 14:28:25 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport: mark array_view::slice with [[nodiscard]] Content-Language: fr To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20231103031917.927026-1-simon.marchi@polymtl.ca> <87y1feiu3n.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87y1feiu3n.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0073.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:3::9) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT2PR01MB8293:EE_ X-MS-Office365-Filtering-Correlation-Id: a284ab3b-b7fd-463a-f146-08dbdc9aab81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pq4BtEdg0hF2EdYBr8OpVIhAPyhFbX16rrL9JMvAUybfJHn+EQhXIBP8H9Rlzi56rkdq83y2LYmoxZp7RHEQC7Tj1XRxKm7c27lLVEvSzaZDKNDnPmhedtP60ilIAHyMaEtvz7j7JYKby/T5LBCrUdpnn4JABJ3+xFD2H2xXFuAcKeHIS5BY++1wnRuyai4VZMD4FgoMW3LN87bCYOJ2/UEukLGhB/qDpw1y1INVVEJizjjygcr7gv0J1pIWcu671Izj/kVXO67QUxIy+emwevazc5yJlTWB6r1Y53ICIXVdCF8rHRdBroY8aMKAjhFT2t7AL1GLMHHcvJZMm3O/51yXm500eSwSSeoEu72gG6WWIr3MDS0grRQtKGQTFKDgLO08mSVoTft2rfX0QSkazJYYE8oTKLxk61xodL91f4X2NJOJDkARNg/pvlZJ/VSXq0X6aXgeb/vdw1QIL3Sqew++fwV84Ga9IFxjHgTt4oI++K4F2xUaZojrCRxiJahdXRWUBnOtU3aYVHRyiDgAiutV6JTTmQ609XVDLyWXjY/ZDrF0kYJ/HTzjdSJO5Kz6wNb8PB50zKd+KJZgltEzWC0NGL6sumFvSDsM19xnwwU/kS1Py06QqiGNo1/Dh4XTTvAIY25cWf8RQ2D8UtQGZKFfDPqdVswmCtFXtlqQn4uysjx+PtNRkZe4h2Z+ZLEA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(346002)(396003)(366004)(39830400003)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(64100799003)(1800799009)(110136005)(66946007)(66556008)(66476007)(6512007)(31696002)(6506007)(53546011)(2906002)(6486002)(478600001)(36756003)(4744005)(38100700002)(41300700001)(83380400001)(26005)(2616005)(5660300002)(8936002)(44832011)(316002)(31686004)(8676002)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3EzNEo2Ui8zdTRRaE9qZzVuNHlMZVQyLzNMdzBNK3NzeW1BSkJaWERodGZD?= =?utf-8?B?N3RHRStLOGE5WnIybnNuRnFNT2dzKzNaSjE1eDRxNDBBZVlBVWdTUGNHeGRq?= =?utf-8?B?LzJnS2NVcjA2bjBCMjBqMi9EYXhVbWRnMkN4NEU3ZGVxR1FSWDNRcUNSdHl4?= =?utf-8?B?SElYK2lvWS9ZcDljZXNsdHBCSHh6cnpDYVJzTmd0VjF1SW4zSEYxajllN0NF?= =?utf-8?B?eWx3QXJVUnVmVDNHc1Y0TktReUV6MXFaS2VGT2dlTGdVUkwyekFjb0J3Zytw?= =?utf-8?B?TGUwVDRndzZXakt6SlFrUkNET3ViWWlaSnM4SHdiZWtoei9LcnlEUEVWc0p6?= =?utf-8?B?d1pTSjNLckxvbmM4blh1UmJRKzFiYzNta0VkQUlScEd2QXlMd001VkdsY2lY?= =?utf-8?B?VmV3Umd5dGJDd3podnJlUytQb3NpQjlJUkJiQ3FrendKS0t1YVYrbDIxREVx?= =?utf-8?B?UnJtN0xoNXFTSzcvZ3RSYWg3c3VsRjdWeSsyejRySlZUV3RGbnZkOEZIMzVD?= =?utf-8?B?ZW9RdnZqRE1jTkNkMzgxdHhwOWRjZ0ZKUmUxakk1b01FSWcxTnd4b0pMU2pU?= =?utf-8?B?Yi9VL0ZTanlvb1hodm9rTnJkRDd2U3IvbnNiU016RFh1Q0IxNEpsc1JwbTBQ?= =?utf-8?B?azdSZ2cyalFzMWVYaHdsUEdoQjNheGRrNHY3Q2ZBMWphWFdmWXRqL2Z4RFVW?= =?utf-8?B?dkd6NjJQMUNTYWVyWEI3SUdicWdrL2hkYm5Sc2ZFS1ZTZnd6blpTYmVMVHZy?= =?utf-8?B?Yzd4UEdIOHNucHZlZ0hoKzVjanBuQXFNVDRDcmNCUURlT1hZMHVvWGd0WGR6?= =?utf-8?B?UEl0RExGZHlkcjhwQlB1NmdORzRnZVlyZXlha1VTZnkwRkFwNDdkc3RmMytq?= =?utf-8?B?QXVpVGhJTEt0MGp0T3ZzUjZSbUhQM3pVcDdtaGdTOU5aQWFYM1Qrb2MrbGU4?= =?utf-8?B?YTliTWFKTWZZNk55VmNES3RGM2JObE14WHJmM0JKR0k5MjdHR0xFb2Ixb2x2?= =?utf-8?B?WTFaVTVOdlpWa3ZJd2h0NGpGTEJnMDZtUy9FbTVGNndsNXIyK0lvM3FPUXhY?= =?utf-8?B?ZU96RGFyWXd1NEJNSzFraTNGTlpNSk1Sem1wemtWaS9rV2VYNkswTytWR3kr?= =?utf-8?B?cGxKYlVCdng5MVpQWHArY01MNlFaZmdlcmI1SFM3NWpEWG1oVXByQVhWRjA3?= =?utf-8?B?TWp5eGdxT2lLakswczArUlV2N1Vna3pZc080ZnpweUc2KzhVVFZvUlRyV1hn?= =?utf-8?B?RERldVhUQ25USTZDeUZjRGxyb012NllIZGtXWUUySXJESmtYTm1naTlzR0kr?= =?utf-8?B?dkpubEs2MFo0MmFqUFQxTUxycDAyRzMyU0M1cFMvNkczcEo4T29rZTZ1b0Vz?= =?utf-8?B?S1pzbTNIMzdneDFXOUVvMHN3bkZqOHpBT2k1V3dDN0JSTGpJTS9aQ2RsbXpx?= =?utf-8?B?eFhQaUdISFBFUkVBaStneDdkd2pFSHd6TjYreG50M0YvTWNIaVVQc3RRWS8z?= =?utf-8?B?dEJjWlp4WFNCMXdXN3M5WFMrN2xmS3NScWZHYS8yanMzVmNvc042ZzhPUndO?= =?utf-8?B?Q3FJWUVWNFNoM21pV0dKRkF2ZldHWWJkOUlGeDhuc2R3OHJ3MTN6WGkrMi92?= =?utf-8?B?aHRaNUIwN1JCcXJyWHNCcVUzOVU1a21pS1RUMVFmWDg4YkNnNWpFTVhHejIx?= =?utf-8?B?bDJ5cnVRaEZRejhWNVZNSFYybFlRRENMWGxOTFAyRFBoSDFsTTJvSFBBdEtR?= =?utf-8?B?ME04RFJCcnAxcGJGS2xJVHVzOVM0R21WSHI0RE1ZdHRwN2ZRaW9hKzFoM0Y0?= =?utf-8?B?MkVqb1M5V2krNDlrUzN6K1FyT01WSnVlRmI5THg1V0M4VzFxUTdEeW5qRm5x?= =?utf-8?B?QkpCRVAxOGt1MEx5dHN2Tk4vUXNncG9SODRJTStzVmlocUhSazU2NU9HV3ZV?= =?utf-8?B?UXRFWlR0Q2g2Y202WFZVVXpDR242T2owWnQzOFpHMkNBOC9DQWpleWo4ZXYz?= =?utf-8?B?MXBMQjNMRnp6N01jcUw5TGV1YlJ4QjRWMmpDRGxYNHlaVUQ0dHdsMVZoait5?= =?utf-8?B?cnRQNjVvL1VTaGw5dUNxbWN0dTBYRFM0eGtabzd1R1NBUmlaK0xyMVFkRTBM?= =?utf-8?Q?wWkpOjJJNY4Ggde1eYobBe7VW?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: a284ab3b-b7fd-463a-f146-08dbdc9aab81 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 18:28:26.4987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T38lKY1sG0ACO9+1xIEJ3RRLEHqDj1tef+bAZ86VImGjMGeClZ7vSioAUjpUgOCphYYdiBAeT34TiZrxvWS9Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB8293 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 11/3/23 14:12, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> The first one does nothing, it creates a new array_view but without > Simon> using it, it's useless. Mark the slice methods with [[nodiscard]] > Simon> (which is standard C++17) so that error would generate a warning. > > Looks good to me. > > Unfortunately std::span::subspan doesn't seem to have this annotation. > I wonder if it could be added. Is it something that would be mandated by the standard, or just the choice of each implementation? > > Approved-By: Tom Tromey Thanks, pushed. Simon