From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GAEfEycSX2EnbgAAWB0awg (envelope-from ) for ; Thu, 07 Oct 2021 11:28:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 4C2491EE20; Thu, 7 Oct 2021 11:28:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B8691E4A3 for ; Thu, 7 Oct 2021 11:28:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFE093858001 for ; Thu, 7 Oct 2021 15:28:37 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id ACA4E3858002 for ; Thu, 7 Oct 2021 15:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACA4E3858002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 448321E4A3; Thu, 7 Oct 2021 11:28:19 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Fix gdb.threads/check-libthread-db.exp with glibc 2.34 To: Tom de Vries , gdb-patches@sourceware.org References: <20211007125009.GA23264@delia.home> From: Simon Marchi Message-ID: Date: Thu, 7 Oct 2021 11:28:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211007125009.GA23264@delia.home> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-10-07 8:50 a.m., Tom de Vries via Gdb-patches wrote: > Hi, > > When running test-case gdb.threads/check-libthread-db.exp on openSUSE > Tumbleweed (with glibc 2.34) I get: > ... > (gdb) continue^M > Continuing.^M > [Thread debugging using libthread_db enabled]^M > Using host libthread_db library "/lib64/libthread_db.so.1".^M > Stopped due to shared library event:^M > Inferior loaded /lib64/libm.so.6^M > /lib64/libc.so.6^M > (gdb) FAIL: gdb.threads/check-libthread-db.exp: user-initiated check: continue > ... > > The check expect the inferior to load libpthread, but since glibc 2.34 > libpthread has been integrated into glibc, and consequently it's no longer > a dependency: > ... > $ ldd outputs/gdb.threads/check-libthread-db/check-libthread-db > linux-vdso.so.1 (0x00007ffe4cae4000) > libm.so.6 => /lib64/libm.so.6 (0x00007f167c77c000) > libc.so.6 => /lib64/libc.so.6 (0x00007f167c572000) > /lib64/ld-linux-x86-64.so.2 (0x00007f167c86e000) > ... > > Fix this by updating the regexp to expect libpthread or libc. > > Tested on x86_64-linux. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Fix gdb.threads/check-libthread-db.exp with glibc 2.34 > > --- > gdb/testsuite/gdb.threads/check-libthread-db.exp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.threads/check-libthread-db.exp b/gdb/testsuite/gdb.threads/check-libthread-db.exp > index 6ecf40db6a9..423c29978c8 100644 > --- a/gdb/testsuite/gdb.threads/check-libthread-db.exp > +++ b/gdb/testsuite/gdb.threads/check-libthread-db.exp > @@ -58,7 +58,9 @@ with_test_prefix "user-initiated check" { > > # User-initiated check with NPTL possibly uninitialized. > gdb_test "continue" \ > - ".*Stopped due to shared library event.*Inferior loaded .*libpthread.*" > + [multi_line \ > + "Stopped due to shared library event:" \ > + " Inferior loaded .*(libpthread|libc).*"] > > gdb_test_sequence "maint check libthread-db" \ > "libpthread.so possibly not initialized" \ > LGTM, thanks. Simon