From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eWFSOOqyKWrWLQAAWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 14:54:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K4UsJQfz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E26131E070; Wed, 10 Jun 2026 14:54:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59C9D1E070 for ; Wed, 10 Jun 2026 14:54:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7990042170F4 for ; Wed, 10 Jun 2026 18:54:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7990042170F4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K4UsJQfz Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4F3BE41F57B0 for ; Wed, 10 Jun 2026 18:53:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F3BE41F57B0 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4F3BE41F57B0 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781117612; cv=none; b=XD9TY45rsb6GyMZ/TLEkdvCKZ8elW74+6f/KpLyydvLSAlcJpydiBzmRD18ln0nrg7HD5HPqt0TNqNGcWdZMq/4/ZJOga6KropsVvZXlVNNeln9rXDMRvVDLN2Y1quUaqEOllUSiYv0jT3NQn53uoSO1PZ5310X0J5Xl5hSNYvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781117612; c=relaxed/simple; bh=tvRTKRpu8fDBFtxQMn+yj+LPCj6IuKTf3+j8YdV8ckY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=UBhj14yhlKBGqc7AWkvm/UbmnhXli+sZf2YcDLfhm1YfDY3TOAFkZI2zlIVp2v27uJDx2S0G19TYKrCE2TuQ9ZEc6ADq0myi31+IV7laXhnKzIq4wM9Xrn4hDGZc50DZn8NBxma7zcXsyxFpu9muNDD7izKmt4PI5Fir/mrle9o= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K4UsJQfz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F3BE41F57B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781117612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DcsRFu6C9NJ27CQbBNGsP0IMXZ4JjRnuaUw4BQY1zVk=; b=K4UsJQfzYQ/4FXuekH1fVLFdPuRYNrQHF6k1qTPsyzpHKKZFhud5soDj/mCsny2J8yEFOH nUCHlbkUzJdjyCNbBIqQmjxRrFPS9LT82p1+HgRnjUB4Q/sH/gl+ilNQ3agELGgLGN/mCj TQ3x3GzAymBPdT7HV1AXsUxrHYx5Ma4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-AqthlknXP6iyvG0cxF1fMw-1; Wed, 10 Jun 2026 14:53:30 -0400 X-MC-Unique: AqthlknXP6iyvG0cxF1fMw-1 X-Mimecast-MFC-AGG-ID: AqthlknXP6iyvG0cxF1fMw_1781117609 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490b61243easo49933285e9.2 for ; Wed, 10 Jun 2026 11:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781117609; x=1781722409; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DcsRFu6C9NJ27CQbBNGsP0IMXZ4JjRnuaUw4BQY1zVk=; b=HAjOdatJSD/JXVRNg2ehTdoTElfNPCHIjQhj1fvM3HUq7H0npywVeWtDuLqDQzSbGo BT9sAiMBHUKbUlQGOd9usd2zOaLW1o4/s93MW62VUa7TPOUM2hOAgIgBXMxlHkhbClAF ynv6iNh+81/JL8TGgK6EBNPQpTwGY1nVn8R2b/SOvFDBRlVSqoaXZco6O+OzVPmOeFhg zV2ql+TrCrrM18Ldd+6VGQfKQpjmgSG1bJdxQu3r0dp+/hqQBhT4yyrz5KJ2VjdHX7/A NVWdGKMy9ScE3P6vTXPLCZkBCRItkYC/7FOEj3BdXdX3VAJpFGFAXzmBajptYwK24PgF j7hA== X-Gm-Message-State: AOJu0Yzos6hlEAOPsCuHVZANK6DLbz37df06HGKDZe8eP6GNtnj1t3YB lwlBhv+K+/Uf4WVHNDfgT0qsWTipPwE3ALK9ruGyiqPLADQm8kt2xh+AcQoPoXQFNpoJXuZ/ybS Imub/h0HoRBZG9XBaiHIenexC79XgTfLQvvYhydjd0iqohGnQ9JnlTTHA+UzWeYK9Bx0moiQGKC SjajmEEDH5FmeFpA7jrQAj8sXWXuJFowQXnGNXOAoRh2Y4g0A= X-Gm-Gg: Acq92OF3sRfUZGnZvAxbr7VBIoGuATZq3FeghdQPxHa0Mi3eTPjtsknJLBooyRvi6/F e4yWV8b7exXCKCrhy+fmc4dxL6HrRIZqjHXvqD9XwDNtt3D02KbmAhepJnQYJ0kxGrwNtxTYLiG QeZ/v8twIbWJpY+wvz0Syyh/7eIH0Ztb/10gPmui8WMGtPKi8VHelRkZaqdlPzDhoyQfFgXAYbC +9DrdxoBnP+7/yeceh3PBKR16U3CjbpZ2JNYkgs8qR1RHVAPC22UQHvQk++LB9U9OhxKTOK7W8A +cZzLeQJgnTyOS+ptCmS5Yfla2igcp1HBXYWAcD9wOBtphAwqIKdiav8q0ehMvthGhdD/wG2Mya dz/53MBKG4QlBrA7NRH663HgOITKVU0dG0yPcp1XIEiUV27WrZ6OmIvkx X-Received: by 2002:a05:600c:8285:b0:490:abef:dae6 with SMTP id 5b1f17b1804b1-490c25b09bcmr445140405e9.19.1781117609336; Wed, 10 Jun 2026 11:53:29 -0700 (PDT) X-Received: by 2002:a05:600c:8285:b0:490:abef:dae6 with SMTP id 5b1f17b1804b1-490c25b09bcmr445140195e9.19.1781117608784; Wed, 10 Jun 2026 11:53:28 -0700 (PDT) Received: from localhost (92.40.184.118.threembb.co.uk. [92.40.184.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2c76c09sm4927975e9.1.2026.06.10.11.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 11:53:28 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: remove debug output messages from testsuite Date: Wed, 10 Jun 2026 19:53:24 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TVXUrej5PGmQit06IFcg2ZGyh8FmF2XXQ2T-56Mb-iE_1781117609 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Over time I've managed to leave various debug logging messages in the testsuite, all of which include the 'APB' tag that I use to make searching for these easier. None of these were required, they could all be removed. I have left the logging output in gdb.base/stap-probe.exp (but with the 'APB' removed) as it looked slightly useful, and it's harmless to keep it. But all of the other logging lines I just removed. There should be no change in what is tested after this commit. --- gdb/testsuite/gdb.base/attach-deleted-exec.exp | 2 -- gdb/testsuite/gdb.base/stap-probe.exp | 8 ++++---- gdb/testsuite/gdb.cp/virtfunc.exp | 2 -- gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp | 2 -- gdb/testsuite/gdb.fortran/lbound-ubound.exp | 4 ---- gdb/testsuite/lib/dwarf.exp | 4 ---- 6 files changed, 4 insertions(+), 18 deletions(-) diff --git a/gdb/testsuite/gdb.base/attach-deleted-exec.exp b/gdb/testsuite/gdb.base/attach-deleted-exec.exp index 61ee8647c9c..5d3f43eff00 100644 --- a/gdb/testsuite/gdb.base/attach-deleted-exec.exp +++ b/gdb/testsuite/gdb.base/attach-deleted-exec.exp @@ -97,8 +97,6 @@ if { [target_info gdb_protocol] == "extended-remote" } { set filename_re "\[^\r\n\]+/${testfile} \\(deleted\\)" } -verbose -log "APB: warning: No executable has been specified, and target executable $filename_re could not be found\\. Try using the \"file\" command\\." - gdb_test "attach $testpid" \ [multi_line \ "Attaching to process $decimal" \ diff --git a/gdb/testsuite/gdb.base/stap-probe.exp b/gdb/testsuite/gdb.base/stap-probe.exp index b157e2c13a7..00f91a5723a 100644 --- a/gdb/testsuite/gdb.base/stap-probe.exp +++ b/gdb/testsuite/gdb.base/stap-probe.exp @@ -90,16 +90,16 @@ proc check_for_usable_xmm0_probe { binfile } { # First, look for the xmmreg probe, and if we find it, grab the # argument string. if {![regexp {\n\s+Provider: test\n\s+Name: xmmreg\n[^\n]+\n\s+Arguments: ([^\n]+)\n} $output ignore arguments]} { - verbose -log "APB: Couldn't find probe at all" + verbose -log "Couldn't find probe at all" return false } - verbose -log "APB: Matched on '$ignore'" - verbose -log "APB: arguments: '$arguments'" + verbose -log "Matched on '$ignore'" + verbose -log " arguments: '$arguments'" # Check the argument string mentions xmm0. if {![regexp {@%?xmm0} $arguments]} { - verbose -log "APB: Prove doesn't use xmm0 register" + verbose -log "Probe doesn't use xmm0 register" return false } diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp index eecf4611e23..f6ff98d96f5 100644 --- a/gdb/testsuite/gdb.cp/virtfunc.exp +++ b/gdb/testsuite/gdb.cp/virtfunc.exp @@ -242,8 +242,6 @@ proc make_one_vtable_result {name args} { set result [string range $result 0 end-[string length $nls]] } - verbose -log "APB: result: '$result'" - return $result } diff --git a/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp b/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp index c0b1265a8dc..1920ec3ee98 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-skipped-line-entries.exp @@ -173,8 +173,6 @@ proc check_end_markers { expected_symtab test_spec } { upvar 1 $varname upvar_addr set addr [string range $upvar_addr 2 end] - verbose -log "APB: index: $index, addr: $addr" - set symtab "" set saw_line false gdb_test_multiple "maint info line-table" \ diff --git a/gdb/testsuite/gdb.fortran/lbound-ubound.exp b/gdb/testsuite/gdb.fortran/lbound-ubound.exp index e0bcbbd62ea..6d3c4b98779 100644 --- a/gdb/testsuite/gdb.fortran/lbound-ubound.exp +++ b/gdb/testsuite/gdb.fortran/lbound-ubound.exp @@ -76,10 +76,6 @@ while { $test_count < 500 } { error "failed to extract expected results for ubound" } - verbose -log "APB: Run a test here" - verbose -log "APB: Expected lbound '$expected_lbound'" - verbose -log "APB: Expected ubound '$expected_ubound'" - # We want to take a look at the line in the previous frame that # called the current function. I couldn't find a better way of # doing this than 'up', which will print the line, then 'down' diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index ca2278606d6..839c5174265 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -143,8 +143,6 @@ proc build_executable_and_dwo_files { testname executable options args } { return -1 } - verbose -log "APB: SPEC: $spec" - set s [lindex $spec 0] set local_options [lindex $spec 1] @@ -182,8 +180,6 @@ proc build_executable_and_dwo_files { testname executable options args } { } } - verbose -log "APB: OBJECTS = $objects" - set ret [$func $objects "${binfile}" executable $options] if { $ret != "" } { untested $testname base-commit: 6ef2098548092df5bdb85c5e928fc235df21e97f -- 2.25.4