From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106354 invoked by alias); 8 Nov 2016 12:48:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106337 invoked by uid 89); 8 Nov 2016 12:48:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=regularly, badly, sal, 20161108 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Nov 2016 12:48:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BD2CC04B928; Tue, 8 Nov 2016 12:48:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA8CmMhl021497; Tue, 8 Nov 2016 07:48:22 -0500 Subject: Re: [PATCH] Fix PR breakpoints/20739: Badly formatted adress string in error message To: Simon Marchi , "Cordian A. Daniluk" References: <20161029183957.32605-1-th3c0r1uk@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 08 Nov 2016 12:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00159.txt.bz2 On 10/29/2016 08:57 PM, Simon Marchi wrote: >> old_chain = make_cleanup (xfree, msg); >> >> if (!rslt) >> - error (_("May not have a fast tracepoint at 0x%s%s"), >> + error (_("May not have a fast tracepoint at %s%s"), >> paddress (sarch, sal->pc), (msg ? msg : "")); >> >> do_cleanups (old_chain); > > That seems like an obvious fix to me, thanks for addressing it. Agreed. > That means to put the PR mention above the list of files. The > description should tell more or less precisely _what_ has changed (and > not _why_ it was changed, that belongs to the commit message, which is > already clear in your case). > > For example: > > PR breakpoints/20739 > * breakpoint.c (check_fast_tracepoint_sals): Don't print duplicate 0x > prefix. Thanks, I copied that into the patch. > I don't see your name in MAINTAINERS, do you have write access to the > repo? If you plan to contribute patches regularly, it would be a good > idea for you to go through the process to get it (you'll need assistance > from one of the global maintainers). Otherwise, somebody else with > write access can push it for you. I've pushed it in now, as below. >From 53c3572a9f5b03a92292cb6d24bf69b52c95500e Mon Sep 17 00:00:00 2001 From: "Cordian A. Daniluk" Date: Sat, 29 Oct 2016 20:39:57 +0200 Subject: [PATCH] Fix PR breakpoints/20739: Badly formatted adress string in error message Remove duplicate `0x'-prefix for the hex address printed. `paddress' already prepends this, so no need to do it manually. gdb/ChangeLog: 2016-11-08 Cordian A. Daniluk PR breakpoints/20739 * breakpoint.c (check_fast_tracepoint_sals): Don't print duplicate 0x prefix. --- gdb/ChangeLog | 6 ++++++ gdb/breakpoint.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index db5ec9b..099c63e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2016-11-08 Cordian A. Daniluk + + PR breakpoints/20739 + * breakpoint.c (check_fast_tracepoint_sals): Don't print duplicate + 0x prefix. + 2016-11-08 Yao Qi * rust-lang.c (val_print_struct): Fix indentation. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 3908dab..9f9cb8a 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -9653,7 +9653,7 @@ check_fast_tracepoint_sals (struct gdbarch *gdbarch, old_chain = make_cleanup (xfree, msg); if (!rslt) - error (_("May not have a fast tracepoint at 0x%s%s"), + error (_("May not have a fast tracepoint at %s%s"), paddress (sarch, sal->pc), (msg ? msg : "")); do_cleanups (old_chain); -- 2.5.5