From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101311 invoked by alias); 29 Jan 2018 17:31:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101299 invoked by uid 89); 29 Jan 2018 17:31:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jan 2018 17:31:30 +0000 Received: by mail-wm0-f45.google.com with SMTP id t74so15938592wme.3 for ; Mon, 29 Jan 2018 09:31:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iLJlcZTH/xlOnv5PLJ1a59iJKE5gpaF8xzGYTkC5iqc=; b=M6TG2DImWu+pyYgj9GCFjdbYc6Jq7S7vfKxg4ukaw59IMtB8X7JsQCvMYHkx7VRkXI VTdEn6NFoYQTVsBy2K7njZFzIe2DthdwX8AF0No9QsWlJ62Oba/eKbuqpfIsa+L0vzXr WyGIrXPNwStjbQ92J3ntEUhNd2YHpSXMU6lbUOXPB098aY1UHBkRNrp4SiLFYYpsOLfD rR6pvdUeCtUXKr8pz491XuvEX5CIZQXG945vFlezuMtkUdOxhUHkrWf1IvrgX+9fIGtI Ai5H5fUKZ/m2u/FXovXXScOiPEyNDrfL94G4s0rIigDDfEmxF3PiNMZqItvno2ieXvRo /6Dw== X-Gm-Message-State: AKwxytcXXllPcst8nuvsLDExfJeAZT1FqGrhoCJiNOzZ/O2z6iiq+PgA KgxCke7wHHp/7SGWeCwHKhTQSg== X-Google-Smtp-Source: AH8x225EdlQKRYnM3js4WWWXlRS7DVZyS4vVmLk5pkMsJCdQtz3uJvtvup13m+tZZxPPYjGEXkR8DA== X-Received: by 10.28.141.144 with SMTP id p138mr20243726wmd.58.1517247088812; Mon, 29 Jan 2018 09:31:28 -0800 (PST) Received: from ?IPv6:2001:8a0:f915:7500:56ee:75ff:fe8d:232b? ([2001:8a0:f915:7500:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k3sm14062807wmk.3.2018.01.29.09.31.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 09:31:27 -0800 (PST) Subject: Re: [Regression] Segfault on native-extended-gdbserver + fork To: Simon Marchi References: <20180119161628.21611-1-simon.marchi@polymtl.ca> <20180119161628.21611-3-simon.marchi@polymtl.ca> <87efmaebo3.fsf_-_@redhat.com> <931f8b594f7405649778f66ab2960a40@polymtl.ca> <669ec8c3-caa3-6901-b26c-00a7e20bc0d1@redhat.com> <1b82573ce66790c935eaff87b7565907@polymtl.ca> <8bbb4b6c-46eb-21c3-dad8-327bea8485fd@redhat.com> <5a92a367fa44671fb875fd59528c2bda@polymtl.ca> Cc: Sergio Durigan Junior , gdb-patches@sourceware.org, Simon Marchi From: Pedro Alves Message-ID: Date: Mon, 29 Jan 2018 17:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5a92a367fa44671fb875fd59528c2bda@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-01/txt/msg00608.txt.bz2 On 01/29/2018 05:03 PM, Simon Marchi wrote: > On 2018-01-29 11:58, Pedro Alves wrote: >> On 01/29/2018 04:25 PM, Simon Marchi wrote: >> >>> It's true that it's a bit of a lie to say "[Inferior PID detached]" if there never actually was an inferior for that PID.  Since we never print "[Inferior PID detached]" on native in that case, I am fine with removing the call from remote.c.  Sergio, that would fix the crash you found I think? >> >> A tangent: >> >> We should probably change that message from: >> >>  [Inferior PID detached] >> >> to something like: >> >>  [Inferior ID (process PID) detached] >> >> I.e.: >>  [Inferior 24822 detached] >> vs: >>  [Inferior 1 (process 24822) detached] >> >> In patch form, something like this: >> > Agreed.  Though I don't think Sergio's original patch is needed if we instead remove the detach_inferior call in remote.c, so your patch shouldn't be based on his. Yeah, my patch was a tangent / orthogonal to his regression fix. It was against master. I was thinking more about the whole effort to enable "set print inferior-events" on by default that Sergio is working on in context of: Thanks, Pedro Alves