From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZtQuBAR7CmKsXAAAWB0awg (envelope-from ) for ; Mon, 14 Feb 2022 10:53:40 -0500 Received: by simark.ca (Postfix, from userid 112) id F34351F3C5; Mon, 14 Feb 2022 10:53:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 642FF1EDF0 for ; Mon, 14 Feb 2022 10:53:39 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 079B63858023 for ; Mon, 14 Feb 2022 15:53:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 079B63858023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644854018; bh=WB9NxD7jwMUEJBtstBvROKkC4o/eTbXX6by/fv/zTtE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bPlU427HUx3Rt9+RhksBdBCnfyotYaE8J9ChOFt/5gacSAH8Lg5LKq2IwEm9lFDSx oxmNVH91LjZ8Q3/9UOCYq3hxBPCG1v9P5TO+WspzGYfKVOOSewOeMipf0eVA4qBtvL KQuQ7npgqF1Nt+p+6GZvNrjvePRphSn/hZBc8MDk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 870FF3858413 for ; Mon, 14 Feb 2022 15:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 870FF3858413 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21EFrCJZ018575 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Feb 2022 10:53:17 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21EFrCJZ018575 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 618821EDF0; Mon, 14 Feb 2022 10:53:12 -0500 (EST) Message-ID: Date: Mon, 14 Feb 2022 10:53:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] Add initializers to bound_minimal_symbol Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220208204245.2186900-1-tromey@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 14 Feb 2022 15:53:12 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-02-11 08:34, Simon Marchi via Gdb-patches wrote: > On 2022-02-08 15:42, Tom Tromey via Gdb-patches wrote: >> This adds initializers to bound_minimal_symbol, allowing for the >> removal of some calls to memset. > > I was trying to see if it would be better to have a constructor (with > two arguments instead), so that we would never have an uninitialized > bound_minimal_symbol. But there are cases where we really want to > initialize it as "empty" and then check for emptiness later, so your > change makes sense. > > Simon Hmm, I see this with g++-11: /home/smarchi/src/binutils-gdb/gdb/linespec.c: In function ‘void add_minsym(minimal_symbol*, objfile*, symtab*, int, std::__debug::vector*)’: /home/smarchi/src/binutils-gdb/gdb/linespec.c:4276:52: error: could not convert ‘{minsym, objfile}’ from ‘’ to ‘bound_minimal_symbol’ 4276 | struct bound_minimal_symbol mo = {minsym, objfile}; | ^ | | | Not sure what's the best way to fix this, possibly to add constructors to bound_minimal_symbols. Simon