From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] dwarf2read.c: Make dir_index and file_name_index strong typedefs
Date: Wed, 29 Mar 2017 15:36:00 -0000 [thread overview]
Message-ID: <bdb989bd0be163890db3d02b0931664a@polymtl.ca> (raw)
In-Reply-To: <1490754298-9455-4-git-send-email-palves@redhat.com>
On 2017-03-28 22:24, Pedro Alves wrote:
> @@ -1169,7 +1179,7 @@ file_entry::include_dir (const line_header *lh)
> const
> {
> /* lh->include_dirs is 0-based, but the directory index numbers in
> the statement program are 1-based. */
> - return lh->include_dir_at (dir_index - 1);
> + return lh->include_dir_at (to_underlying (d_index) - 1);
Should include_dir_at's parameter be a dir_index? At this point,
exposing a zero based index in the line_header interface is exposing its
internal implementation. Same for file_name_at.
next prev parent reply other threads:[~2017-03-29 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 2:25 [PATCH 0/5] dwarf2read.c: Some C++fycation Pedro Alves
2017-03-29 2:25 ` [PATCH 2/5] gdb::optional: Add observers Pedro Alves
2017-03-29 2:25 ` [PATCH 1/5] dwarf2read.c: Some C++fycation, use std::vector, std::unique_ptr Pedro Alves
[not found] ` <ef286ec115c7c1986e41dd08ecf14fcf@polymtl.ca>
2017-04-04 18:57 ` Pedro Alves
2017-03-29 2:25 ` [PATCH 3/5] dwarf2read.c: Make dir_index and file_name_index strong typedefs Pedro Alves
2017-03-29 15:36 ` Simon Marchi [this message]
2017-04-04 18:54 ` Pedro Alves
2017-04-04 19:06 ` Pedro Alves
2017-03-29 2:25 ` [PATCH 5/5] dwarf2read.c: C++fy lnp_state_machine Pedro Alves
2017-03-29 2:32 ` [PATCH 4/5] Make sect_offset and cu_offset strong typedefs instead of structs Pedro Alves
2017-03-29 15:46 ` Simon Marchi
2017-04-05 15:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb989bd0be163890db3d02b0931664a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox