From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125456 invoked by alias); 23 Nov 2016 12:02:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125332 invoked by uid 89); 23 Nov 2016 12:02:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=benson, Benson, gary, Gary X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 12:02:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F84580503; Wed, 23 Nov 2016 12:02:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uANC2LQf028142; Wed, 23 Nov 2016 07:02:21 -0500 Subject: Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver. To: Gary Benson , Walfred Tedeschi References: <1478166445-21370-1-git-send-email-walfred.tedeschi@intel.com> <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com> <20161110123701.GB25185@blade.nx> Cc: eliz@gnu.org, brobecker@adacore.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 23 Nov 2016 12:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110123701.GB25185@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00665.txt.bz2 On 11/10/2016 12:37 PM, Gary Benson wrote: > Walfred Tedeschi wrote: >> diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure >> index bbce742..376ca9d 100755 >> --- a/gdb/gdbserver/configure >> +++ b/gdb/gdbserver/configure >> @@ -7591,6 +7591,32 @@ _ACEOF >> fi >> >> >> +# See if supports the %fs_base and %gs_bas amd64 segment registers. >> +# Older amd64 Linux's don't have the fs_base and gs_base members of >> +# `struct user_regs_struct'. > > I'd mildly prefer to see these comments wrapped at 72 columns, There's a typo "%gs_bas" in there. It's present in gdb's configure.ac too, where this was copied this from. With the typo fixed, the line exceeds 80 columns, so the paragraph will need to be reflowed anyway. So OK with typo fixed and comment re-wrapped. Thanks, Pedro Alves