From: Nick Clifton <nickc@redhat.com>
To: Jim Wilson <jim.wilson@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] aarch64 sim uzp1/uzp2 bug fix
Date: Mon, 09 Jan 2017 09:19:00 -0000 [thread overview]
Message-ID: <bda55226-37f4-4975-d1d4-88aa75a6fe54@redhat.com> (raw)
In-Reply-To: <CABXYE2VmhRWyaraxJngVqVX=BcvvR5eREU0VU1VSCDuz2q4s1A@mail.gmail.com>
Hi Jim,
> The uzp1/uzp2 implementation has a number of problems I had to
> rewrite it. It doesn't get the shifting/masking right. it gets
> input1 and input2 wrong. It checks one bit instead of two for the
> size field. It doesn't fail for the non-full size==3 (1d) case which
> should be an unallocated instruction.
I apologise - I must have been asleep when I wrote that code.
> The new testcase passes with the patch, and fails without. The GCC C
> testsuite failures go from 2269 to 2227 (-42).
Excellent - patch approved - please apply.
Cheers
Nick
prev parent reply other threads:[~2017-01-09 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 5:14 Jim Wilson
2017-01-09 9:19 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda55226-37f4-4975-d1d4-88aa75a6fe54@redhat.com \
--to=nickc@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jim.wilson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox