From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2dLFAuOxrmqybyEAWB0awg (envelope-from ) for ; Sat, 19 Sep 2026 12:01:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HGK1+07R; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ONcD7EXi; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vuk50xav; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1Z4MtoCb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 045B51E06B; Sat, 19 Sep 2026 12:01:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 540E31E01F for ; Sat, 19 Sep 2026 12:01:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBDC74BAE7C0 for ; Sat, 19 Sep 2026 16:01:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBDC74BAE7C0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HGK1+07R; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ONcD7EXi; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vuk50xav; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1Z4MtoCb Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 8E9844BA2E15 for ; Sat, 19 Sep 2026 16:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E9844BA2E15 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E9844BA2E15 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789833674; cv=none; b=phg7hbwTZyyHZ5sfQ9stcTJ4AnfUKiJxpBWe7TBLeu1XSVVtyY92PYMaPZj6dFWETDc39tfTe3JGte4WFfU5m41nleIg7ashQrxc5XMjRsTq4CMyFzH7cMC2/pOaPU0cQ06T/FFJqeHjZ2XYrNfHoogbDEDBdSh9hj+K24rUUnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789833674; c=relaxed/simple; bh=bt5yr9eo1U9RvVyiLDBg9U37oL80hhayrjGVuIdiuvY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=jH03FhcHIfnGKUH0W4riX3Di3eaKS8b8tOdTojdSu/SCO7409KLWhNJWdyOkD67qnCoqRG7OUoCM1Deg2PIR3YfZAWLSIAW8ZZrY+/WIs/xnP9yuGo+nkGz/nI0qVEhW7cqsImyvkXu2Z/Om504LqM04rI0a5bAxvHU6J9aDCjk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HGK1+07R; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ONcD7EXi; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vuk50xav; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1Z4MtoCb DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E9844BA2E15 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 77B851F83B; Sat, 19 Sep 2026 16:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789833669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjSTLbQlp8rInowS4VMQCjGcxbNFaHzV8h1aWqp1bMo=; b=HGK1+07RJe0lilrsjcq86PRUrvqJRF55goRuLBsO65N6kCz67r9rNcnL4e9m1bEHGCaxNO eZdcHenfEbb7kNDx7Bxt3KsYKbdOCG91PReiNWU7ZnhViNo1o4tJtyPYGH5wC9w8JWTBS7 ZYGuqFWD39B41iIXLkqDpej8WdyeTX0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789833669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjSTLbQlp8rInowS4VMQCjGcxbNFaHzV8h1aWqp1bMo=; b=ONcD7EXiATp8HX9ARJf4bkDJirWxVtrLWtX2G4j6TC1IpweUir3MEw8mLVGK/aVi3Pqtuj wiFEgO6LGkqzVCCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vuk50xav; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1Z4MtoCb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789833665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjSTLbQlp8rInowS4VMQCjGcxbNFaHzV8h1aWqp1bMo=; b=vuk50xav8SRTd/niDDNql6jM6SN+2NYgKuRrseRWajBQ064UTR0LtyAnraeETBhDGxBLED qe1JP+v57QYSuIR2Ex8WTKgI0KnLlFCNv9CEmKWV036ypAadcobg9+8/7fLZsJxsgg0eKw CMd1HH6EGfj5Po/bMFvgAuz3KKO2XcE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789833665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjSTLbQlp8rInowS4VMQCjGcxbNFaHzV8h1aWqp1bMo=; b=1Z4MtoCb4SGTKc41J/1Doq1YQa9OcqbLUNhs7OqfzsBHKGmWSWu6BGSzwwiDDmTtFY12Nz 2jB8LpCe0I+LKABg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 423C3133CF; Sat, 19 Sep 2026 16:01:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IXbjBcGxrmqCIAAAD6G6ig (envelope-from ); Sat, 19 Sep 2026 16:01:05 +0000 Message-ID: Date: Sat, 19 Sep 2026 18:01:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] [gdb/tui] Improve section handling in tui_find_backward_disassembly_start_address From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-4-tdevries@suse.de> <87pkyjy78j.fsf@tromey.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 77B851F83B X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email,suse.de:mid,sourceware.org:url]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/14/26 9:31 AM, Tom de Vries wrote: > On 9/11/26 8:26 PM, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> -  /* Find the section that ADDR is in, and look for the start of >> the >> Tom> -     section.  */ >> Tom> -  struct obj_section *section = find_pc_section (addr); >> Tom> +  /* Find the first section with start address before ADDR, and >> use its start >> Tom> +     address.  The found section may be the one containing ADDR, >> or the one >> Tom> +     before it.  */ >> Tom> +  struct obj_section *section; >> Tom> +  for (int offset = 0; offset <= 1; ++offset) >> Tom> +    { >> Tom> +      section = find_pc_section (addr - offset); >> Tom> +      if (offset == 0 && section != nullptr && section->addr () >> == addr) >> Tom> +    { >> Tom> +      /* If ADDR is the start of its section, use ADDR - 1.  */ >> Tom> +      continue; >> Tom> +    } >> Tom> + >> Tom> +      break; >> Tom> +    } >> >> I was puzzling about this.  It seems like it would be ok to always check >> "addr-1" here?  Since if addr is not at the start of the section, it >> will return that same section.  And if addr is at the start of the >> section, then that's the answer you want? >> > > Thanks for that observation, that greatly simplifies things. > I've pushed this, with a test-case added ( https://sourceware.org/pipermail/gdb-patches/2026-September/230469.html ). Thanks, - Tom > Thanks, > - Tom > >> Tom >