From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sAt9LDHEqGGXRwAAWB0awg (envelope-from ) for ; Thu, 02 Dec 2021 08:03:45 -0500 Received: by simark.ca (Postfix, from userid 112) id A63AD1F0CE; Thu, 2 Dec 2021 08:03:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2274A1ECEB for ; Thu, 2 Dec 2021 08:03:45 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4EBB9385AC3F for ; Thu, 2 Dec 2021 13:03:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4EBB9385AC3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638450224; bh=mFY+nOibM/jI8sznI40BNaH+gR7eY1+OJCMa+kz2DM8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=a9OPOV1DXAjy/dWMjI3KbRE2BoPEpEYa0p9GGcahBY/wqWJylODrg/dVIuoEGaQ0V D1VeeviU7ZxibMtjvRnRLKdTG3wU3xFEfiBLhf8jcOwYqWJ25OHT07JEIEQJWwIl73 dXud9HXNihfxbi0VZqogUR8VfwMARqH5A/i6bcrg= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 2716F3857C5F for ; Thu, 2 Dec 2021 12:59:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2716F3857C5F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F9C01FDFC; Thu, 2 Dec 2021 12:59:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3195514097; Thu, 2 Dec 2021 12:59:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Dk7iCiDDqGEbNQAAMHmgww (envelope-from ); Thu, 02 Dec 2021 12:59:12 +0000 Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp To: Tom Tromey References: <20211126094852.32283-1-tdevries@suse.de> <87ilw98jj6.fsf@tromey.com> <87k0gpuo30.fsf@tromey.com> <4e9e03b7-170f-4493-cd7e-0759357b8a43@suse.de> <87fsrc6xsb.fsf@tromey.com> Message-ID: Date: Thu, 2 Dec 2021 13:59:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87fsrc6xsb.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Tom de Vries via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/1/21 6:27 PM, Tom Tromey wrote: >> Given this, I wonder if we really want to continue supporting this. I >> think it may be better to just declare these as compiler bugs (including >> gdb.ada/dgopt.exp) when using fission. > > Tom> I still don't understand what specific compiler behavior you consider a bug. > > The file name in the CU DIE does not appear in the line table. > OK, it took me a while to understand, but I agree. I was confused by a comment in the dwarf 5 standard: ... Prior to DWARF Version 5, the current compilation file name was not represented in the file_names field. ... But that seems to be incorrect, there's an issue open to correct that ( https://dwarfstd.org/ShowIssue.php?issue=210713.1 ). Anyway, with trunk gcc this no longer occurs, I've bisected the difference to https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=96c82a16b2076891a9974d0f0e96a0b85fbc2df4 . > Tom> FYI, I've now debugged the fission failure of include-main.exp on trunk, > Tom> and found that it's because dw2_get_file_names uses a cutu reader > Tom> constructor that ignores the dwo file. By using the other constructor, > Tom> the test passes: > > I considered this, but when I looked, the .dwo file did not include the > DW_AT_stmt_list. So, I thought this would introduce other problems. > > If this can work, then I think this is the only use of this constructor > and so it could be removed. I ran into regressions when testing this, so I filed a PR, mentioned the tentative patch and a specific regression ( https://sourceware.org/bugzilla/show_bug.cgi?id=28644 ). I'm parking this for the moment. Thanks, - Tom