From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vUDMHdQeVWrpcQYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 13:22:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C0F91E09B; Mon, 13 Jul 2026 13:22:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE5041E033 for ; Mon, 13 Jul 2026 13:22:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35D834BA2E37 for ; Mon, 13 Jul 2026 17:22:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35D834BA2E37 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c202::7]) by sourceware.org (Postfix) with ESMTPS id 608394BA2E19 for ; Mon, 13 Jul 2026 17:21:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 608394BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 608394BA2E19 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c202::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783963319; cv=pass; b=QocjDNBnt8XkYuoRV0ZlZbfEKg7/OdqD9+K6FL8i1bfBwV4SA0znVMwDFEp6kjeLMH4fBciM+Bb5KGDbIUN6UFmcfY/xIaf/us3d00cBccF7YGkRXtBunUET9YvPcAvfU9Sp3Wwyn/fCFRreNWHJnNd//VV/aDq/LC2BwH2Cd/s= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783963319; c=relaxed/simple; bh=7n2H4tfB5jhmN03CFo0rRBhliB34HcByVrYtZzcf+pU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=FUAsQhaaCN+NhOuunyKmDPPnEvqEZvB26KujqhpYPswmmBIMMstiebN6MROv2P25C2wp3GLxtUDA6I+Sa7z1JDdxh2UZ6wmQLHQh4V/dwAHCeaPEAENkE4L2dbbB+ovwdyS0dGVrUiHOV2A73fgET7aU67hOFvgvZUqIuV093r4= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=l5xaxh6G DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 608394BA2E19 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=QN7MYnL26bsZChFzv81Hu399EF6K7XqB3X27vnhUgi38Gap/pJv2WvTfYh10NkA59tjZFUveBXJkkngBRory1jfYNEgIEhzp5iP9t8FVtsW7cWYT3rvbh9txIcf0wJRBOlG+elUEK+MzA/J93tG4fGKS2vIGT2V1fXJNegy+iShqH7jmpYZAyLIotdEumnCNg6aKWXXtBpM8FF+eUvg9UMusiaRh++/EKf+lzl0VAhhG2yANMQBs9plvt3oeHmK1DNpQI3QXOE4E/FaKHancySSRKe1So30oyp+2qIdYDkYOlaNqNHyFHa0M4aoOVNHliAcmH2iuUfXOjLv+dCI/qQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NPSFDGDbYiXGpAUqmAW4z+FFQPpCjR4ydHIhlzXctis=; b=XK/wWi6zO1b6MMlCmoljEA5DKYlN4n3gawqBjMyWN1gekdYpzFg5lZELuewojuO9qX5SKmF22Q2gVOetUxW33l7StaGKSEbG+GmxG6/bc7mTXdPbMR1HmMilZ+rgc4rQ0RKnXv1EXFiRg241raGRqCWEsKOjazhrDuFitKMBtdZDwmsJRapEitrR2B9sIVu6dzJ3o2CSF2fAULbQ7H8UPTlsVXbJuNjnmPK8w9SOEAX+BhZ8mRNsOoB1/3NB1CTbPfHy9NNTVTeEvNDABm0BN3o7ZJuUmSmThNZptfpCh5rm2+IBuhQfFbSrOOfBsn+17p/1ANQr8tdXpcKHmbRZTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linaro.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPSFDGDbYiXGpAUqmAW4z+FFQPpCjR4ydHIhlzXctis=; b=l5xaxh6G7QCSKuYD1syKGgg0F0nxdpWsFM0U/coWCXWWnFGBRvZhal7Y+P02iOuWPOsq0M6KGwwfvzEmYADxlepn/dcuodbIrReCrLr7as8gNWbkqqjkAc7Snx4Fqxw7v6f8QidGIwA6DKWd65GRy5GFcwHFKGi+so07AylwM8Q= Received: from DUZPR01CA0005.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::9) by DBBPR08MB6233.eurprd08.prod.outlook.com (2603:10a6:10:204::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Mon, 13 Jul 2026 17:21:44 +0000 Received: from DU6PEPF0000B622.eurprd02.prod.outlook.com (2603:10a6:10:3c3:cafe::2e) by DUZPR01CA0005.outlook.office365.com (2603:10a6:10:3c3::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 17:21:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU6PEPF0000B622.mail.protection.outlook.com (10.167.8.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 17:21:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b+t1VqT9aa5sJlJau56zdsAJodVOjHqoD46JrAwOgyY4LfS+qwaxEd+GTxMDNeTtnC6WbeYXtUz/5tQC4YhM6MLqArLTMtif2iqdl6F8JKqPYRTg4Wlh2JimsBa/pmWyJLvXJ764cvXRhSFD+Zq5cpJ703Glf42XRpGIHYkIbkuMKVRD0eUDS2QguqRIk87POBefSyVlQu8Nj+9UGwytdSsqZ9rTmSTq0Lh7o0pPl4myjG4uZX5KMegrhfgjMY7xWkGpgarvM9HqqwiYusWhwHgQRGuS2oC6HsOWYjQgvryij+pnmeaa6m7TJ2CuQKN+OJD+kksbWyk/oQiOedZbTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NPSFDGDbYiXGpAUqmAW4z+FFQPpCjR4ydHIhlzXctis=; b=eIDSupto4YpBX+zBSMVR1T9gTalAS1iaj1TKA8XCrj7FT/44bF+djvaZuwASPjmYVywuDR/3JxM0TSZ+l5meQ+f+BS+Pn6SaC6kx8T6SaK5Kue4zjOcfcgGwYjcnZWoGRebQoosPcU35HBSMq7tQKTjN7uwBX/am6jZxfgHGy8ELuFVP6m06e8ss3jYzyLSOv04Q/tPaN8UWePtJxcBs1pV/XmwCPYhGxiykfioAY8CW19DvdPQ1nUp9L13ntUN1owt4rFc3j/JijIMCc3rn42j5MtvFspEPGGWutchLFn4QVKymCvntKODa2AK6mwiLV/MeKoOiSi9PEwkR9IfUww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPSFDGDbYiXGpAUqmAW4z+FFQPpCjR4ydHIhlzXctis=; b=l5xaxh6G7QCSKuYD1syKGgg0F0nxdpWsFM0U/coWCXWWnFGBRvZhal7Y+P02iOuWPOsq0M6KGwwfvzEmYADxlepn/dcuodbIrReCrLr7as8gNWbkqqjkAc7Snx4Fqxw7v6f8QidGIwA6DKWd65GRy5GFcwHFKGi+so07AylwM8Q= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by AS8PR08MB8328.eurprd08.prod.outlook.com (2603:10a6:20b:56d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.19; Mon, 13 Jul 2026 17:20:38 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 17:20:38 +0000 Message-ID: Date: Mon, 13 Jul 2026 18:20:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/10] gdb/linux-tdep: migrate linux_info_proc to file_reader_t To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Luis Machado , Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-7-matthieu.longo@arm.com> <874ii81xgy.fsf@linaro.org> From: Matthieu Longo Content-Language: en-US In-Reply-To: <874ii81xgy.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0578.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::8) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|AS8PR08MB8328:EE_|DU6PEPF0000B622:EE_|DBBPR08MB6233:EE_ X-MS-Office365-Filtering-Correlation-Id: f835473e-81e6-476c-f990-08dee10335e6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|366016|1800799024|23010399003|8126099003|4143699003|11063799006|56012099006|3023799007|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info-Original: eJzwCeecGN72bJFgaJoM/cWxlwfQD6Zl8MOq91cEq6ROYNF3nQLIFi+Enp4tpl1rk+1/WidZQCvgRYAhwXuqK2QvCNnnWAqn06yaYzWonAK6aq1xsvfeVf1jQcETijuiivO5T1eIfF+Z6X47OdHGydfQheRxiDHuRR4//fI3tgzQk/7QXBp2xgRYK12Mdamrq1y4jhiYDqyj4dhFCzZANhbS61I5f+RW3lFwPpE8IzLNJ7ppOvmePi8jTlbyU7DCX9H+mt/D3f13y+XLYDkQzcspi+o9eAXTyaWLhwMcxSd4wPU/3RAytLtRFJzZFVK7xkw5uH8C2rhNix4f97Hb07fKgFmannXGO7sRjn90HwCII2LZ/XwEIfCC7MDxB3CPn+trnEX9onalp7vi9j+v5WN00o14n0ouSP9bDFX7sfNHKoIsIFGk1suXycCUUzF5KOjpZ7Q2Ab8w5sdUWuFCpOA0FOImHRadCbfUYfBxlaMo5VD2s7inGvcAu7jA3WJkUJ9ClRoJJIsNc0h62JYMVM5qyGGfUHIcZUV9gGjiDKFg3kmF8zNq7n4wWK/6IAJ3dUOY7k4AaY2sIbUfXv4xP3NK7eXQFwkAsE3dIaHSpbqH1UQjkUwMcnMVpYeV7YjEIZATbLrQasYdA/Z+q6W/l9e7GVFUQm2i3Hu37ih8nr0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(8126099003)(4143699003)(11063799006)(56012099006)(3023799007)(18002099003)(22082099003)(6133799003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: ZAYgG2LWhhcWVohwiDPO5mSW6OF3WPmerJTorzGLRjeXbN//5JQ3y6lT14tkwm54s1K5Fluu6J3/wAWV7qZPQ3SwPRbz/meTSvbDYLulgCCV4Et7Gg6UFD+ggq9yWhbGBgOXwRyc2FsEfL2kGsstJ3+MXSja8BXVVaVLf/OBXc4+sKxH2LtxRjh2AY5e/slWb/TZgHiV7mpT8Ah8BVS8udAS3oZxjnP/eszuV6qpjnbwZ7N2934QD97uE3Pb6+QaghsBv/X6gwjKwTQ+UtrgbXsnyKABAu/jZnOcXuYdapj0ws5f/nbUGAKju0qeOj5rFAvA4twpq54yILxDv6PKRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8328 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF0000B622.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 406f4d24-8308-4788-421b-08dee1030eb5 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|36860700016|82310400026|1800799024|376014|35042699022|14060799003|6133799003|22082099003|18002099003|3023799007|4143699003|56012099006|11063799006|8126099003; X-Microsoft-Antispam-Message-Info: GfB47Sc5cTRPglDBWnQZmHg73osbNgyksAiaKOonTEDFwV2qHOgpnM/qibXWQyAfv6emHrK4UQAn02kSRWLGC8+KzsWrUbBv/HDzxuAUVdn+k4WZFpMO+rUcajtVDb/Dn3yjZpEL2+kJUPMv+l7rm+GhNpYm6vu0LoDpNno25K0b6hipm/XCov1soZ7UQEuSDpg8+cV2R67BKoqeSwkv9xMXbWQE4daLPLCXNsgkkvwopQwR9UDK9SZVtnZP3b/IvIOE7MYa79/wBin8AcFCGDujwpW2afMHGpIdkyiGH8R6eN2ilAn7B+u2KXcrbog9YBCj+c2+xEw48HQ59MoEZGdS8h3tdc9KBnhV17NL4YtYr9tLcTv3ZlimPoGHvEy3hjNHFNCOOh6Z6fFHfps5p4yiKW4Q/+VEx12SewKkNAJrAecN1/PKgTNbbySGccFwMndLLFBeo55m3Fm3IPGXlFpvnej2cl47Bg3LJFemWRt9y6yKIQHhAeb0lj3aGQA/wvXf4++Kes6S3+3KXSx6jUwSX05HpMFo5a3Uf8rNkKa0jgua/I/oGaXn/GMeMQ2aJcFuKLEuungz3Utih+FA3g6wYMLD4egyeKv++HwK0pkdInQk3oKd0EgK9EQONXs03buHWBeB8bxTGZ93yuYsc9JwBdzFMKF37SRsaFwp+l6dTsux0Bg5E5i55X885SDbWcF3O53wBLXlYSI+F+7Z6w== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(23010399003)(36860700016)(82310400026)(1800799024)(376014)(35042699022)(14060799003)(6133799003)(22082099003)(18002099003)(3023799007)(4143699003)(56012099006)(11063799006)(8126099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rwPC8bWoxWaMW2A3Z/N9qDjrtfx8nugDwCf2toFyQt/Ol1pR+CyH43fiREEcgM3B9IEIOM34ODpiT0ZmWdgIU8KpcA4Kdgrt3UBoljIRuzIv8v8YEGAWrWbvs+s/gTQrt/1kxbK1qN6WVO+ShoAPesUDCnWlQAlbJsp58fbyXzbJaWij4jsjIUVUqUDfbc3ur/8VwEVxYc4qFGGVRTI5unPMEdJ5awAbDKry9g/gQeUC4K6I8Cq0BiceCSBBNLn7aw1iE8v2ib90d4MSFuUFYTRO6kn1mJpdtB9WQY+iXgf7REUjiWEbPYGA73TNgIToU1Nq9vDzuY4nu11yjXKiRoBWYU99q7Yt8DOSsApG9uKnJnQDqQAR2CCUXX00vEYgeBE679cmOE6OyymgBCRIbLO7QXFdizKgMKZBugP4PnD+G3ZMHYgzZy26Yk/hTnp0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 17:21:43.7696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f835473e-81e6-476c-f990-08dee10335e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B622.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6233 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 09/07/2026 07:35, Thiago Jung Bauermann wrote: > Matthieu Longo writes: > >> The patch migratse the code of linux_info_proc to use file_reader_t to > > Typo: migrates > Fixed. >> read the procfs files. >> The availability of array_views allows to also simplify the logic in >> several places, where null-terminating characters are replaced by spaces, >> or where the file content is iterated line by line. >> In the last case, a new helper function, extract_string_view_from_buffer, >> encapsulates the logic for such iterations where string are separated by >> tokens. >> --- >> gdb/linux-tdep.c | 120 +++++++++++++++++++++++++++-------------------- >> 1 file changed, 69 insertions(+), 51 deletions(-) > > Nice improvement, thanks! > > Just a couple of nits, but: > > Reviewed-by: Thiago Jung Bauermann > >> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c >> index a12a69f03a2..a2af1586d35 100644 >> --- a/gdb/linux-tdep.c >> +++ b/gdb/linux-tdep.c >> @@ -836,6 +836,27 @@ dump_note_entry_p (filter_flags filterflags, const smaps_data &map) >> return true; >> } >> >> +/* In a character buffer where entries are separated by a SEPARATOR character, >> + extract the string view starting at START. >> + Return the extracted view and the iterator to the next entry. */ >> + >> +static std::pair, gdb::array_view::iterator> >> +extract_string_view_from_buffer (gdb::array_view &buffer, >> + gdb::array_view::iterator start, >> + char separator = '\0') >> +{ >> + if (start < buffer.begin () || start >= buffer.end ()) >> + return std::make_pair (gdb::array_view (), buffer.end ()); >> + >> + auto it = std::find (start, buffer.end (), separator); >> + if (it == buffer.end ()) >> + return std::make_pair (gdb::array_view (), buffer.end ()); >> + >> + auto next_start = std::next (it); >> + return std::make_pair >> + (gdb::array_view (start, next_start), next_start); > > This line fits 80 columns and doesn't need to be broken. > Fixed. >> +} >> + >> /* Implement the "info proc" command. */ >> >> static void >> @@ -878,25 +899,20 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args, >> gdb_printf (_("process %d\n"), ptid.pid ()); >> if (cmdline_f) >> { >> - xsnprintf (filename, sizeof filename, "/proc/%ld/cmdline", ptid.lwp ()); >> - gdb_byte *buffer; >> - LONGEST len = target_fileio_read_alloc (nullptr, filename, &buffer); >> - >> - if (len > 0) >> + file_reader_t cmdline_freader >> + (string_printf ("/proc/%ld/cmdline", ptid.lwp ())); >> + if (cmdline_freader) >> { >> - gdb::unique_xmalloc_ptr cmdline ((char *) buffer); >> - ssize_t pos; >> - >> - for (pos = 0; pos < len - 1; pos++) >> - { >> - if (buffer[pos] == '\0') >> - buffer[pos] = ' '; >> - } >> - buffer[len - 1] = '\0'; >> - gdb_printf ("cmdline = '%s'\n", buffer); >> + gdb::array_view cmdline = cmdline_freader.cast_view (); >> + gdb_assert (cmdline[ cmdline.size () - 1] == '\0'); > > Extraneous space after '['. > Fixed. >> + /* Replace null characters splitting the arguments in the command >> + line by spaces, except for the last one. */ >> + gdb::replace (cmdline.slice (0, cmdline.size () - 1), '\0', ' '); >> + gdb_printf ("cmdline = '%s'\n", cmdline.data ()); >> } >> else >> - warning (_("unable to open /proc file '%s'"), filename); >> + warning (_("unable to open /proc file '%s'"), >> + cmdline_freader.c_filepath()); >> } >> if (cwd_f) >> { > Matthieu