From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92608 invoked by alias); 29 May 2018 16:05:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92593 invoked by uid 89); 29 May 2018 16:05:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=picky, gdbs, closer X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 16:05:11 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B296740122B1; Tue, 29 May 2018 16:05:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EE491C726; Tue, 29 May 2018 16:05:09 +0000 (UTC) Subject: Re: [RFA v2] Add "continue" response to pager To: Tom Tromey References: <20180425145200.27734-1-tom@tromey.com> <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> <87d0y44iyi.fsf@tromey.com> <6b0962b4-1867-0003-6310-e874ff1df2f3@redhat.com> <87in79znmh.fsf@tromey.com> <0d86fa29-11aa-089a-69a8-86a0fef481ec@redhat.com> <87lgc3xjfp.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 29 May 2018 17:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87lgc3xjfp.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00769.txt.bz2 On 05/29/2018 03:52 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> With the new text it was sufficient to just update what was expected in >>> this test. So I didn't end up backing out the old race fix. It seemed >>> pretty safe to just leave it alone. > > Pedro> That's fine with me (though you're removing it in the > Pedro> gdb.python/ tests AFAICT). > > In this version I've reverted that as well. Thanks. > Here's a new version. LGTM. One suggestion in the docs below. Sorry about being picky... > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 62ba1d25a4c..f1c879098cf 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -23877,8 +23877,9 @@ Print ten commands just after the commands last printed. > Certain commands to @value{GDBN} may produce large amounts of > information output to the screen. To help you read all of it, > @value{GDBN} pauses and asks you for input at the end of each page of > -output. Type @key{RET} when you want to continue the output, or @kbd{q} > -to discard the remaining output. Also, the screen width setting > +output. Type @key{RET} when you want to continue the output, @kbd{q} > +to discard the remaining output, or @kbd{c} to disable paging for the > +rest of the current command. Also, the screen width setting I'd suggest saying something here closer to gdb's output. For example, above, "continue the output" doesn't suggest that it's only one more page, and, using the verb "continue" for the "c" key I think makes it easier to memorize / understand. Like so: Type @key{RET} when you want to see one more page of output, @kbd{q} to discard the remaining output, or @kbd{c} to continue without paging for the rest of the current command. No need to post a new patch for that, if Eli's OK with it. Thanks, Pedro Alves