From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CE24B3877034 for ; Thu, 19 Mar 2020 13:40:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CE24B3877034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 23D6C1E5F8; Thu, 19 Mar 2020 09:40:10 -0400 (EDT) Subject: Re: [PATCH v4] Avoid get_ptrace_pid() usage on NetBSD in x86-bsd-nat.c To: Kamil Rytarowski , gdb-patches@sourceware.org References: <20200319131801.22487-1-n54@gmx.com> <20200319133607.11872-1-n54@gmx.com> From: Simon Marchi Message-ID: Date: Thu, 19 Mar 2020 09:40:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200319133607.11872-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 13:40:11 -0000 On 2020-03-19 9:36 a.m., Kamil Rytarowski wrote: > Add gdb_ptrace() that wraps the ptrace(2) API and correctly passes > the pid,lwp pair to the calls on NetBSD; and the result of > get_ptrace_pid() on other BSD Operating Systems. Thanks. I can't test, but by inspection this patch LGTM. Simon