From f10f83231bcf196cf80c8214f6460484e330f97d Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Thu, 2 Jul 2020 19:32:40 +0100 Subject: [PATCH 2/2] Fix gdb.base/structs2.exp with Clang gdb.base/structs2.exp fails to run with Clang, because of: gdb compile failed, /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:14: warning: implicit conversion from 'int' to 'signed char' changes value from 130 to -126 [-Wconstant-conversion] param_reg (130, 120, 33000, 32000); ~~~~~~~~~ ^~~ /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:24: warning: implicit conversion from 'int' to 'short' changes value from 33000 to -32536 [-Wconstant-conversion] param_reg (130, 120, 33000, 32000); ~~~~~~~~~ ^~~~~ 2 warnings generated. === gdb Summary === # of untested testcases 1 Fix it by passing actual negative numbers. --- gdb/testsuite/gdb.base/structs2.c | 2 +- gdb/testsuite/gdb.base/structs2.exp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/structs2.c b/gdb/testsuite/gdb.base/structs2.c index 7c8be035221..aac7bce8c15 100644 --- a/gdb/testsuite/gdb.base/structs2.c +++ b/gdb/testsuite/gdb.base/structs2.c @@ -13,7 +13,7 @@ main () bkpt = 0; param_reg (120, 130, 32000, 33000); - param_reg (130, 120, 33000, 32000); + param_reg (-120, 130, -32000, 33000); return 0; } diff --git a/gdb/testsuite/gdb.base/structs2.exp b/gdb/testsuite/gdb.base/structs2.exp index 8a7d9c69378..5722be3109c 100644 --- a/gdb/testsuite/gdb.base/structs2.exp +++ b/gdb/testsuite/gdb.base/structs2.exp @@ -49,5 +49,5 @@ if [test_compiler_info gcc-3-*] { setup_xfail hppa*-* gcc/15860 } gdb_test "continue" \ - ".*pr_char=-126.*pr_uchar=120.*pr_short=-32536.*pr_ushort=32000.*bkpt = 1.*" \ + ".*pr_char=-120.*pr_uchar=130.*pr_short=-32000.*pr_ushort=33000.*bkpt = 1.*" \ "structs2 continue2" -- 2.14.5