From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130168 invoked by alias); 29 May 2018 19:52:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128243 invoked by uid 89); 29 May 2018 19:52:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*RU:209.85.220.193, Hx-spam-relays-external:209.85.220.193, HContent-Transfer-Encoding:8bit X-HELO: mail-qk0-f193.google.com Received: from mail-qk0-f193.google.com (HELO mail-qk0-f193.google.com) (209.85.220.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 19:52:13 +0000 Received: by mail-qk0-f193.google.com with SMTP id 185-v6so12491775qkk.11 for ; Tue, 29 May 2018 12:52:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JfW+QTjCUOqX2bSvdYbzXSqFCaHErLABrMVWuph+ziA=; b=Vz3byG6rlkriHFcn5TLvjVvGICb1Du/jjTOgPtOYtRu0i9gt2Td0Wzc7newRtoKWib IGq+mBfix/DB1f9Jyg2ggPICo5ng4tjgYTt0RWLX6Q1ZFc+PhE91g0KhiaPcDczYCMwg 3sKe5AF59cYLF9V1Csyj7oRAK5mBcsyaCcwVagTRCsTYgoEt0LkgfSAfMl41v+SuoIy0 ESkny+Udo7oSb/g9g1y5CgQh7namcRxuuqT1O0qWTO54AOu6oV9KCT18mdWCZT9+8nko HQvtIHxPTLlPaYjo8Hpf/rTgdEHxxX24oIkKp5gNtwYyCJfrer97daC8UJ2ZrgrhxCds 6c/g== X-Gm-Message-State: ALKqPwfsva1c2QLQi7G4mcWLdIoaq645IUh6F4JGBOACZblBBNVFHkwE wwtkeEJS7s26/wykzPblTa44Pd0m3wI= X-Google-Smtp-Source: ADUXVKIlGAijsCGGeEI/nOsoiMvSmAbT6Ixe6jgJaN5tNwBwI3S/IKWwJVn5rS/m6tNz89yxq0tMTw== X-Received: by 2002:a37:6f01:: with SMTP id k1-v6mr16281121qkc.140.1527623531156; Tue, 29 May 2018 12:52:11 -0700 (PDT) Received: from [192.168.1.11] (cpe-107-15-183-220.nc.res.rr.com. [107.15.183.220]) by smtp.gmail.com with ESMTPSA id 73-v6sm10046334qkc.96.2018.05.29.12.52.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 May 2018 12:52:10 -0700 (PDT) Subject: Re: [RFC][PATCH v3] Consolidate gdbserver global variables To: Pedro Alves , gdb-patches@sourceware.org References: <3153f899-a653-9372-72fd-25ea874f7d3c@redhat.com> <44875dda-adc6-d9a4-940c-0c27aeac574b@redhat.com> <6a41763b-6949-2d32-37fa-9d3f1afceec1@redhat.com> <7d9764b6-d95a-96b4-b064-27ce539327cf@redhat.com> <9988957e-3bf8-cbe8-6c08-58706b11bd60@redhat.com> <9e844707-a2f8-c969-4d09-7ee2fa3bd1ed@redhat.com> <5a41d41f-a0ce-2941-c759-fb1854a1792c@redhat.com> From: Stan Cox Message-ID: Date: Tue, 29 May 2018 20:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <5a41d41f-a0ce-2941-c759-fb1854a1792c@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-05/txt/msg00778.txt.bz2 On 05/25/2018 10:31 AM, Pedro Alves wrote: > You mean, without the change, we trigger a warning? What > does it look like? If we do, then we'll need to address it > somehow, of course, given -Werror. This is vanilla upstream gdb, no patches, with gcc 7.3.1 on F27 ../../../src/gdb/gdbserver/server.c: In function ‘int handle_qxfer_btrace_conf(const char*, gdb_byte*, const gdb_byte*, ULONGEST, LONGEST)’: ../../../src/gdb/gdbserver/server.c:1966:7: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (result != 0) ^~ ../../../src/gdb/gdbserver/server.c: In function ‘int handle_qxfer_btrace(const char*, gdb_byte*, const gdb_byte*, ULONGEST, LONGEST)’: ../../../src/gdb/gdbserver/server.c:1895:7: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (result != 0) ^~ The source is an assignment in a TRY/CATCH TRY { result = target_read_btrace_conf (thread->btrace, &cache); if (result != 0) memcpy (own_buf, cache.buffer, cache.used_size); } CATCH (exception, RETURN_MASK_ERROR) { sprintf (own_buf, "E.%s", exception.message); result = -1; } END_CATCH if (result != 0) return -3; > This "static" here made me notice that there is more global > state stored as function local static variables that should > be moved to client_state. E.g.,: > That can be done as follow up. Will do > remote_debug controls whether to print debug output to gdbserver' > own terminal, so I'm thinking that it should probably remain > a global. Ah yes; I'll do that.