From: Chad Harrington <harrington.chad@gmail.com>
To: gdb-patches@sources.redhat.com
Subject: typo in gdb/gdb_ptrace.c
Date: Thu, 23 Jun 2005 05:39:00 -0000 [thread overview]
Message-ID: <bc65d53d05062222395836675c@mail.gmail.com> (raw)
Below is the diff patch for my fix. It is not critical, but it sure
looks like a mistake to me. This was in gdb-6.3, as you can see. The
preprocessor is told to define PT_ATTACH if PTRACE_DETACH is defined.
I think it should only define PT_ATTACH if PTRACE_ATTACH is defined,
but I think they'd both be defined if one or the other is already
defined anyway... It merely appears to be a typo. :-)
I hope this helps.
-=Chad
chad@CRPC02:~$ cat gdb-6.3/gdb.diff
--- old/gdb/gdb_ptrace.h 2005-06-22 23:12:52.000000000 -0600
+++ new/gdb/gdb_ptrace.h 2005-06-22 23:13:57.000000000 -0600
@@ -93,7 +93,7 @@
/* Not all systems support attaching and detaching. */
#ifndef PT_ATTCH
-# ifdef PTRACE_DETACH
+# ifdef PTRACE_ATTACH
# define PT_ATTACH PTRACE_ATTACH
# endif
#endif
next reply other threads:[~2005-06-23 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 5:39 Chad Harrington [this message]
2005-06-23 9:22 ` Andreas Schwab
2005-06-23 20:11 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc65d53d05062222395836675c@mail.gmail.com \
--to=harrington.chad@gmail.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox