On 19-02-2020 22:28, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> It's incorrect to xfail a gdb test-case for gcc bug.
> 
> I think we've used "kfail" for this in the past, though TBH I never
> truly understood the kfail/xfail distinction and I probably have it
> backward or something.
> 

I went to double check again at my xfail/kfail reference point (
https://opensource.apple.com/source/gdb/gdb-325/src/dejagnu/doc/dejagnu.texi.auto.html
), and found:
...
@item XFAIL
A test failed, but it was expected to fail.  This result indicates no
change in a known environment bug.  If a test fails because the
operating system where the test runs lacks some facility required by the
test (i.e. failure is due to the lack of a feature, not the existence of
a bug), the outcome is @code{UNSUPPORTED} instead.
...

So, I got the xfail and kfail mixed up, and in fact the xfail for a gcc
bug is valid use in the gdb testsuite. Oops.

I've now fixed the xpass by testing more precisely for the xfail.

Committed as attached.

Thanks,
- Tom