From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70728 invoked by alias); 2 Feb 2017 17:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70714 invoked by uid 89); 2 Feb 2017 17:39:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1673, H*f:sk:e08d9eb, H*i:sk:e08d9eb, H*MI:sk:e08d9eb X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Feb 2017 17:39:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDA5981231; Thu, 2 Feb 2017 17:39:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v12HdFES029434; Thu, 2 Feb 2017 12:39:15 -0500 Subject: Re: [PATCH] Move "tee" building down to interpreter::set_logging_proc To: Simon Marchi References: <1486045694-22866-1-git-send-email-palves@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 02 Feb 2017 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00072.txt.bz2 On 02/02/2017 03:17 PM, Simon Marchi wrote: > On 2017-02-02 09:28, Pedro Alves wrote: >> @@ -109,13 +109,13 @@ extern int current_interp_named_p (const char >> *name); >> >> /* Call this function to give the current interpreter an opportunity >> to do any special handling of streams when logging is enabled or >> - disabled. START_LOG is 1 when logging is starting, 0 when it ends, >> - and OUT is the stream for the log file; it will be NULL when >> - logging is ending. LOGFILE is non-NULL if the output streams >> + disabled. START_LOG is true when logging is starting, false when > > START_LOG is not there anymore. From what I understand, it's replaced > with LOGFILE being null or not? You're right. How about this: -- i/gdb/interps.h +++ w/gdb/interps.h @@ -109,10 +109,10 @@ extern int current_interp_named_p (const char *name); /* Call this function to give the current interpreter an opportunity to do any special handling of streams when logging is enabled or - disabled. START_LOG is true when logging is starting, false when - it ends. LOGFILE is the stream for the log file; it's NULL when - logging is ending. LOGGING_REDIRECT is false if the output streams - are to be tees, with the log file as one of the outputs. */ + disabled. LOGFILE is the stream for the log file when logging is + starting and is NULL when logging is ending. LOGGING_REDIRECT is + false if the output streams are to be tees, with the log file as + one of the outputs. */ extern void current_interp_set_logging (ui_file_up logfile, bool logging_redirect); OK? > Otherwise, LGTM. Thanks! -- Pedro Alves